Page MenuHomePhabricator

Modularize HeraldRule transactions
ClosedPublic

Authored by epriestley on Thu, Mar 7, 1:02 PM.

Details

Summary

Ref T13249. See PHI1115. I initially wanted to make bin/policy unlock --owner <user> H123 work to transfer ownership of a Herald rule, although I'm no longer really sure this makes much sense.

In any case, this makes things a little better and more modern.

I removed the storage table for rule comments. Adding comments to Herald rules doesn't work and probably doesn't make much sense.

Test Plan

Created and edited Herald rules, grepped for all the transaction type constants.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Mar 7, 1:02 PM
Owners added a subscriber: Restricted Owners Package.Thu, Mar 7, 1:02 PM
epriestley requested review of this revision.Thu, Mar 7, 1:04 PM
amckinley accepted this revision.Thu, Mar 7, 6:40 PM
amckinley added inline comments.
src/applications/herald/xaction/HeraldRuleNameTransaction.php
35

Unused variable.

This revision is now accepted and ready to land.Thu, Mar 7, 6:40 PM
epriestley retitled this revision from Modularize Herald transactions to Modularize HeraldRule transactions.Thu, Mar 7, 6:40 PM
epriestley updated this revision to Diff 48361.Thu, Mar 7, 7:53 PM
  • Remove unused variable.
This revision was automatically updated to reflect the committed changes.