Page MenuHomePhabricator

Render query strings into concrete scalar "string" values immediately, not lazily

Authored by epriestley on Mar 5 2019, 9:42 PM.



See D20067. (Previously, see T13242.) Currently, qsprintf() returns an object which is turned into a string immediately (to test for errors) and then again later, lazily, for actual use.

In theory, the two renderings may produce different results, if you pass one or more objects to qsprintf(...) and then modify the objects after the qsprintf(...) call but before the query is executed. This would likely be very, very surprising.

To avoid this, immediately render the string and store the flat string value, not the arguments.

This is technically also a performance change (it reduces calls to xsprintf_query() by about 50%, since we don't rebuild the string twice) but now justfiable purely as a correctness/simplicity change.

(I'm going to try to make a followup performance change where we just render the masked string and use it for both values if the masked and unmasked strings are identical, but I'll justify that with profiling.)

Test Plan

Browsed around, everything worked. Checked that sensitive values are properly masked in DarkConsole. (Also, added some debugging echo and observed ~50% fewer calls to xsprintf_query().)

Diff Detail

rPHU libphutil
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 5 2019, 9:42 PM
epriestley requested review of this revision.Mar 5 2019, 9:42 PM
epriestley updated this revision to Diff 48330.Mar 5 2019, 9:43 PM
  • Minor tidying.
amckinley accepted this revision.Mar 7 2019, 6:37 PM
This revision is now accepted and ready to land.Mar 7 2019, 6:37 PM
This revision was automatically updated to reflect the committed changes.