Page MenuHomePhabricator

Tweak the visual style of the ">>" / "<<" depth change indicators slightly
ClosedPublic

Authored by epriestley on Mar 6 2019, 4:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 15 2024, 12:04 PM
Unknown Object (File)
Feb 13 2024, 5:47 AM
Unknown Object (File)
Dec 27 2023, 11:40 PM
Unknown Object (File)
Dec 15 2023, 1:08 PM
Unknown Object (File)
Nov 30 2023, 3:52 AM
Unknown Object (File)
Nov 16 2023, 7:59 PM
Unknown Object (File)
Nov 6 2023, 7:23 AM
Unknown Object (File)
Oct 30 2023, 9:24 PM
Subscribers
None

Details

Summary

Ref T13249.

  • When a line has only increased in indent depth, don't red-fill highlight the left side of the diff. Since reading a diff mostly involves focusing on the right side, indent depth changes are generally visible enough without this extra hint. The extra hint can become distracting in cases where there is a large block of indent depth changes.
  • Move the markers slightly to the left, to align them with the gutter.
  • Make them slightly opaque so they're a little less prominent.
Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Indent Depth Increased, Old:

Screen Shot 2019-03-06 at 8.24.12 AM.png (425×1 px, 83 KB)

Indent Depth Increased, New:

Screen Shot 2019-03-06 at 8.29.16 AM.png (422×1 px, 77 KB)

Indent Depth Decreased, Old:

Screen Shot 2019-03-06 at 8.30.30 AM.png (395×1 px, 80 KB)

Indent Depth Decreased, New:

Screen Shot 2019-03-06 at 8.30.07 AM.png (391×1 px, 80 KB)

This revision is now accepted and ready to land.Mar 7 2019, 6:53 PM
This revision was automatically updated to reflect the committed changes.