Page MenuHomePhabricator

Tweak the visual style of the ">>" / "<<" depth change indicators slightly
ClosedPublic

Authored by epriestley on Wed, Mar 6, 4:36 PM.

Details

Summary

Ref T13249.

  • When a line has only increased in indent depth, don't red-fill highlight the left side of the diff. Since reading a diff mostly involves focusing on the right side, indent depth changes are generally visible enough without this extra hint. The extra hint can become distracting in cases where there is a large block of indent depth changes.
  • Move the markers slightly to the left, to align them with the gutter.
  • Make them slightly opaque so they're a little less prominent.
Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Mar 6, 4:36 PM
epriestley requested review of this revision.Wed, Mar 6, 4:37 PM

Indent Depth Increased, Old:

Indent Depth Increased, New:

Indent Depth Decreased, Old:

Indent Depth Decreased, New:

amckinley accepted this revision.Thu, Mar 7, 6:53 PM
This revision is now accepted and ready to land.Thu, Mar 7, 6:53 PM
This revision was automatically updated to reflect the committed changes.