Page MenuHomePhabricator

Tweak the visual style of the ">>" / "<<" depth change indicators slightly
ClosedPublic

Authored by epriestley on Mar 6 2019, 4:36 PM.
Tags
None
Referenced Files
F18390548: D20251.id48359.diff
Fri, Aug 29, 6:58 AM
F18380631: D20251.id.diff
Thu, Aug 28, 6:05 PM
F18194570: D20251.id.diff
Sun, Aug 17, 11:00 AM
F18186057: D20251.diff
Sat, Aug 16, 5:46 PM
F18100374: D20251.diff
Sat, Aug 9, 11:51 AM
F18090669: D20251.id.diff
Wed, Aug 6, 4:49 PM
F18090534: D20251.id48359.diff
Wed, Aug 6, 4:10 PM
F18090462: D20251.id48343.diff
Wed, Aug 6, 3:52 PM
Subscribers
None

Details

Summary

Ref T13249.

  • When a line has only increased in indent depth, don't red-fill highlight the left side of the diff. Since reading a diff mostly involves focusing on the right side, indent depth changes are generally visible enough without this extra hint. The extra hint can become distracting in cases where there is a large block of indent depth changes.
  • Move the markers slightly to the left, to align them with the gutter.
  • Make them slightly opaque so they're a little less prominent.
Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Indent Depth Increased, Old:

Screen Shot 2019-03-06 at 8.24.12 AM.png (425×1 px, 83 KB)

Indent Depth Increased, New:

Screen Shot 2019-03-06 at 8.29.16 AM.png (422×1 px, 77 KB)

Indent Depth Decreased, Old:

Screen Shot 2019-03-06 at 8.30.30 AM.png (395×1 px, 80 KB)

Indent Depth Decreased, New:

Screen Shot 2019-03-06 at 8.30.07 AM.png (391×1 px, 80 KB)

This revision is now accepted and ready to land.Mar 7 2019, 6:53 PM
This revision was automatically updated to reflect the committed changes.