HomePhabricator

Modularize HeraldRule transactions

Description

Modularize HeraldRule transactions

Summary:
Ref T13249. See PHI1115. I initially wanted to make bin/policy unlock --owner <user> H123 work to transfer ownership of a Herald rule, although I'm no longer really sure this makes much sense.

In any case, this makes things a little better and more modern.

I removed the storage table for rule comments. Adding comments to Herald rules doesn't work and probably doesn't make much sense.

Test Plan: Created and edited Herald rules, grepped for all the transaction type constants.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13249

Differential Revision: https://secure.phabricator.com/D20258

Details

Provenance
epriestleyAuthored on Mar 7 2019, 12:48 PM
epriestleyPushed on Mar 7 2019, 7:55 PM
Reviewer
amckinley
Differential Revision
D20258: Modularize HeraldRule transactions
Parents
rP9918ea1fb7ca: Fix an exception with user cache generation in "bin/conduit call --as <user>"
Branches
Unknown
Tags
Unknown
Tasks
T13249: 2019 Week 7 - 10 Bonus Content
Build Status
Buildable 22221
Build 30383: Run Core Tests