HomePhabricator

Add a warning to revision timelines when changes land with ongoing or failed…

Description

Add a warning to revision timelines when changes land with ongoing or failed builds

Summary:
Ref T13258. The general idea here is "if arc land prompted you and you hit 'y', you get a warning about it on the timeline".

This is similar to the existing warning about landing revisions in the wrong state and hitting "y" to get through that. See D18808, previously.

These warnings make it easier to catch process issues at a glance, especially because the overall build status is now more complicated (and may legally include some failures on tests which are marked as unimportant).

The transaction stores which builds had problems, but I'm not doing anything to render that for now. I think you can usually figure it out from the UI already; if not, we could refine this.

Test Plan:

  • Used bin/differential attach-commit to trigger extraction/attachment.
  • Attached a commit to a revision with various build states, and various build plan "Warn When Landing" flags.
  • Got sensible warnings and non-warnings based on "Warn When Landing" setting.

Screen Shot 2019-03-01 at 7.49.43 AM.png (181×562 px, 20 KB)

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13258

Differential Revision: https://secure.phabricator.com/D20239