And thanks for doing the legwork to pull a reproduction case out of this.

For context, we issue a query that looks like this:

haha nice. I just posted this comment on our downstream task tracking this.

fix is one line long :3

Thanks! This reproduces for me.

How does Pholio manage to not send HTML email? That's quite impressive!

I couldn't find a project with multiple subprojects on this install otherwise I would have linked you to an example

This is generally easy to implement.

Yeah, not on EditEngine.

Also, why can't I add Subscribers through this comment interface? Not on EditEngine?

I'd probably take another pass at the UI / Colors, but I like the UX of it. Other ideas thought about but not mocked:

@aklapper has pointed me to this task at the Wikimedia Hackathon days ago. At the https://phabricator.wikimedia.org/tag/oojs-ui/ we're dealing with the situation that milestones have been put (I don't know if the exact reason was human or program activity) into wrong order. If you show past, hidden milestone columns visible, you'll see that our releases v0.16.2–0.17.3 are before v0.7.0 which is misleading when going through historic milestones.
Would be happy to see reordering possible as well…

We could also rip out all CSRF cycling code completely; Rails uses infinite-duration tokens with no cycling. However, the current code hasn't really caused any issues other than this for a number of years, I believe, and there are some practical-if-obscure attacks this can partially mitigate. An example is:

This will also fix the important use case where someone is running their browser inside a VM that they frequently suspend.

I believe that something in this vein is likely the fix:

Our behavior here is also legitimately wrong, and we can look at fixing this upsteam once we understand what's actually going wrong. I think if you dig in a bit you'll find a set of reproduction steps that are something like this:

Indeed there are the predicted error messages in the phd log. I will try to explore more and see what is wrong. It is probably related to the issue I reported (T12726), likely some of the fields are incorrectly created by arcanist in the first place.

Unless they have some seriously alien hands and an predilection to scroll in the middle of the screen

All that makes a lot of sense, I will try what you suggest and see if that was the source of the evil.

I suspect this will not reproduce for us given the reproduction instructions. The code is structured like this:

In T12733#224703, @epriestley wrote:

As such, I think it's reasonable to expect Differential to serve a more shallow role on small devices, more akin to "keeping abreast of changes" than "performing detailed review", and reasonable to not try to support every review feature on mobile, since these devices are secondary/support devices until everyone gets really excited about coding on the go using their thumbs, a virtual keyboard, and a tiny screen.

Not sure if this is the correct ticket for it, but I got here via D13020.

I have found that I can rearrange all the columns in some projects but cannot do the same in another one. Here's a screenshot. Now, I am not sure if it is a bug or just a random error.

For example, here is a project with more than 5 columns:

Please read and follow Contributing Bug Reports if you feel you've found a bug in Phabricator.

The rearrange dialogue box only shows a maximum of 5 columns although the project has more columns. This limits the ability of rearranging any column present beyond column number 5.

I meet the same problem. I create a git repo. for observing another remote git repo. Then I add the second user, the commit of the second user can't link correctly. How can I reparse an observing repo. Reparsing via "./bin/repository reparse --importing --all <REPONAME>" didn't do anything.

I think I shipped this.

A vaguely related issue is that the "Paths" list is not sorted on the "View" UI:

screenshot on ambien

Zzz

@bizrad6

I've been busy with important emoji research.

Hows Nuance coming?

sorry maybe I am supposed to use these now 😱 😱 😱 😱

We un-install it on admin.phacility.com. :) :) :) :)

Hmm, we shouldn't allow Dashboards to be un-installed.

(The "Dashboard" item may also be affected.)

Ah this probably explains what I have observed on our installation too.

I currently expect to revert this change and decline to implement the feature because it makes using Differential on a phone more difficult for left-handed users (scrolling and leaving comments on a line range become conflated). See T12733#224703 for detailed discussion. If you'd like to champion this feature, let us know in the next 7 seconds.

I'd be fine removing the range select on mobile.

I understand why the behavior has changed, and I'm not particularly opposed to keeping it as-is. I can easily reach over the line number - it's just that it initially appeared as a regression so I had to note it here.

This is an intentional change to address T1026 (allowing inline ranges to be added via touchscreen devices). Previously, it wasn't possible to comment on a range of lines on, e.g., an iPhone/iPad.

Hi Epriestley,

On mobile I very quickly get an inline comment box when scrolling which then takes focus so scrolling is aborted.

Please use Conpherence or Ponder if you have questions about Phabricator administration and options.

Arcanist hides part of the stderr to prevent console spam. But what problem does this fix exactly? How is it a problem that 5GB of output are printed to stderr? The way I see it, if the tool called by arc prints a lot of info to stderr, it should be assumed it is printed for a good reason, be it 1KB or 5PB.

Ahh, makes sense now :)

Synthetic comments (made by lint) are currently shown in the sidebar annotation with a pencil ( ) icon.

I don't think that's a very desirable behavior.

The same as what you do with any tool which produces 5GB of output: wonder what happened, then try again and redirect the output to a file and deal with it. Currently the user has to run manually the steps printed when using --trace, and then they will get to that 5GB output anyway.

How can I reproduce the issue you're encountering?

I have upgraded the version still having the same issue. Current version is given below.

The problem is a outdated version of phabricator/externals/mimemailparser/MimeMailParser.class.php.

What behavior would you expect arc to have if git commit ... produces 5GB of output (hypothetically, from a hook which prints 2.5GB of header and footer context and puts the important part in the middle)?