Page MenuHomePhabricator
Create Task
Maniphest T12745

Conpherence menu item is available for creation even if Conpherence is not installed
Closed, ResolvedPublic
Actions

Description

To reproduce:

  • Uninstall Conpherence.
  • Use "Edit Favorites" or "Edit Menu" on Home to navigate to a personal or global menu editing screen.

Expected:

  • There is no option to create a new "Conpherence" item.
  • Broadly, uninstalled applications don't offer items.

Actual:

  • An option to add a new "Conpherence" item is present.

Note that Conpherence is not installed (no icon in main header menu) but is available in the menu item selection:

Screen Shot 2017-05-23 at 10.01.24 AM.png (1×1 px, 150 KB)

Revisions and Commits

rP Phabricator
D20337rP6648942bc885 Don't allow "Conpherence" menu items to be added to editable menus if…

Related Objects

Event Timeline

epriestley created this task.May 23 2017, 5:01 PM
chad claimed this task.May 23 2017, 5:13 PM
epriestley added a comment.May 23 2017, 5:50 PM

(The "Dashboard" item may also be affected.)

chad added a comment.May 23 2017, 5:52 PM

Hmm, we shouldn't allow Dashboards to be un-installed.

epriestley added a comment.May 23 2017, 6:03 PM

We un-install it on admin.phacility.com. :) :) :) :)

epriestley added a comment.May 23 2017, 6:05 PM

sorry maybe I am supposed to use these now 😱 😱 😱 😱

chad added a comment.May 23 2017, 6:10 PM

Hows Nuance coming?

epriestley added a comment.May 23 2017, 6:11 PM

I've been busy with important emoji research.

chad moved this task from Backlog to Nits on the Customer Impact board.May 23 2017, 9:17 PM
epriestley mentioned this in T13083: Plans: Portals and Facts.Feb 15 2018, 8:52 PM
Herald added a subscriber: eadler. · View Herald TranscriptFeb 15 2018, 8:52 PM
• GoogleLegacy added a subscriber: • GoogleLegacy.Sep 10 2018, 8:30 AM
epriestley mentioned this in T13272: Remove the hard-coded homepage, and other Dashboards improvements.Mar 27 2019, 2:16 PM
epriestley added a revision: D20337: Don't allow "Conpherence" menu items to be added to editable menus if Conpherence is not installed.Mar 27 2019, 6:27 PM
epriestley reassigned this task from chad to epramono.Mar 27 2019, 6:28 PM
epriestley claimed this task.
epriestley added a subscriber: chad.
epriestley added a subscriber: epramono.

(Sorry, typo'd my own name into another @ep....)

epriestley closed this task as Resolved by committing rP6648942bc885: Don't allow "Conpherence" menu items to be added to editable menus if….Mar 27 2019, 11:01 PM
epriestley added a commit: rP6648942bc885: Don't allow "Conpherence" menu items to be added to editable menus if….
Phabricator · Built by Phacility