Page MenuHomePhabricator
Feed All Stories

May 22 2017

aleb created T12742: `arc land` shows only part of the error that causes the final squash to fail.
May 22 2017, 2:30 PM · Bug Report
cspeckmim added a comment to T12726: Errors when trying to create a diff with arcanist.

What if you try recreating the output generated by the hg commands shown from the --trace -- does the output look off in any way?

May 22 2017, 2:28 PM · Mercurial, Differential, Arcanist, Bug Report
franjesus added a comment to T12726: Errors when trying to create a diff with arcanist.

Did that, you can see the result at P2054. At least to me, nothing looks fishy...

May 22 2017, 2:03 PM · Mercurial, Differential, Arcanist, Bug Report
franjesus created P2054 arc diff --trace.
May 22 2017, 2:02 PM
• Basheer added a comment to T12741: Phabricator IP address or Mac Address level Blocking Issue..

Okay, Thank you.

May 22 2017, 1:17 PM · Bug Report
epriestley added a comment to T12741: Phabricator IP address or Mac Address level Blocking Issue..

(You are also almost 8 months out of date; we only support recent versions of Phabricator.)

May 22 2017, 1:13 PM · Bug Report
epriestley added a comment to T12741: Phabricator IP address or Mac Address level Blocking Issue..

Click on logout then tried to login using google authentication and getting the error.

May 22 2017, 1:12 PM · Bug Report
• Basheer added a comment to T12741: Phabricator IP address or Mac Address level Blocking Issue..

Sorry for not providing the version information. I have included the version details below.

May 22 2017, 1:08 PM · Bug Report
Bezalel added a comment to T12134: Develop a Nuance-based Phabricator reporting/support flow.

You could pay reviewers with Mana ;)

May 22 2017, 12:37 PM · Abuse
epriestley closed T12741: Phabricator IP address or Mac Address level Blocking Issue. as Invalid.

Please follow all the instructions when submitting a bug report. In particular, we need:

May 22 2017, 12:28 PM · Bug Report
• Basheer added a comment to T12741: Phabricator IP address or Mac Address level Blocking Issue..

I am unable to login to my Phabricator after clicking logout. Getting the below error.

May 22 2017, 12:28 PM · Bug Report
• Basheer created T12741: Phabricator IP address or Mac Address level Blocking Issue..
May 22 2017, 12:26 PM · Bug Report
epriestley added a comment to T12739: Nuance: As an External Bridge, to GitHub and other similar systems.

Why is this Nuance and not Doorkeeper?

May 22 2017, 10:20 AM · Nuance
johnny-bit awarded T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support a Love token.
May 22 2017, 9:21 AM · Nuance
eliaspro added a comment to T11102: Supporting moving projects.

For those looking for ways to manually move projects until this is implemented: T10350: Scripts to migrate old "points" fields and move projects beneath other projects

May 22 2017, 9:19 AM · Projects, Restricted Project, Feature Request
eliaspro awarded T11102: Supporting moving projects a Love token.
May 22 2017, 9:17 AM · Projects, Restricted Project, Feature Request
johnny-bit added a comment to T12739: Nuance: As an External Bridge, to GitHub and other similar systems.
In T12739#224607, @chad wrote:

GH Issues flow into Nuance and a human can decide whether to open it up as a Maniphest Task, similar to email. The end user can fully communicate an issue back to Phabricator without ever leaving their preferred source (email, Github, Twitter). Developers can stay in Phabricator and manage priorities, projects, workboards.

May 22 2017, 9:17 AM · Nuance
chad added a comment to T12739: Nuance: As an External Bridge, to GitHub and other similar systems.

GH Issues flow into Nuance and a human can decide whether to open it up as a Maniphest Task, similar to email. The end user can fully communicate an issue back to Phabricator without ever leaving their preferred source (email, Github, Twitter). Developers can stay in Phabricator and manage priorities, projects, workboards.

May 22 2017, 4:27 AM · Nuance
avivey added a comment to T12739: Nuance: As an External Bridge, to GitHub and other similar systems.

Why is this Nuance and not Doorkeeper?

May 22 2017, 4:12 AM · Nuance
20after4 added a comment to T8646: Provide more context for search results, particularly wiki documents.

FWIW I partially implemented this in Wikimedia's fork, and I did so in a reusable way. I'd like to eventually upstream it but I'm not sure that my approach is desired upstream. I'll give it another shot though.

May 22 2017, 3:51 AM · Design, Search, Restricted Project
20after4 abandoned D13581: Support custom fields in diffusion commit property views..

not upstream-able.

May 22 2017, 3:46 AM
20after4 awarded T12733: (2017 Week 20) Inline Comments Errata / Feedback a Like token.
May 22 2017, 2:25 AM · Inline Comments, Installing & Upgrading, Differential
chad added a revision to T12625: Update Phriction for Modular Transactions: Unknown Object (Differential Revision).
May 22 2017, 12:54 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad added a revision to T12625: Update Phriction for Modular Transactions: Unknown Object (Differential Revision).
May 22 2017, 12:51 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request

May 21 2017

chad renamed T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support from Nuance: As a Helpdesk, for Phabricator/Phacility suppot to Nuance: As a Helpdesk, for Phabricator/Phacility support.
May 21 2017, 8:33 PM · Nuance
Luke081515.2 added a comment to T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support.

There's a typo in the headline, but I can't it :(

May 21 2017, 8:25 PM · Nuance
epriestley renamed T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support from Nuance: As a Helpdesk to Nuance: As a Helpdesk, for Phabricator/Phacility suppot.
May 21 2017, 5:03 PM · Nuance
epriestley updated the task description for T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support.
May 21 2017, 5:03 PM · Nuance
epriestley renamed T12739: Nuance: As an External Bridge, to GitHub and other similar systems from Nuance: As an External Bridge to Nuance: As an External Bridge, to GitHub and other similar systems.
May 21 2017, 4:13 PM · Nuance
epriestley triaged T12739: Nuance: As an External Bridge, to GitHub and other similar systems as Wishlist priority.
May 21 2017, 4:12 PM · Nuance
epriestley added a parent task for T10538: Bridge GitHub to Phabricator: T12739: Nuance: As an External Bridge, to GitHub and other similar systems.
May 21 2017, 3:43 PM · Nuance, GitHub
epriestley added a subtask for T12739: Nuance: As an External Bridge, to GitHub and other similar systems: T10538: Bridge GitHub to Phabricator.
May 21 2017, 3:42 PM · Nuance
epriestley updated the task description for T10005: Implement an ApplicationEditor-based Bulk Editor.
May 21 2017, 2:09 PM · ApplicationEditor
epriestley closed T5815: Make it easier to work through a queue of stuff as Resolved.

I'm going to close this; there are two possible followups -- each of which is better focused on a more specific set of problems -- but I'm not merging it into either one since I think there's a lot of general ambiguity about problems and use cases here. If you're interested in this, feel free to follow either or both.

May 21 2017, 2:00 PM · Restricted Project, Maniphest, Differential, Audit
epriestley renamed T12740: Nuance: As a Bulk Editor, when edits require human decisions from Nuance: As a Bulk Editor to Nuance: As a Bulk Editor, when edits require human decisions.
May 21 2017, 1:47 PM · Nuance
epriestley removed a parent task for T8783: Unprototype Nuance (v1): T5815: Make it easier to work through a queue of stuff.
May 21 2017, 12:50 PM · Nuance, Restricted Project
epriestley removed a parent task for T9132: Build an ApplicationEditor abstraction: T5815: Make it easier to work through a queue of stuff.
May 21 2017, 12:50 PM · Restricted Project, ApplicationEditor, Transactions
epriestley edited subtasks for T5815: Make it easier to work through a queue of stuff, added: T12740: Nuance: As a Bulk Editor, when edits require human decisions; removed: T9132: Build an ApplicationEditor abstraction, T8783: Unprototype Nuance (v1).
May 21 2017, 12:50 PM · Restricted Project, Maniphest, Differential, Audit
epriestley added a parent task for T12740: Nuance: As a Bulk Editor, when edits require human decisions: T5815: Make it easier to work through a queue of stuff.
May 21 2017, 12:50 PM · Nuance
epriestley created T12740: Nuance: As a Bulk Editor, when edits require human decisions.
May 21 2017, 12:49 PM · Nuance
epriestley created T12739: Nuance: As an External Bridge, to GitHub and other similar systems.
May 21 2017, 12:49 PM · Nuance
epriestley created T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support.
May 21 2017, 12:49 PM · Nuance
epriestley moved T8783: Unprototype Nuance (v1) from v1 to Backlog on the Nuance board.
May 21 2017, 12:47 PM · Nuance, Restricted Project
epriestley closed T10537: Nuance Infrastructure, a subtask of T8783: Unprototype Nuance (v1), as Resolved.
May 21 2017, 12:46 PM · Nuance, Restricted Project
epriestley closed T10537: Nuance Infrastructure as Resolved.

This was basically just a work log for an earlier iteration on Nuance focused on bi-directional bridging with GitHub. We're pursuing Nuance again now, but not with the same focus, so I'm going to close this and reorganize things. Some similar task will likely fall out at the end, but with a better focus on where we're actually headed.

May 21 2017, 12:46 PM · Nuance (v1)
epriestley moved T10538: Bridge GitHub to Phabricator from v1 to Backlog on the Nuance board.
May 21 2017, 12:43 PM · Nuance, GitHub
epriestley moved T10363: Reorient Doorkeeper publishing around transactions instead of feed stories from v1 to Backlog on the Nuance board.
May 21 2017, 12:43 PM · Nuance, Restricted Project, Feed, Doorkeeper
epriestley updated the task description for T12733: (2017 Week 20) Inline Comments Errata / Feedback.
May 21 2017, 12:40 PM · Inline Comments, Installing & Upgrading, Differential
epriestley closed T12737: tangtangtang as Invalid.
May 21 2017, 11:14 AM
iq added a comment to T1894: Support commenting on Phriction documents.

Jira's Confluence provides inline comments; same model could be used by Phriction. But that's not as important. Should at least have support for end-of-doc (footer) style commenting.

May 21 2017, 10:06 AM · Restricted Project, Restricted Project, Phriction
johnny-bit awarded M1476: Inline Comment Browse bar a Love token.
May 21 2017, 9:44 AM
chad created M1476: Inline Comment Browse bar.
May 21 2017, 3:33 AM
chad added a revision to T12423: Bring MenuItem customization options to User Profiles: Unknown Object (Differential Revision).
May 21 2017, 12:07 AM · Dashboards, Restricted Project, Profile

May 20 2017

epriestley added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.
  • The persistent header should now select more intuitive changesets.
  • The scrollbar annotation is now disabled for trackpad "aesthetic" scrollbars (like the 0-width scrollbar on OSX if you don't have a mouse connected to your laptop). If we retain the element, I plan to enable it eventually, it just requires us to move content around and generally make a larger change.
  • The scrollbar annotation is now disabled unless phabricator.show-prototypes is enabled.
  • The scrollbar annotation should generally work better and be more useful now.
  • I've deployed these changes to this host.
May 20 2017, 3:18 PM · Inline Comments, Installing & Upgrading, Differential
storrgie added a comment to T7777: Description for "security.strict-transport-security" is incorrect.

For reference, even though this isn't right. I figured I'd put my notes here for someone else to find and help me out:

location / {
    client_max_body_size 32M;
    proxy_set_header        Host $host;
    proxy_set_header        X-Real-IP $remote_addr;
    proxy_set_header        X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header        X-Forwarded-Proto $scheme;
    proxy_set_header        X-Frame-Options DENY;
    proxy_set_header        X-XSS-Protection "1; mode=block";
    proxy_set_header        Referrer-Policy no-referrer-when-downgrade;
May 20 2017, 3:10 PM · Documentation
storrgie added a comment to T7777: Description for "security.strict-transport-security" is incorrect.

@jefferai how did you overwrite the headers? I'm encountering this exact same issue.

May 20 2017, 2:47 PM · Documentation
chad closed T12735: InvalidArgumentException when viewing a room you haven't joined from Safari as Resolved by committing Restricted Diffusion Commit.
May 20 2017, 1:51 PM · Bug Report
epriestley added a revision to T12733: (2017 Week 20) Inline Comments Errata / Feedback: Unknown Object (Differential Revision).
May 20 2017, 1:00 PM · Inline Comments, Installing & Upgrading, Differential
epriestley added a revision to T12733: (2017 Week 20) Inline Comments Errata / Feedback: Unknown Object (Differential Revision).
May 20 2017, 12:51 PM · Inline Comments, Installing & Upgrading, Differential
epriestley added a revision to T12733: (2017 Week 20) Inline Comments Errata / Feedback: Unknown Object (Differential Revision).
May 20 2017, 12:40 PM · Inline Comments, Installing & Upgrading, Differential
epriestley added a revision to T12733: (2017 Week 20) Inline Comments Errata / Feedback: Unknown Object (Differential Revision).
May 20 2017, 12:35 PM · Inline Comments, Installing & Upgrading, Differential
epriestley added a revision to T12733: (2017 Week 20) Inline Comments Errata / Feedback: Unknown Object (Differential Revision).
May 20 2017, 12:28 PM · Inline Comments, Installing & Upgrading, Differential
epriestley added a revision to T12733: (2017 Week 20) Inline Comments Errata / Feedback: Unknown Object (Differential Revision).
May 20 2017, 12:11 PM · Inline Comments, Installing & Upgrading, Differential
epriestley added a revision to T12733: (2017 Week 20) Inline Comments Errata / Feedback: Unknown Object (Differential Revision).
May 20 2017, 11:30 AM · Inline Comments, Installing & Upgrading, Differential
epriestley added a revision to T12733: (2017 Week 20) Inline Comments Errata / Feedback: Unknown Object (Differential Revision).
May 20 2017, 11:21 AM · Inline Comments, Installing & Upgrading, Differential
epriestley added a revision to T12733: (2017 Week 20) Inline Comments Errata / Feedback: Unknown Object (Differential Revision).
May 20 2017, 11:15 AM · Inline Comments, Installing & Upgrading, Differential
epriestley merged T12736: Missing function function_exists check leads to uncaught exception into T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd`.
May 20 2017, 11:00 AM · Setup, Bug Report
epriestley merged task T12736: Missing function function_exists check leads to uncaught exception into T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd`.
May 20 2017, 11:00 AM · Bug Report
mydeveloperday updated the task description for T12736: Missing function function_exists check leads to uncaught exception.
May 20 2017, 8:50 AM · Bug Report
mydeveloperday updated the task description for T12736: Missing function function_exists check leads to uncaught exception.
May 20 2017, 8:49 AM · Bug Report
mydeveloperday created T12736: Missing function function_exists check leads to uncaught exception.
May 20 2017, 8:48 AM · Bug Report
chad added a revision to T12735: InvalidArgumentException when viewing a room you haven't joined from Safari: Unknown Object (Differential Revision).
May 20 2017, 4:42 AM · Bug Report
chad closed T12728: Newly created Phriction document doesn't appear in hierarchy as Resolved.
May 20 2017, 2:50 AM · Phriction, Bug Report
jcarrillo7 added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.

This is pretty awesome improvement! Small feedback, the new scrollbar area is a bit hard to use on Safari with Apple's disappearing/reappearing scrollbars. They end up overlapping and it can make the Phabricator scrollbar area harder to use/click on etc. Would be nice if the scrollbar area shifted left while scrolling or if it were on the left side of the screen or some other magical solution.

May 20 2017, 1:01 AM · Inline Comments, Installing & Upgrading, Differential
epriestley added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.

I'll tweak the logic, I agree that, e.g., "index.js" should be displayed in your first screenshot (and probably whatever's above it if you scrolled up just a little bit more).

May 20 2017, 12:42 AM · Inline Comments, Installing & Upgrading, Differential
chad added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

That'll be 6 beers pls.

May 20 2017, 12:37 AM · Restricted Project, Workboards
dgrote added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.
  • persistent header element is a great idea
  • scrollbar annotations are very helpful
May 20 2017, 12:35 AM · Inline Comments, Installing & Upgrading, Differential

May 19 2017

chad added a comment to T12735: InvalidArgumentException when viewing a room you haven't joined from Safari.

It's inconsistent because you need to be watching a room and someone has to post a message (in order to trigger a sound). Thanks for the report!

May 19 2017, 11:46 PM · Bug Report
jboning added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

Super! We'll report results when we've got it deployed.

May 19 2017, 11:45 PM · Restricted Project, Workboards
chaseh created T12735: InvalidArgumentException when viewing a room you haven't joined from Safari.
May 19 2017, 11:28 PM · Bug Report
epriestley added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

I shored up D17959 a bit, landed it, and deployed it to secure.phabricator.com, then spent some time fiddling with workboards here, but couldn't find any issues with it. We have ~6,500 "wishlist" tasks on this server and it distributed all tasks near 0 (approximately 2,700 tasks) evenly across the range [4096, 4096] fast enough that I didn't notice it. I'm currently inclined not to write a dedicated migration since it seems plausible that all existing installs will survive the first dispersal without much fanfare.

May 19 2017, 11:05 PM · Restricted Project, Workboards
epriestley edited the content of Changelog.
May 19 2017, 10:49 PM
epriestley created 2017 Week 20 (Late May).
May 19 2017, 10:17 PM
ftdysa asked Q621: What is the correct way to land stacked diffs?.
May 19 2017, 10:02 PM
epriestley closed T12732: 2017 Week 20 Transactions Errata as Resolved.

If anyone wants to fix anything else here feel free, but I think we squeezed most of the soup from this stone once D17972 lands.

May 19 2017, 9:40 PM · Transactions
avivey awarded T12734: Detect declared-but-unused variables in PHPAST linters a Doubloon token.
May 19 2017, 9:37 PM · XHPAST, Lint
chad added a revision to T12732: 2017 Week 20 Transactions Errata: Unknown Object (Differential Revision).
May 19 2017, 9:20 PM · Transactions
epriestley added a comment to T12732: 2017 Week 20 Transactions Errata.

Oh, yeah, transaction is great. Property feels a little clutter-y since we have the transaction anyway.

May 19 2017, 9:19 PM · Transactions
epriestley added a comment to T12732: 2017 Week 20 Transactions Errata.

I'm fine with keeping it, just thought it might be a legacy holdover from a bygone era.

May 19 2017, 9:19 PM · Transactions
chad added a comment to T12732: 2017 Week 20 Transactions Errata.

oh property. yeah, thought you meant transaction.

May 19 2017, 9:18 PM · Transactions
chad added a comment to T12732: 2017 Week 20 Transactions Errata.

Drop "Created" property for instances.

May 19 2017, 9:17 PM · Transactions
chad added a revision to T12732: 2017 Week 20 Transactions Errata: Unknown Object (Differential Revision).
May 19 2017, 9:14 PM · Transactions
epriestley added a revision to T12732: 2017 Week 20 Transactions Errata: Unknown Object (Differential Revision).
May 19 2017, 9:13 PM · Transactions
epriestley added a revision to T12732: 2017 Week 20 Transactions Errata: Unknown Object (Differential Revision).
May 19 2017, 9:10 PM · Transactions
epriestley created T12734: Detect declared-but-unused variables in PHPAST linters.
May 19 2017, 9:03 PM · XHPAST, Lint
chad added a revision to T12732: 2017 Week 20 Transactions Errata: Unknown Object (Differential Revision).
May 19 2017, 9:02 PM · Transactions
epriestley added a revision to T12732: 2017 Week 20 Transactions Errata: Unknown Object (Differential Revision).
May 19 2017, 8:54 PM · Transactions
epriestley added a revision to T12732: 2017 Week 20 Transactions Errata: Restricted Differential Revision.
May 19 2017, 8:49 PM · Transactions
epriestley added a comment to T12732: 2017 Week 20 Transactions Errata.

oh thx :)

May 19 2017, 8:45 PM · Transactions
chad added a revision to T12732: 2017 Week 20 Transactions Errata: Unknown Object (Differential Revision).
May 19 2017, 8:45 PM · Transactions