Page MenuHomePhabricator
Feed All Stories

Aug 8 2016

dpkp added a comment to T11439: Retrieve Diff PHID via phid.lookup.

The way I've configured it in the past is to have the build trigger an HTTP call to a parameterized jenkins job (passing the various vars required to update w/ harbormaster.sendmessage). In the past we've needed each team to have / manage a different jenkins job, and so we created a new build plan for each w/ a different HTTP endpoint to call.

Aug 8 2016, 7:00 PM · Feature Request
avivey added a comment to T11439: Retrieve Diff PHID via phid.lookup.

Why does each repository require its own herald rules/hm builds, if those are not customized by the team?

Aug 8 2016, 6:50 PM · Feature Request
dpkp added a comment to T11439: Retrieve Diff PHID via phid.lookup.

Thinking a bit more about the herald / harbormaster approach, I think what might help that workflow, for me at least, is conduit API access to create herald rules and harbormaster build plans.

Aug 8 2016, 6:36 PM · Feature Request
dpkp added a comment to T11439: Retrieve Diff PHID via phid.lookup.

Can we fix this problem (or set of problems) instead? The workflow you describe is not something we're interested in spending resources supporting since it is much more limited than the Herald + Harbormaster flow in the general case.

Aug 8 2016, 5:54 PM · Feature Request
chad added a comment to T8552: Increase user control over document hierarchy in Phriction.

Ok, I'll mock it out.

Aug 8 2016, 5:37 PM · Phriction, Restricted Project
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

When you click the pencil icon next to the "Hierarchy" item, you get to a page like this one:

Aug 8 2016, 5:33 PM · Phriction, Restricted Project
chad added a comment to T8552: Increase user control over document hierarchy in Phriction.

Where is that checkbox?

Aug 8 2016, 5:30 PM · Phriction, Restricted Project
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

(I'm hoping there's no real use case for "show some other arbitrary page's navigation", although who knows.)

Aug 8 2016, 5:30 PM · Phriction, Restricted Project
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

I'm hoping to get away with two options, e.g. a checkbox like this:

Aug 8 2016, 5:29 PM · Phriction, Restricted Project
chad updated image descriptions of M1466: Phriction v3.
Aug 8 2016, 5:29 PM
chad added a comment to T8552: Increase user control over document hierarchy in Phriction.

Can I select which page I pull my hierarchy from? I think that works for cases where you want the navigation to be persistent among the children, to just always pull from parent hierarchy.

Aug 8 2016, 5:23 PM · Phriction, Restricted Project
epriestley added a comment to T11439: Retrieve Diff PHID via phid.lookup.

I found that the overhead of managing herald + harbormaster was much higher than our previous setup and was causing friction getting folks to adopt phabricator for new projects

Aug 8 2016, 4:49 PM · Feature Request
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

Yeah -- the specific change I'd expect is basically that this:

Aug 8 2016, 4:43 PM · Phriction, Restricted Project
chad added a comment to T8552: Increase user control over document hierarchy in Phriction.

So just to understand your point, instead of having pre-selectable layouts, we ship just 1 level by default and anything else is custom?

Aug 8 2016, 4:42 PM · Phriction, Restricted Project
chad added a comment to T8552: Increase user control over document hierarchy in Phriction.

My intent was to basically port over a customizeable nav list like we already use in AphrontNav everywhere, label, item, spacer, and have that basically editable and re-usable. I want to take a pass at something similar for /home/ so we're looking at all the use cases before building anything.

Aug 8 2016, 4:38 PM · Phriction, Restricted Project
epriestley closed T7783: phriction diffs don't default to remarkup as Wontfix.

These use the prose algorithm now, and I don't plan to try to implement syntax highlighting for prose diffs.

Aug 8 2016, 4:36 PM · Remarkup, Phriction
epriestley closed T7783: phriction diffs don't default to remarkup, a subtask of T9379: Build Phriction v3, as Wontfix.
Aug 8 2016, 4:36 PM · Phriction
dpkp added a comment to T11439: Retrieve Diff PHID via phid.lookup.

Apologies, I should have added more detail to the original task! I am actually trying to use just the staging push to trigger remote tests, and not require each project to setup and maintain herald rules + harbormaster build plans that call out to HTTP endpoints w/ parameters.

Aug 8 2016, 4:35 PM · Feature Request
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

I think both are about 95% equivalent, my version ("a Hierarchy is a single menu item") is just easier for me to do from an engineering viewpoint and the other version I'd have to think about for a while before I could even guess how much work it is. I think the simpler-to-implement version is a bit more flexible/powerful too, although maybe not quite as intuitive at first glance.

Aug 8 2016, 4:34 PM · Phriction, Restricted Project
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

The shortest path on the nav is probably something slightly more directly porting Profile Menu editing:

Aug 8 2016, 4:31 PM · Phriction, Restricted Project
epriestley moved T9379: Build Phriction v3 from Preflight to The Queue on the Prioritized board.
Aug 8 2016, 4:22 PM · Phriction
epriestley added a project to T9379: Build Phriction v3: Prioritized.
Aug 8 2016, 4:21 PM · Phriction
avivey added a subtask for T9287: Working with many repositories: T7773: Allow code reviews across multiple repos.
Aug 8 2016, 4:06 PM · Restricted Project, Restricted Project, Diffusion
avivey added a parent task for T7773: Allow code reviews across multiple repos: T9287: Working with many repositories.
Aug 8 2016, 4:06 PM · Restricted Project, Differential
epriestley added a comment to T7773: Allow code reviews across multiple repos.

We will almost certainly never support diffs coming from multiple different repository sources. They can't be built, can't be updated, can't be patched, can't be meaningfully interdiffed, local commits are meaningless, can't be atomically landed, and they basically don't make sense in general.

Aug 8 2016, 4:04 PM · Restricted Project, Differential
epriestley added a comment to T11439: Retrieve Diff PHID via phid.lookup.

Can you walk me through your workflow in more detail? The expectation is:

Aug 8 2016, 3:56 PM · Feature Request
epriestley edited projects for T11440: Drafts for unsaved objects, added: EditEngine; removed Maniphest.
Aug 8 2016, 3:54 PM · EditEngine, Feature Request
epriestley renamed T11440: Drafts for unsaved objects from draft for new tasks to Drafts for unsaved objects.
Aug 8 2016, 3:54 PM · EditEngine, Feature Request
epriestley triaged T11440: Drafts for unsaved objects as Wishlist priority.

This is nice in theory, but I suspect it may be very complex to implement in practice.

Aug 8 2016, 3:53 PM · EditEngine, Feature Request
epriestley added a comment to T11440: Drafts for unsaved objects.

(I've destroyed the token compromised earlier in this thread.)

Aug 8 2016, 3:34 PM · EditEngine, Feature Request
yelirekim added a comment to T11440: Drafts for unsaved objects.

@Ajaxs86 you appear to have posted your API token here and should probably revoke it.

Aug 8 2016, 3:25 PM · EditEngine, Feature Request
• bjorngi added a comment to T7773: Allow code reviews across multiple repos.

How would this work in CI? We use jenkins to test differentials. Herald starts a jenkins-job when a differential connected to a spesific repository is created or edited. Heralds sends the repository URL and commit id of current HEAD in differential to jenkins, and this then runs tests on HEAD of differential using

arc patch --nobranch --no-ansi --diff $DIFF_ID --nocommit
Aug 8 2016, 1:17 PM · Restricted Project, Differential
• Ajaxs86 added a comment to T11440: Drafts for unsaved objects.
Aug 8 2016, 8:13 AM · EditEngine, Feature Request
chad added a comment to M1466: Phriction v3.

Added in commenting.

Aug 8 2016, 4:21 AM
chad updated images of M1466: Phriction v3.
Aug 8 2016, 4:20 AM
chad closed T11442: test as Spite.

nyancat

Aug 8 2016, 4:17 AM · Feature Request
• Jung renamed T11442: test from asdf to test.
Aug 8 2016, 4:03 AM · Feature Request
• Jung created T11442: test.
Aug 8 2016, 4:03 AM · Feature Request
chad placed T9586: Modernize Harbormaster build step UI elements up for grabs.
Aug 8 2016, 3:14 AM · Restricted Project, Harbormaster
chad placed T5355: Have tasks "bubbles" always display the edit icon in the UI up for grabs.
Aug 8 2016, 3:14 AM · Maniphest
chad placed T6906: Archived / closed objects don't have "closed" look in typeahead results, in global search typeahead only up for grabs.
Aug 8 2016, 3:14 AM · Typeahead, Contributor Onboarding, Design
chad placed T4011: Improve Projects list view / search result layout up for grabs.
Aug 8 2016, 3:14 AM · Design, Projects (v3)
chad closed T11441: Add IMAP authentication support as Invalid.

Closing as invalid since we have no idea what this request is even for. IMAP is a mail protocol, and I'm not sure what you're asking us to do with it.

Aug 8 2016, 2:49 AM · Auth, Feature Request
mbm closed Q460: What are the plans for making apps such as Legalpad and Phortune compatible with different countries? as resolved.
Aug 8 2016, 2:22 AM
chad added Q460: What are the plans for making apps such as Legalpad and Phortune compatible with different countries? (Answer 429).
Aug 8 2016, 2:21 AM
mbm updated Q460: What are the plans for making apps such as Legalpad and Phortune compatible with different countries? from to What are the plans for making apps such as Legalpad and Phortune compatible with different countries?.
Aug 8 2016, 2:16 AM
chad added Q459: Is there a eclipse plugin about Phabricator? (Answer 428).
Aug 8 2016, 1:48 AM
narutolee updated Q459: Is there a eclipse plugin about Phabricator? from to Is there a eclipse plugin about Phabricator?.
Aug 8 2016, 1:24 AM

Aug 7 2016

chad added a comment to T11441: Add IMAP authentication support.

See Contributing Feature Requests and Describing Root Problems for what information we require in a feature request.

Aug 7 2016, 11:46 PM · Auth, Feature Request
imsoftware created T11441: Add IMAP authentication support.
Aug 7 2016, 11:18 PM · Auth, Feature Request
chad added a comment to T11440: Drafts for unsaved objects.

https://chrome.google.com/webstore/detail/lazarus-form-recovery/loljledaigphbcpfhfmgopdkppkifgno

Aug 7 2016, 11:12 PM · EditEngine, Feature Request
yelirekim awarded T11440: Drafts for unsaved objects a Piece of Eight token.
Aug 7 2016, 10:59 PM · EditEngine, Feature Request
• sshannin created T11440: Drafts for unsaved objects.
Aug 7 2016, 8:51 PM · EditEngine, Feature Request
eadler added a project to T3554: Implement a `bin/worker kill <criteria>` for batch-flushing tasks from the queue: Restricted Project.
Aug 7 2016, 8:13 PM · Restricted Project, Daemons
eadler added a project to T6609: Support math (LaTeX) equation in Remarkup: Restricted Project.
Aug 7 2016, 8:12 PM · Restricted Project, Remarkup
eadler added a project to T6526: Implement "Badges" or "Medals", for annotating special users: Restricted Project.
Aug 7 2016, 8:11 PM · Restricted Project, Badges (v0), People
eadler added a project to T6008: Editing files and contributing changes via web: Restricted Project.
Aug 7 2016, 8:10 PM · Restricted Project, Wikimedia, Diffusion, Differential
eadler added a project to T8425: Semantics around historical commits in an Owners package are awkward: Restricted Project.
Aug 7 2016, 8:09 PM · Restricted Project, Owners
eadler added a project to T5657: Ability to rename flags: Restricted Project.
Aug 7 2016, 8:06 PM · Contributor Onboarding, Restricted Project, Flags
eadler added a comment to T5514: Allow dashboard panels to have an auto-refresh time.

Maybe not exactly related but we'd love this feature for harbormaster build status page.

Aug 7 2016, 8:06 PM · Restricted Project, Dashboards
eadler added a project to T5514: Allow dashboard panels to have an auto-refresh time: Restricted Project.
Aug 7 2016, 8:05 PM · Restricted Project, Dashboards
eadler added a project to T3917: Avoid or easily handle 'duplicate' audits: Restricted Project.
Aug 7 2016, 8:02 PM · Restricted Project, Audit
eadler added a project to T4971: Add support for "Added filenames" and "Removed filenames" in Herald: Restricted Project.
Aug 7 2016, 8:02 PM · Restricted Project, Herald
eadler added a comment to T7676: Packages that are configured to auto-audit often generate audits that are un-closable.

FWIW this exact set of reproduction steps no longer works. However, an Owners package set to generate an audit, but without any members, will be unclosable as well.

Aug 7 2016, 8:02 PM · Owners, Audit
eadler added a project to T8348: `arc download` doesn't support chunked downloads: Restricted Project.
Aug 7 2016, 8:00 PM · Restricted Project, Files, Arcanist
eadler added a project to T11126: Allow embedding XKCD panes in Remarkup: Restricted Project.
Aug 7 2016, 7:59 PM · Restricted Project, User Delight, Remarkup, Feature Request
eadler added a project to T11401: Add ability to quote, edit, view raw, view history, and remove inline comments: Restricted Project.
Aug 7 2016, 7:59 PM · Inline Comments, Restricted Project, Differential, Feature Request
eadler closed T11244: Identify additional tokens to add to Phabricator as Resolved.
Aug 7 2016, 7:56 PM · Celerity, Tokens
eadler closed T11244: Identify additional tokens to add to Phabricator, a subtask of T11217: Make Tokens modular / real application, as Resolved.
Aug 7 2016, 7:56 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad updated the task description for T11244: Identify additional tokens to add to Phabricator.
Aug 7 2016, 7:31 PM · Celerity, Tokens
eadler added a project to T11351: Move Pholio to EditEngine and modern APIs: Restricted Project.
Aug 7 2016, 7:23 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
eadler added a project to T11414: Clicking on mock inline comment preview doesn't display the correct image: Restricted Project.
Aug 7 2016, 7:15 PM · Restricted Project, Pholio, Bug Report
eadler edited projects for T11423: arcanist segmentation faults, added: Bug Report (Needs Information); removed Bug Report.
Aug 7 2016, 7:04 PM · Bug Report (Needs Information)
epriestley reopened T11439: Retrieve Diff PHID via phid.lookup as "Open".
Aug 7 2016, 7:02 PM · Feature Request
epriestley closed T11437: Provide a usable UI for configuring header logos, a subtask of T11096: Redesign main header / quick create / search, as Resolved.
Aug 7 2016, 7:00 PM · Design
epriestley closed T11437: Provide a usable UI for configuring header logos as Resolved by committing Restricted Diffusion Commit.
Aug 7 2016, 7:00 PM · Config
epriestley added a revision to T11437: Provide a usable UI for configuring header logos: Unknown Object (Differential Revision).
Aug 7 2016, 6:52 PM · Config
dpkp added a revision to T11439: Retrieve Diff PHID via phid.lookup: Unknown Object (Differential Revision).
Aug 7 2016, 5:59 PM · Feature Request
dpkp added a comment to T11439: Retrieve Diff PHID via phid.lookup.

I dont see PHID in the results of differential.querydiffs ?

Aug 7 2016, 5:56 PM · Feature Request
epriestley closed T11439: Retrieve Diff PHID via phid.lookup as Resolved.

Try differential.querydiffs.

Aug 7 2016, 12:54 PM · Feature Request
dpkp created T11439: Retrieve Diff PHID via phid.lookup.
Aug 7 2016, 1:38 AM · Feature Request

Aug 6 2016

epriestley added a comment to T4245: Make repository URIs slightly prettier.

How would we distinguish between source/android/browse/carafe/ being "browse branch carafe of repository android" vs "browse the home page of repository carafe located at path android/browse/" in such a scheme?

Aug 6 2016, 9:56 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley renamed T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL from MySQL database backup produces warning on Ubuntu 16.04.1 to MySQL "-p<password>" flag produces a warning in recent versions of MySQL.
Aug 6 2016, 9:46 PM · Bug Report
epriestley edited the content of Changelog.
Aug 6 2016, 9:43 PM
epriestley created 2016 Week 32 (Early August).
Aug 6 2016, 9:43 PM
epriestley closed T7939: Support Herald rules for Calendar events as Resolved by committing Restricted Diffusion Commit.
Aug 6 2016, 9:37 PM · Herald, Calendar
epriestley closed T7939: Support Herald rules for Calendar events, a subtask of T7926: Modernize Calendar Infrastructure, as Resolved.
Aug 6 2016, 9:37 PM · Calendar
epriestley added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

This document may also be helpful in scripting Phabricator commands:

Aug 6 2016, 9:06 PM · Bug Report
epriestley added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

The Aug 19 2015 reply from James Day in https://bugs.mysql.com/bug.php?id=66546 gives me some hope that MySQL may adjust behavior here. Although that comment is now almost a year old, it responds to a comment from about two and a half years prior, so this may actually be fairly new in MySQL timescales.

Aug 6 2016, 8:53 PM · Bug Report
epriestley triaged T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL as Wishlist priority.
Aug 6 2016, 8:48 PM · Bug Report
epriestley reopened T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL as "Open".

I think this is the corresponding MySQL bug:

Aug 6 2016, 8:48 PM · Bug Report
chad updated subscribers of T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

Oh, yeah that's probably a fair point. @epriestley ?

Aug 6 2016, 7:34 PM · Bug Report
reet- added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.
In T11433#189141, @chad wrote:

mysqldump is not a phabricator command.

Aug 6 2016, 7:30 PM · Bug Report
chad added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

mysqldump is not a phabricator command.

Aug 6 2016, 7:23 PM · Bug Report
reet- added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.
In T11433#189037, @chad wrote:

Can you point to me exactly where we state you should build a cron? https://secure.phabricator.com/book/phabricator/article/configuring_backups/

Aug 6 2016, 7:21 PM · Bug Report
eadler added a comment to M1458: Homepage 2016.

Ah, so clicking the button will add the page to the menu? I didn't realize that. A star is fine.

Aug 6 2016, 5:34 PM
chad added a comment to T11438: Separate paid user count by pricing plan subgroup in Phacility statistics.

My mental timeline for this was more like 'after private clusters'. Sorry, didn't mean to add thinking about this to your immediate plate. I'm pretty chill right now waiting for CORGI data to come in (2-3 months) and NUX.

Aug 6 2016, 5:32 PM · Phacility
epriestley added a comment to T11438: Separate paid user count by pricing plan subgroup in Phacility statistics.

We can limit the number of instances, but I think the big question we want to answer is how many free instnaces convert to paying instances over some long period of time.

Aug 6 2016, 5:28 PM · Phacility
chad added a comment to T4213: Provide custom themes, skinning, or custom CSS.

But if you can easily work around, great!

Aug 6 2016, 4:59 PM · Design
chad added a comment to T4213: Provide custom themes, skinning, or custom CSS.

It's a one time cost, and cheaper than a sprite, is it not?

Aug 6 2016, 4:59 PM · Design