Page MenuHomePhabricator

Semantics around historical commits in an Owners package are awkward
Open, WishlistPublic

Description

  • Owners stores "commit X is part of package Y" by using a "no audit required" audit relationship. This is goofy, and should just be an edge.
  • Owners resolves packages at import time, so importing a repository and then creating a package will leave the package empty until new commits arrive. This is probably reasonable overall, but isn't currently clear and can not currently be remedied (e.g., by reindexing the repository).

Original Description

https://reviews.freebsd.org/owners/package/3/ consits of a file and a directory, but no commits show under "all package commits" here: https://reviews.freebsd.org/audit/?auditorPHIDs=PHID-OPKG-rgjklbo23relt22gusts

Event Timeline

eadler assigned this task to epriestley.
eadler raised the priority of this task from to Normal.
eadler updated the task description. (Show Details)
eadler added a project: Owners.

I can't view those links and can't reproduce this locally:

Screen Shot 2015-08-31 at 8.08.22 AM.png (868×1 px, 169 KB)

Note that this is only expected to find commits which were in the package when they were imported. So if you import a repository, then define a package, it won't get any hits. This is driven by two concerns:

  • A practical technical concern: package queries are arbitrarily expensive and executing them inline would be slow and complex and in some cases impossible.
  • A mild product concern: as a package definition changes over time, it's desirable for old commits which used to be part of the package to show up as results.

The way that package membership is currently represented (as a "no audit required" audit relationship) is real dumb, and there's no way to rebuild history after defining packages, and this whole thing isn't communicated as clearly as it should be. But I believe this does basically work as expected today.

I'd like to fix these things eventually, but they probably don't make the cut for the "dark ages" iteration.

epriestley renamed this task from package missing commits to Semantics around historical commits in an Owners package are awkward.Aug 31 2015, 3:17 PM
epriestley removed epriestley as the assignee of this task.
epriestley lowered the priority of this task from Normal to Wishlist.
epriestley updated the task description. (Show Details)
epriestley moved this task from Backlog to Future on the Owners board.
eadler added a project: Restricted Project.Aug 7 2016, 8:09 PM