Herald is an important piece of application glue which covers a lot of edge-case workflows. One thing which Herald would be useful for in Calendar is letting me subscribe to Bob and Chad's events. (This specific use case might be worth making more formal at some point, but doing it through Herald first is a good way to gauge how valuable it is.)
Description
Description
Revisions and Commits
Revisions and Commits
| rP Phabricator | |||
| D16368 | rP87f663ef77b4 Add basic Herald support to Calendar | ||
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Open | epriestley | T7924 Unprototype Calendar (v1) | ||
| Resolved | lpriestley | T7926 Modernize Calendar Infrastructure | ||
| Resolved | epriestley | T7939 Support Herald rules for Calendar events | ||
| Resolved | epriestley | T9719 Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess |
Event Timeline
Comment Actions
- Write a subclass of HeraldAdapter. I think PhrictionDocumentHeraldAdapter is a fairly reasonable example.
- In HeraldTestConsoleController, you have to add a hacky piece of code to help Herald figure out which adapter to use.
- In your Editor, implement shouldApplyHeraldRules(), buildHeraldAdapter() and didApplyHeraldRules().
- You should now be able to use the test console to test rules.