Page MenuHomePhabricator
Feed Advanced Search

Feb 8 2016

epriestley renamed T4427: Add formal task points from Ability to sum a custom field on board columns to Add formal task points.
Feb 8 2016, 11:59 PM · Wikimedia, Maniphest, Workboards
epriestley closed T10288: Build a real progress bar as Resolved.

The rest of this will roll up into other tasks which actually use it, etc.

Feb 8 2016, 11:58 PM · Design, PHUI, Projects (v3)
epriestley added a revision to T10288: Build a real progress bar: Unknown Object (Differential Revision).
Feb 8 2016, 11:01 PM · Design, PHUI, Projects (v3)
epriestley added a comment to T4427: Add formal task points.

Yeah, I'm planning to let you label the field with whatever you want, I just haven't figured out where I'm going to stick that. Current leading contender is adding some special stuff to maniphest.custom-field-definitions, but I don't love that for various reasons. I may just do some new maniphest.points sort of thing and put some UI on it.

Feb 8 2016, 10:29 PM · Wikimedia, Maniphest, Workboards
epriestley added a comment to T4427: Add formal task points.

Yeah, fractional points are OK if you're literally labeling the field "Estimated Hours".

Feb 8 2016, 10:21 PM · Wikimedia, Maniphest, Workboards
epriestley added a comment to T4427: Add formal task points.

well maybe I'll allow fractional points

Feb 8 2016, 10:16 PM · Wikimedia, Maniphest, Workboards
epriestley closed T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)" as Resolved by committing Restricted Diffusion Commit.
Feb 8 2016, 10:09 PM · Projects, Wikimedia, Workboards
epriestley closed T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)", a subtask of T7418: Default landing page for projects should be info + feed, as Resolved.
Feb 8 2016, 10:09 PM · Design, Projects
epriestley added a comment to T4427: Add formal task points.

Here's my current plan:

Feb 8 2016, 10:08 PM · Wikimedia, Workboards, Maniphest
epriestley added a comment to T10283: improve differential emails, optimizing for efficiency.

Cool, sounds good. There's definitely room for improvement here and we're open to making changes if it turns out you do actually have a few competing use cases to balance, but I suspect you can make reasonable headway on at least some of this by revisiting Config with an eye to dialing settings back toward optimizing the "ignore / review" decision.

Feb 8 2016, 9:14 PM · Mail, Restricted Project, Feature Request
joshuaspence added a project to T10297: No queries available on Dashboard exception.: Dashboards.
Feb 8 2016, 8:14 PM · Bug Report (Needs Information), Dashboards
joshuaspence added a project to T10299: Maniphest search with slugs results in error: ApplicationSearch.
Feb 8 2016, 8:12 PM · ApplicationSearch, Bug Report
epriestley closed T5240: Dragging items (cards, panels) could be better in Workboards as Resolved.

This probably still isn't perfect, but:

Feb 8 2016, 7:38 PM · Projects (v3), Workboards
epriestley added a revision to T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)": Unknown Object (Differential Revision).
Feb 8 2016, 7:27 PM · Projects, Wikimedia, Workboards
epriestley moved T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets from Backlog to Workboards v2 on the Workboards board.
Feb 8 2016, 6:58 PM · Customer Impact, Workboards, Maniphest
epriestley moved T5214: Add Conduit API methods for workboards from Workboards v2 to Future Work on the Workboards board.
Feb 8 2016, 6:58 PM · Restricted Project, Conduit, Maniphest, Workboards
epriestley moved T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)" from Future Work to Workboards v2 on the Workboards board.
Feb 8 2016, 6:58 PM · Projects, Wikimedia, Workboards
epriestley moved T10293: Plan rest of "CoverImage" feature from Backlog to Future Work on the Workboards board.
Feb 8 2016, 6:58 PM · Workboards, Projects (v3)
epriestley moved T4427: Add formal task points from Future Work to Workboards v2 on the Workboards board.
Feb 8 2016, 6:58 PM · Wikimedia, Workboards, Maniphest
epriestley moved T6064: One-Click Add Task on Workboard Columns from Workboards v2 to Future Work on the Workboards board.
Feb 8 2016, 6:58 PM · Restricted Project, Workboards
epriestley moved T5024: Provide a dedicated page for viewing a single workboard column from Future Work to Workboards v2 on the Workboards board.
Feb 8 2016, 6:58 PM · Restricted Project, Workboards
epriestley moved T5240: Dragging items (cards, panels) could be better in Workboards from Future Work to Workboards v2 on the Workboards board.
Feb 8 2016, 6:58 PM · Projects (v3), Workboards
epriestley moved T6415: Workboard drag and drop freezes indefinitely if it cannot access the server even temporarily from Backlog to Far Future on the Workboards board.
Feb 8 2016, 6:45 PM · Workboards
epriestley closed T10299: Maniphest search with slugs results in error as Resolved by committing Restricted Diffusion Commit.
Feb 8 2016, 6:44 PM · ApplicationSearch, Bug Report
epriestley added a comment to T10299: Maniphest search with slugs results in error.

Using PHIDs instead of slugs is likely a workaround, but possibly not helpful depending on what you're doing. D15214 should fix the root issue. Thanks for the report!

Feb 8 2016, 6:29 PM · ApplicationSearch, Bug Report
epriestley claimed T10299: Maniphest search with slugs results in error.
Feb 8 2016, 6:29 PM · ApplicationSearch, Bug Report
epriestley added a revision to T10299: Maniphest search with slugs results in error: Unknown Object (Differential Revision).
Feb 8 2016, 6:28 PM · ApplicationSearch, Bug Report
epriestley added a comment to T10299: Maniphest search with slugs results in error.

Never mind, here's an example:

Feb 8 2016, 6:26 PM · ApplicationSearch, Bug Report
epriestley added a comment to T10299: Maniphest search with slugs results in error.

Can you give me an example of a URL which hits this?

Feb 8 2016, 6:25 PM · ApplicationSearch, Bug Report
epriestley closed T10298: exact typeahead for archived projects low priory match as Resolved.

Yeah, it feels a bit like the "baby's first typeahead" button to me (since it didn't exist for so long, and is usually useless if you know what you're going to select) and it usually takes me a minute to remember it's there.

Feb 8 2016, 4:41 PM · Typeahead, Bug Report
epriestley added a comment to T10298: exact typeahead for archived projects low priory match.

Here's a workaround:

Feb 8 2016, 4:27 PM · Typeahead, Bug Report
epriestley added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

You can use a policy like this to restrict a key to requests originating from a particular VPC:

Feb 8 2016, 2:22 AM · Files
• oysterFAKE awarded T4213: Provide custom themes, skinning, or custom CSS a Like token.
Feb 8 2016, 1:23 AM · Design
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Feb 8 2016, 12:29 AM
epriestley added a revision to T5240: Dragging items (cards, panels) could be better in Workboards: Unknown Object (Differential Revision).
Feb 8 2016, 12:28 AM · Projects (v3), Workboards

Feb 7 2016

epriestley added a revision to T5240: Dragging items (cards, panels) could be better in Workboards: Unknown Object (Differential Revision).
Feb 7 2016, 11:56 PM · Projects (v3), Workboards
epriestley closed T8434: Accommodate the "Security" workflow as Resolved.
Feb 7 2016, 10:42 PM · Wikimedia, Policy, Prioritized
epriestley added a comment to T8434: Accommodate the "Security" workflow.

I believe we generally have an acceptable way forward here, at least in broad strokes, now so I'm going to close this out since I think it has served its purpose, but feel free to file a followup if things stall or you run into trouble.

Feb 7 2016, 10:42 PM · Wikimedia, Policy, Prioritized
epriestley removed a project from T5155: Evaluate support for AWS IAM Roles in S3 Client: libphutil.
Feb 7 2016, 10:20 PM · Files
epriestley moved T6445: Rendering SVG images from Backlog to Far Future on the Files board.
Feb 7 2016, 10:20 PM · Wikimedia, Restricted Project, Files
epriestley removed a project from T6445: Rendering SVG images: Remarkup.
Feb 7 2016, 10:20 PM · Wikimedia, Restricted Project, Files
epriestley triaged T6445: Rendering SVG images as Wishlist priority.

This isn't necessarily "won't ever fix", but the cost to secure SVG sufficiently is enormous and I can't imagine it making sense to pursue until we are a huge organization with as many as 4 or 5 full time engineers.

Feb 7 2016, 10:20 PM · Wikimedia, Restricted Project, Files
epriestley added a comment to T6445: Rendering SVG images.

Looking through the security situation in more detail in response to a recent report via HackerOne, I think it's unlikely that we'll pursue support for this in the upstream. Browsers will execute Javascript and other dangerous actions (external includes, entity expansion) in SVGs, and there is no way to avoid this in a categorical way or otherise delegate security to the browser.

Feb 7 2016, 10:16 PM · Wikimedia, Restricted Project, Files
epriestley closed T10295: Remove 'Attending' from Calendar Search Results display when empty as Resolved.

Resolved by D15207. Thanks!

Feb 7 2016, 6:00 PM · Calendar, Feature Request
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Feb 7 2016, 6:00 PM
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 7 2016, 5:21 AM · Projects (v3)
epriestley added a comment to T10294: Expected subprojects to appear in project's workboard.

The problem is that it means a card may appear more than once on a workboard (in multiple subproject columns) which violates a lot of assumptions the code makes and will probably be confusing to users forever. We technically generate these columns today, they're just hidden at the last second to avoid obvious brokenness in the UI.

Feb 7 2016, 5:12 AM · Feature Request
epriestley closed T5475: Maybe make clicking a task on workboards edit it as Resolved.

We have some plans to explore other approaches to "view with comments". I think that's probably the right action overall, and the new edit treatment feels good to me.

Feb 7 2016, 4:53 AM · Workboards
epriestley moved T6066: Presentation Mode for Workboards from Backlog to Far Future on the Workboards board.
Feb 7 2016, 4:49 AM · Workboards, Projects
epriestley lowered the priority of T6066: Presentation Mode for Workboards from Low to Wishlist.
Feb 7 2016, 4:49 AM · Workboards, Projects
epriestley closed T6206: Give UI feedback after a task has been moved as Wontfix.

The dimmed state is pretty obvious to my eye (it has possibly changed since this was originally filed) and we haven't seen feedback from other installs about this being difficult to parse visually. If we did see more feedback in this vein, I'd want to start by making the dimmed state more aggressive.

Feb 7 2016, 4:49 AM · Workboards
epriestley closed T7844: Workboard printable is incomplete/empty as Resolved by committing Restricted Diffusion Commit.
Feb 7 2016, 4:39 AM · Workboards
epriestley moved T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)" from Backlog to Future Work on the Workboards board.
Feb 7 2016, 4:35 AM · Projects, Wikimedia, Workboards
epriestley moved T7844: Workboard printable is incomplete/empty from Backlog to Workboards v2 on the Workboards board.
Feb 7 2016, 4:35 AM · Workboards
epriestley moved T10266: Firefox body scroll fails when dragging tasks from Backlog to Far Future on the Workboards board.
Feb 7 2016, 4:35 AM · Firefox, Projects
epriestley moved T6502: Policy to define who can move cards in a workboard from Workboards v2 to Far Future on the Workboards board.
Feb 7 2016, 4:35 AM · Projects, Wikimedia, Policy, Workboards
epriestley added a revision to T7844: Workboard printable is incomplete/empty: Unknown Object (Differential Revision).
Feb 7 2016, 4:32 AM · Workboards
epriestley removed a project from T9379: Build Phriction v3: Prioritized.
Feb 7 2016, 4:16 AM · Phriction
epriestley removed a project from T8783: Unprototype Nuance (v1): Prioritized.
Feb 7 2016, 4:16 AM · Nuance, Restricted Project
epriestley moved T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential from The Queue to Paused on the Prioritized board.
Feb 7 2016, 4:16 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley moved T182: Commit into repository directly from differential from The Queue to Paused on the Prioritized board.
Feb 7 2016, 4:16 AM · Haskell.org, Restricted Project, Differential
epriestley moved T9378: Build Projects v3 from Preflight to The Queue on the Prioritized board.
Feb 7 2016, 4:16 AM · Projects (v3), Prioritized
epriestley moved T8434: Accommodate the "Security" workflow from The Queue to Paused on the Prioritized board.
Feb 7 2016, 4:15 AM · Wikimedia, Policy, Prioritized
epriestley moved T7441: Support OAuth providers in the cluster from The Queue to Paused on the Prioritized board.
Feb 7 2016, 4:15 AM · Auth, Phacility
epriestley added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

Yes, in theory -- this is a problem with assigning sub-priorities as a side effect of dragging cards around on a priority-ordered workboard. That code hasn't been touched.

Feb 7 2016, 4:15 AM · Restricted Project, Workboards
epriestley updated the task description for T10293: Plan rest of "CoverImage" feature.
Feb 7 2016, 3:59 AM · Workboards, Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

You're basically just asking for a magic chart feature that does whatever you want. We, bound by earthly constraints, can not build that, and the request itself is not specific enough to be helpful in defining product direction. See also T4171.

Feb 7 2016, 12:45 AM · Design, PHUI, Projects (v3)
epriestley updated the task description for T10010: Implement Subprojects.
Feb 7 2016, 12:33 AM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 7 2016, 12:26 AM · Projects (v3)
epriestley moved T10168: Provide a clearer pathway forward for old projects with invalid hashtags from Future to Far Future on the Projects board.
Feb 7 2016, 12:14 AM · Projects, Bug Report
epriestley renamed T10168: Provide a clearer pathway forward for old projects with invalid hashtags from Projects with hashtags that stopped being valid on Oct 12 no longer work between Dec 27 and Jan 18 to Provide a clearer pathway forward for old projects with invalid hashtags.
Feb 7 2016, 12:14 AM · Projects, Bug Report
epriestley lowered the priority of T10168: Provide a clearer pathway forward for old projects with invalid hashtags from Normal to Wishlist.

Some day we'll provide some kind of tooling or migration approach here, but this seems stable for now.

Feb 7 2016, 12:14 AM · Projects, Bug Report

Feb 6 2016

epriestley added a comment to T10288: Build a real progress bar.

I haven't fully decided yet.

Feb 6 2016, 11:06 PM · Design, PHUI, Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

(Maybe the hybrid bar would be useful in some far-future PM-manager-manager view or whatever.)

Feb 6 2016, 10:58 PM · Design, PHUI, Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

If we're requiring setup and active management before we show a bar, maybe this bar is better?

Feb 6 2016, 10:57 PM · Design, PHUI, Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

Ah, so you wouldn't even show this bar until we implement points?

Feb 6 2016, 10:44 PM · Design, PHUI, Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

As a general philosophical question, what actionable information are we trying to convey with this element? I think it looks good and is probably worth adding even if it's just a "pretty bauble", and it's nice because it can show something reasonable and immediately comprehensible without any additional configuration/setup, but we're starting to descend the slippery slope of charts and graphs and I'd really like to be armed with strong product rationale as we proceed.

Feb 6 2016, 10:32 PM · Design, PHUI, Projects (v3)
epriestley updated the task description for T10010: Implement Subprojects.
Feb 6 2016, 8:55 PM · Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

I'm also 90% sure I'm going to have to build a PHUIX / pure javascript version of this anyway, so the pretty photoshop pixels are probably more important than the specific markup.

Feb 6 2016, 8:54 PM · Design, PHUI, Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

Minor, but it would be nice support multiple color segments, e.g.:

Feb 6 2016, 8:54 PM · Design, PHUI, Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 6 2016, 8:51 PM · Projects (v3)
epriestley moved T6502: Policy to define who can move cards in a workboard from v3 to Far Future on the Projects board.
Feb 6 2016, 8:37 PM · Projects, Wikimedia, Policy, Workboards
epriestley lowered the priority of T6502: Policy to define who can move cards in a workboard from Normal to Wishlist.

Given the feedback from @Krenair / @MZMcBride, I'm going to shelve this for the time being since WMF is the major driver for it but it looks like some mixture of contentious/low-priority/hypothetical, and even if consensus/priority does develop from WMF I'd like to wait for EditEngine and make sure the problems survive the new capabilities it introduced.

Feb 6 2016, 8:37 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

(Oh, the WMF task got a similar token so it's presumably an objection to the control.)

Feb 6 2016, 8:22 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

I'm not sure if that thumbs-down is an objection to introducing this policy control or an objection to my hesitance to introduce this policy control.

Feb 6 2016, 8:21 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

Looking deeper, I'm sort of wondering if we actually need this. Are you seeing (or still seeing) issues with this?

Feb 6 2016, 7:24 PM · Projects, Wikimedia, Policy, Workboards
epriestley updated subscribers of T10010: Implement Subprojects.
Feb 6 2016, 2:25 PM · Projects (v3)
epriestley merged task T10291: Hide "subprojects" menu item for milestone projects by default into T10010: Implement Subprojects.
Feb 6 2016, 2:25 PM · Projects (v3), Feature Request
epriestley updated the task description for T10010: Implement Subprojects.
Feb 6 2016, 2:25 PM · Projects (v3)
epriestley added a comment to T10291: Hide "subprojects" menu item for milestone projects by default.

I'm just going to merge this into T10010 and note it explicitly as errata; I'm planning to do this but just haven't built a hide-menu-item feature yet.

Feb 6 2016, 2:24 PM · Projects (v3), Feature Request
epriestley updated the task description for T10010: Implement Subprojects.
Feb 6 2016, 2:24 PM · Projects (v3)
epriestley edited the content of Welcome.
Feb 6 2016, 1:19 PM
epriestley edited the content of Welcome.
Feb 6 2016, 1:19 PM
epriestley edited the content of Changelog.
Feb 6 2016, 1:17 PM
epriestley created 2016 Week 6 (Early February) Changelog.
Feb 6 2016, 1:16 PM
epriestley published Blog Post: Development Notes (2016 Week 6).
Feb 6 2016, 1:16 PM
epriestley claimed T10290: Creating first project/task is broken.
Feb 6 2016, 12:47 PM · Bug Report
epriestley closed T10290: Creating first project/task is broken as Resolved by committing Restricted Diffusion Commit.
Feb 6 2016, 12:47 PM · Bug Report
epriestley added a comment to T10290: Creating first project/task is broken.

Thanks for catching this!

Feb 6 2016, 12:47 PM · Bug Report
• manas-chaudhari awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Feb 6 2016, 5:16 AM · Workboards (v3), Restricted Project