Page MenuHomePhabricator
Create Task
Maniphest T10295

Remove 'Attending' from Calendar Search Results display when empty
Closed, ResolvedPublic
Actions

Description

When creating a calendar entry, some are a "public service announcement." Meaning, it's not really an event you attend. For example, a scheduled release deployment. Therefore, our Attendee list is empty. When this is the case, the 'Attending' text on the calendar entry looks a bit out of place.

Screen Shot 2016-02-07 at 2.41.45 AM.png (265×367 px, 51 KB)

It would be nice if there are no attendees to skip the output of the Attendees.

Revisions and Commits

rP Phabricator
D15207rP604b78095349 Fix an issue where 'Attending' would appear on calendar view unnecessarily

Related Objects

Event Timeline

jcowgar created this task.Feb 7 2016, 7:45 AM
jcowgar added a comment.Feb 7 2016, 7:49 AM

I'm more than happy to take on this task as my first contribution to Phabricator, but in reading the contributor guide it says all feature requests/bug reports should be first discussed.

chad added a subscriber: chad.Feb 7 2016, 3:13 PM

go for it!

jcowgar added a revision: D15207: Fix an issue where 'Attending' would appear on calendar view unnecessarily.Feb 7 2016, 4:08 PM
epriestley added a commit: rP604b78095349: Fix an issue where 'Attending' would appear on calendar view unnecessarily.Feb 7 2016, 6:00 PM
epriestley closed this task as Resolved.Feb 7 2016, 6:00 PM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

Resolved by D15207. Thanks!

jcowgar added a comment.Feb 8 2016, 1:02 AM

Thanks to you guys for helping through my first commit. Probably took longer to review,c comment, approve than to just do it yourself. Appreciate the hand holding, looking forward to other contributes in the future.

Phabricator · Built by Phacility