Page MenuHomePhabricator
Feed Advanced Search

Jan 13 2017

epriestley added a comment to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).

They are not related. That search uses fulltext indexes (see T11922 / T11741 for recent discussion), not ngram indexes.

Jan 13 2017, 5:50 PM · Owners, Files, ApplicationSearch
epriestley edited the content of Phacility Cluster Devices.
Jan 13 2017, 5:15 PM
epriestley created T12105: Put shards 13-16 into production in the Phacility cluster.
Jan 13 2017, 5:15 PM · Phacility, Ops
epriestley added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

uhoh

Jan 13 2017, 5:05 PM · Installing & Upgrading, Differential
epriestley added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

Hour or two if nothing's on fire -- probably today, just later this evening.

Jan 13 2017, 5:04 PM · Installing & Upgrading, Differential
epriestley closed T12095: Differential reads and writes draft status to different tables, leading to various UI inconsistencies as Resolved by committing Restricted Diffusion Commit.
Jan 13 2017, 5:02 PM · Differential, Bug Report
epriestley added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

@jmeador, I think I have a fix for your use case but it touches enough stuff that I'm going to hold it until after release promotion. Your use case is a bit unusual but should be possible to support.

Jan 13 2017, 5:01 PM · Installing & Upgrading, Differential
epriestley created T12104: Clean up remnants of old Differential draft storage.
Jan 13 2017, 3:45 PM · Infrastructure, Differential
epriestley added a revision to T6660: Unsubmitted comments icon for Audits: Unknown Object (Differential Revision).
Jan 13 2017, 3:37 PM · Restricted Project, Audit
epriestley added a revision to T12095: Differential reads and writes draft status to different tables, leading to various UI inconsistencies: Unknown Object (Differential Revision).
Jan 13 2017, 3:37 PM · Differential, Bug Report
pouyana awarded T12101: Phabricator PHP 7 Compatibility a Mountain of Wealth token.
Jan 13 2017, 3:10 PM · Infrastructure, Guides
epriestley added a revision to T12098: Create Revision from FavoritesMenuItem doesn't work: Unknown Object (Differential Revision).
Jan 13 2017, 2:21 PM · Dashboards, Differential
skibbipl awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Jan 13 2017, 12:09 PM · Prioritized, Restricted Project, Infrastructure
cmmata awarded T9640: Make Phabricator compatible with PHP7 a 100 token.
Jan 13 2017, 10:16 AM · Prioritized, Restricted Project, Infrastructure
Zolli awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Jan 13 2017, 6:03 AM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T12081: "Unable to establish a connection to any database host" via ssh git push.

(I no longer need access to the server.)

Jan 13 2017, 1:48 AM · Bug Report (Needs Information)
epriestley closed T12081: "Unable to establish a connection to any database host" via ssh git push as Invalid.

Having run the scripts on a new server the only thing I can think of is the fact that the scripts change #!/usr/bin/env php to #!/usr/bin/env php5.6

Jan 13 2017, 1:46 AM · Bug Report (Needs Information)
epriestley added a revision to T9482: Problems in the "Commits in this Package that Need Attention" view: Unknown Object (Differential Revision).
Jan 13 2017, 12:33 AM · Restricted Project, Restricted Project, Audit
chad awarded T12101: Phabricator PHP 7 Compatibility a Doubloon token.
Jan 13 2017, 12:17 AM · Infrastructure, Guides
epriestley closed T9640: Make Phabricator compatible with PHP7 as Resolved.

This was prioritized privately and PHP7 is now supported. Not sure I got everything, but I'm on PHP7 locally now so presumably I'll hit any remaining issues before too long. T12101 is the new informational task. We will now accept bug reports against PHP7. The documentation should regenerate within a day or so. These changes will promote to stable in about 24 hours.

Jan 13 2017, 12:16 AM · Prioritized, Restricted Project, Infrastructure
epriestley closed T9640: Make Phabricator compatible with PHP7, a subtask of T10987: /config/issue/ causes coredump in PHP-FPM, as Resolved.
Jan 13 2017, 12:16 AM · Bug Report
epriestley changed the destination URL U28 PHP7 from https://secure.phabricator.com/T9640 to https://secure.phabricator.com/T12101.
Jan 13 2017, 12:13 AM
epriestley added projects to T12101: Phabricator PHP 7 Compatibility: Guides, Infrastructure.
Jan 13 2017, 12:13 AM · Infrastructure, Guides
epriestley created T12101: Phabricator PHP 7 Compatibility.
Jan 13 2017, 12:13 AM · Infrastructure, Guides
epriestley renamed T9640: Make Phabricator compatible with PHP7 from Phabricator PHP 7 Compatibility to Make Phabricator compatible with PHP7.
Jan 13 2017, 12:08 AM · Prioritized, Restricted Project, Infrastructure

Jan 12 2017

epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:55 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:53 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:53 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:44 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:43 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:41 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:39 PM · Prioritized, Restricted Project, Infrastructure
epriestley claimed T9640: Make Phabricator compatible with PHP7.
Jan 12 2017, 10:12 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T12100: Consider removing "maximum-scale" from "viewport" tag.

There are at least some nontrivial effects, like searching for text without "maximum-scale" can imply a zoom:

Jan 12 2017, 10:11 PM · Mobile
epriestley renamed T12100: Consider removing "maximum-scale" from "viewport" tag from Don't prevent zooming on phones to Consider removing "maximum-scale" from "viewport" tag.
Jan 12 2017, 10:07 PM · Mobile
epriestley added a comment to T12100: Consider removing "maximum-scale" from "viewport" tag.

Oh, sorry, you just wanted maximum-scale removed.

Jan 12 2017, 10:01 PM · Mobile
epriestley added a comment to T12100: Consider removing "maximum-scale" from "viewport" tag.

Here are some screenshots of Phabricator with this tag removed, as you suggest:

Jan 12 2017, 9:58 PM · Mobile
epriestley closed T9482: Problems in the "Commits in this Package that Need Attention" view as Resolved by committing Restricted Diffusion Commit.
Jan 12 2017, 9:41 PM · Restricted Project, Restricted Project, Audit
epriestley closed T9482: Problems in the "Commits in this Package that Need Attention" view, a subtask of T9279: Sort commit history chronologically, as Resolved.
Jan 12 2017, 9:41 PM · Audit, Restricted Project
epriestley closed T7076: Show status of linked revisions for tasks as Resolved by committing Restricted Diffusion Commit.
Jan 12 2017, 9:23 PM · Restricted Project, Differential, Maniphest
epriestley closed T12100: Consider removing "maximum-scale" from "viewport" tag as Invalid.

As you might already have guessed, this isn't a bug.

Jan 12 2017, 9:22 PM · Mobile
epriestley added a comment to T12032: Make sure Chrome 55 anchor issue does not impact Differential.

Chrome 56 has merged a fix for this so it should be moot in the not-too-distant future, although I'm not exactly sure what the Chrome release schedule looks like. If this only impacts ghost inlines for a few more weeks it's pretty tempting to just wait for it to resolve itself, but I may be digging around in that code soon so perhaps I'll take a more detailed look.

Jan 12 2017, 9:06 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential
epriestley added a revision to T9482: Problems in the "Commits in this Package that Need Attention" view: Unknown Object (Differential Revision).
Jan 12 2017, 8:59 PM · Restricted Project, Restricted Project, Audit
epriestley added a revision to T10978: Modernize Audit: Unknown Object (Differential Revision).
Jan 12 2017, 8:52 PM · Audit
epriestley added a comment to T9482: Problems in the "Commits in this Package that Need Attention" view.

I'm going to switch this view to show overall commit audit status, not weird semi-viewer audit status. At one point it wasn't clear how heavily we were going to try to skew views to account for viewer status, but bucketing changes seem to have reduced the need for this and I think extending the Differential model to Audit now makes sense. See also T9430 for some context.

Jan 12 2017, 8:51 PM · Restricted Project, Restricted Project, Audit
epriestley added a revision to T7076: Show status of linked revisions for tasks: Unknown Object (Differential Revision).
Jan 12 2017, 8:30 PM · Restricted Project, Differential, Maniphest
epriestley merged T6636: Show Audit status of referenced commits in Maniphest into T7076: Show status of linked revisions for tasks.
Jan 12 2017, 8:08 PM · Restricted Project, Differential, Maniphest
epriestley merged task T6636: Show Audit status of referenced commits in Maniphest into T7076: Show status of linked revisions for tasks.
Jan 12 2017, 8:08 PM · Audit, Diffusion, Maniphest
epriestley added a comment to T6636: Show Audit status of referenced commits in Maniphest.

I'm going to merge this into T7076, which discusses revisions instead of commits/audits, but the resolution for both is likely the same and that task has a more complete discussion of context.

Jan 12 2017, 8:08 PM · Audit, Diffusion, Maniphest
epriestley closed T9430: "Needs Audit" no longer excludes author commits as Resolved by committing Restricted Diffusion Commit.
Jan 12 2017, 8:04 PM · Restricted Project, Restricted Project, Audit
epriestley closed T9544: way to search for commits with no audit status as Resolved by committing Restricted Diffusion Commit.
Jan 12 2017, 8:04 PM · Restricted Project, Restricted Project, Audit
epriestley added a comment to T9640: Make Phabricator compatible with PHP7.

I don't think the task detail trivializes this. I expect PHP7 issues will take very little time to resolve, perhaps 2-3 hours? Some installs already run PHP7 with varying degrees of success, which implies there are likely few unknowns lurking in the shadows. I believe this is not a large or complex technical task; it is purely a prioritization issue.

Jan 12 2017, 7:52 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T9640: Make Phabricator compatible with PHP7.

I'll also note that this discussion is moot, anyway: this is not blocked on development resources, and is purely a prioritization issue. If we had 10 full time engineers, this still wouldn't be what any of them would be working on.

Jan 12 2017, 7:33 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T9640: Make Phabricator compatible with PHP7.

We were more open to contributions in the past. The high bar contributions now face is a direct response to the enormous maintenance burden that those changes saddled us with. This is explained in Contributing Code and elsewhere.

Jan 12 2017, 7:31 PM · Prioritized, Restricted Project, Infrastructure
epriestley closed T8683: Ability to query audits where all auditors have replied as Wontfix.

I believe this is probably obsoleted by D17192, or will be obsoleted by T2393.

Jan 12 2017, 7:03 PM · Audit
epriestley added a comment to T9544: way to search for commits with no audit status.

After D17192, all commit states can be queried explicitly:

Jan 12 2017, 6:59 PM · Restricted Project, Restricted Project, Audit
epriestley added a revision to T9544: way to search for commits with no audit status: Unknown Object (Differential Revision).
Jan 12 2017, 6:58 PM · Restricted Project, Restricted Project, Audit
epriestley added a comment to T9430: "Needs Audit" no longer excludes author commits.

After D17192, audits bucket into a dashboard like Differential. Feedback from the Differential bucketing changes has generally been positive, so I think this is probably generally a good direction. It also improves consistency between the applications, if nothing else.

Jan 12 2017, 6:56 PM · Restricted Project, Restricted Project, Audit
epriestley closed T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch as Resolved.

I've marked D17192 as resolving this because viewer() now means "viewer, their projects, and their packages", like Differential. exact(<user>) can be used for exactly a specific user.

Jan 12 2017, 6:46 PM · Restricted Project, Typeahead, Audit
epriestley added a revision to T9430: "Needs Audit" no longer excludes author commits: Unknown Object (Differential Revision).
Jan 12 2017, 6:31 PM · Restricted Project, Restricted Project, Audit
epriestley added a revision to T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch: Unknown Object (Differential Revision).
Jan 12 2017, 6:31 PM · Restricted Project, Typeahead, Audit
epriestley merged T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands into T9640: Make Phabricator compatible with PHP7.
Jan 12 2017, 5:38 PM · Prioritized, Restricted Project, Infrastructure
epriestley merged task T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands into T9640: Make Phabricator compatible with PHP7.
Jan 12 2017, 5:37 PM · Daemons, Bug Report
epriestley added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

I'm just going to merge this into T9640, it isn't meaningfully different from an implementation perspective and is the major compatibility issue.

Jan 12 2017, 5:37 PM · Daemons, Bug Report
epriestley added a comment to T9430: "Needs Audit" no longer excludes author commits.

We could resolve this by implementing "Responsible Users", like Differential.

Jan 12 2017, 4:17 PM · Restricted Project, Restricted Project, Audit
epriestley merged T8690: Modernize PhabricatorCommitSearchEngine into T9430: "Needs Audit" no longer excludes author commits.
Jan 12 2017, 3:58 PM · Restricted Project, Restricted Project, Audit
epriestley merged task T8690: Modernize PhabricatorCommitSearchEngine into T9430: "Needs Audit" no longer excludes author commits.
Jan 12 2017, 3:58 PM · Audit, Restricted Project, ApplicationSearch, Diffusion
epriestley added a comment to T8690: Modernize PhabricatorCommitSearchEngine.

I'm going to merge this into T9430 since they have the same upstream remedy. This query has largely been modern for some time, but I want to sort out T9430 before providing diffusion.commit.search.

Jan 12 2017, 3:58 PM · Audit, Restricted Project, ApplicationSearch, Diffusion
epriestley added a revision to T10978: Modernize Audit: Unknown Object (Differential Revision).
Jan 12 2017, 3:47 PM · Audit
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 12 2017, 3:47 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a comment to T12098: Create Revision from FavoritesMenuItem doesn't work.

Ah, cool. I'll throw something hacky over this for now if I have a chance, then.

Jan 12 2017, 3:35 PM · Dashboards, Differential
epriestley added a revision to T10978: Modernize Audit: Unknown Object (Differential Revision).
Jan 12 2017, 3:30 PM · Audit
epriestley claimed T12098: Create Revision from FavoritesMenuItem doesn't work.

I think the item didn't exist at all before, and T11114 created it as a side effect. All the installs I have immediate access to are up to date, but, e.g., neither the KDE nor WMF installs have "Create Diff" or "Create Revision" in the menu even though I have access to Differential on both.

Jan 12 2017, 3:20 PM · Dashboards, Differential
PhoneixS awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Jan 12 2017, 9:58 AM · Prioritized, Restricted Project, Infrastructure
epriestley closed T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion as Resolved by committing Restricted Diffusion Commit.
Jan 12 2017, 12:28 AM · Audit, Diffusion, Wikimedia

Jan 11 2017

epriestley added a revision to T10978: Modernize Audit: Unknown Object (Differential Revision).
Jan 11 2017, 11:27 PM · Audit
epriestley added a revision to T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion: Unknown Object (Differential Revision).
Jan 11 2017, 11:20 PM · Audit, Diffusion, Wikimedia
epriestley closed T7504: Manually added auditors doesn't change commit audit status as Resolved by committing Restricted Diffusion Commit.
Jan 11 2017, 10:59 PM · Audit
epriestley closed T8739: Inline comments not sorted as Resolved by committing Restricted Diffusion Commit.
Jan 11 2017, 10:57 PM · Audit
epriestley closed T2921: Audit status is none on commit views of Audit if no Auditors specifically assigned as Invalid.

This is 100 years old and I'm no longer sure what it's describing or how to reproduce it. Feel free to file a new issue if this is still a problem. Note that Audit is churning a lot right now (see T10978) so the behavior may change in the near term. This may also be a "viewer audit status" vs "commit overall audit status" issue in some sense (T9482 / T6024).

Jan 11 2017, 10:56 PM · Audit
epriestley added a revision to T7504: Manually added auditors doesn't change commit audit status: Unknown Object (Differential Revision).
Jan 11 2017, 10:53 PM · Audit
epriestley closed T5928: Clarify language around self-accepting Audits as Resolved.

We no longer offer this option at HEAD. I'm moving us away from the self raise + self accept workflow to align better with Differential and because the state is unintuitive.

Jan 11 2017, 10:49 PM · Audit
epriestley closed T10446: Unable to simply mark a Diffusion comment as Done as Resolved by committing Restricted Diffusion Commit.
Jan 11 2017, 10:46 PM · Audit, Bug Report
epriestley added a comment to T10446: Unable to simply mark a Diffusion comment as Done.

I believe D17183 fixes this. If you're still seeing issues after upgrading past that change, file a new issue with modern reproduction instructions.

Jan 11 2017, 10:46 PM · Audit, Bug Report
epriestley added a revision to T8739: Inline comments not sorted: Unknown Object (Differential Revision).
Jan 11 2017, 10:46 PM · Audit
epriestley added a comment to T8739: Inline comments not sorted.

D17183 fixes half of this: previews are now sorted in creation order, from oldest (top) to newest (bottom). This is the same order used in Differential. We use this order for previews because it makes it easier to review recently added comments while working through a review/audit.

Jan 11 2017, 10:34 PM · Audit
epriestley added a revision to T10978: Modernize Audit: Unknown Object (Differential Revision).
Jan 11 2017, 10:27 PM · Audit
epriestley added a revision to T8739: Inline comments not sorted: Unknown Object (Differential Revision).
Jan 11 2017, 10:27 PM · Audit
epriestley added a revision to T10446: Unable to simply mark a Diffusion comment as Done: Unknown Object (Differential Revision).
Jan 11 2017, 10:27 PM · Audit, Bug Report
epriestley added a revision to T10978: Modernize Audit: Unknown Object (Differential Revision).
Jan 11 2017, 8:19 PM · Audit
epriestley closed T7676: Packages that are configured to auto-audit often generate audits that are un-closable as Resolved.

I'm just going to presume this is resolved, in some sense, by D17181, because you can now remove auditors regardless of other outcomes.

Jan 11 2017, 7:29 PM · Owners, Audit
epriestley added a revision to T10978: Modernize Audit: Unknown Object (Differential Revision).
Jan 11 2017, 7:23 PM · Audit
epriestley added a revision to T7676: Packages that are configured to auto-audit often generate audits that are un-closable: Unknown Object (Differential Revision).
Jan 11 2017, 7:23 PM · Owners, Audit
epriestley added a comment to T12097: Object Herald Rules for Commits on Projects no longer working as expected.

Great, thanks for the report! This should now be fixed in HEAD of master, and promote to stable within about 72 hours.

Jan 11 2017, 6:31 PM · Bug Report
epriestley closed T12097: Object Herald Rules for Commits on Projects no longer working as expected as Resolved by committing Restricted Diffusion Commit.
Jan 11 2017, 6:29 PM · Bug Report
epriestley added a revision to T12097: Object Herald Rules for Commits on Projects no longer working as expected: Unknown Object (Differential Revision).
Jan 11 2017, 6:13 PM · Bug Report
epriestley added a comment to T12097: Object Herald Rules for Commits on Projects no longer working as expected.

I believe this behavior accidentally changed in D16413, on Aug 17 2016. That change caused us to use the commit's project tags instead of the repository's project tags.

Jan 11 2017, 6:05 PM · Bug Report
epriestley added a revision to T10978: Modernize Audit: Unknown Object (Differential Revision).
Jan 11 2017, 5:50 PM · Audit
epriestley added a revision to T10978: Modernize Audit: Restricted Differential Revision.
Jan 11 2017, 5:44 PM · Audit
epriestley added a revision to T10978: Modernize Audit: Restricted Differential Revision.
Jan 11 2017, 5:40 PM · Audit