Page MenuHomePhabricator
Feed Advanced Search

Feb 20 2016

epriestley added a comment to T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.

To clarify, you are using HTTP for Phabricator but HTTPS for the notification server? If so, why have you made this (unusual) configuration choice?

Feb 20 2016, 10:42 AM · Setup
kislinsk awarded T3980: Support "Bind to External Thing" to define project membership a Like token.
Feb 20 2016, 9:10 AM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects

Feb 19 2016

epriestley edited the content of Changelog.
Feb 19 2016, 11:58 PM
epriestley published Blog Post: Development Notes (2016 Week 8).
Feb 19 2016, 11:58 PM
epriestley created 2016 Week 8 (Late February).
Feb 19 2016, 11:50 PM
epriestley closed T10396: Remarkup toolbar actions always cause comment box to scroll to bottom as Resolved by committing Restricted Diffusion Commit.
Feb 19 2016, 10:55 PM · Remarkup, Google Chrome, Bug Report
epriestley added a comment to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom.

Yeah, I came to approximately the same conclusion. Save + restore on the scroll position appears to be a complete fix as far as I can tell.

Feb 19 2016, 10:55 PM · Remarkup, Google Chrome, Bug Report
epriestley added a revision to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom: Unknown Object (Differential Revision).
Feb 19 2016, 10:49 PM · Remarkup, Google Chrome, Bug Report
epriestley added a comment to T10398: Phabricator UI uses deprecated <tt> tag .

Invalidating the cache is trivial, but I think <code> is used to style code blocks and has a bunch of different rules (e.g., block formatting) already associated with it.

Feb 19 2016, 10:46 PM · Remarkup, Bug Report
joshuaspence added a comment to T10400: Dropdown menus can overlap.

Yeah, either closing other open menus or allowing menus to be stacked on top of each other.

Feb 19 2016, 10:41 PM · PHUI, Bug Report
joshuaspence updated the task description for T10400: Dropdown menus can overlap.
Feb 19 2016, 10:41 PM · PHUI, Bug Report
joshuaspence created T10400: Dropdown menus can overlap.
Feb 19 2016, 10:23 PM · PHUI, Bug Report
chrisportela awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Feb 19 2016, 9:44 PM · Workboards (v3), Restricted Project
epriestley added a comment to T10398: Phabricator UI uses deprecated <tt> tag .

Does this cause any concrete problems in any user agent?

Feb 19 2016, 9:42 PM · Remarkup, Bug Report
epriestley added a comment to T9897: Unbeta Feedback on Phame.

Although I guess that sort of doesn't really solve many/any problems. But we could embrace that by allowing a blog to be "unlisted" or something, maybe.

Feb 19 2016, 9:35 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

A possible workaround is to create two blogs (review, production), and use "Move Post" as a "Super Publish".

Feb 19 2016, 9:33 PM · Phame
epriestley added a comment to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom.

Thanks, I'll see if I can figure out what's going on in Chrome.

Feb 19 2016, 9:17 PM · Remarkup, Google Chrome, Bug Report
amartin33 awarded T182: Commit into repository directly from differential a Like token.
Feb 19 2016, 8:20 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom.

On OSX, I can't reproduce this in Safari or Firefox, but it does reproduce in Chrome. Are you also using Chrome?

Feb 19 2016, 8:09 PM · Remarkup, Google Chrome, Bug Report
epriestley updated subscribers of T10395: Deploy SSH keys associated with a repository.

The expectation is that you create a "Bot" account, and add keys to that account.

Feb 19 2016, 7:55 PM · Feature Request (Needs Information), Diffusion
epriestley closed T10394: Font awesome icons not rendering in remarkup on Phacility as Resolved.

Presuming resolved, but yell if I missed anything.

Feb 19 2016, 7:53 PM · Macros, Remarkup, Bug Report
epriestley added a comment to T10394: Font awesome icons not rendering in remarkup on Phacility.

Caches should be purged, let me know if you're still seeing issues? D15311 will fix the underlying problem, and should promote and deploy in the next 24 hours.

Feb 19 2016, 7:45 PM · Macros, Remarkup, Bug Report
epriestley added a revision to T10394: Font awesome icons not rendering in remarkup on Phacility: Unknown Object (Differential Revision).
Feb 19 2016, 7:44 PM · Macros, Remarkup, Bug Report
amartin33 awarded T3980: Support "Bind to External Thing" to define project membership a Like token.
Feb 19 2016, 7:00 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
• joncalhoun awarded T6409: Link Task Status to Work board Column a Love token.
Feb 19 2016, 6:59 PM · Workboards
epriestley added a comment to T10394: Font awesome icons not rendering in remarkup on Phacility.

I'll clear the caches on your install and disassociate the {icon} rule from the Macro app. I think the original idea was that {icon} is silly nonsense like Macro, but {icon} has proven to be both silly nonsense and a super serious useful business tool.

Feb 19 2016, 6:43 PM · Macros, Remarkup, Bug Report
epriestley triaged T10392: Verify that VCS Password does not match LDAP Password as Wishlist priority.

This is via discussion on IRC, but the request captures it pretty well.

Feb 19 2016, 5:47 PM · Auth, Feature Request
epriestley closed T10391: Folders missing in Diffusion repository browser as Resolved.

I think this issue was fixed by 58c2141 (Feb 16) which hasn't promoted to stable yet. You can either upgrade to master now, or it should promote to stable in about 24 hours. If you want, you can subscribe to the Changelog to keep track of when we promote.

Feb 19 2016, 5:04 PM · Diffusion, Bug Report
epriestley added a comment to T10391: Folders missing in Diffusion repository browser.

Just to confirm, this is a Mercurial repository, right? (I'm assuming it is because of default instead of master, but just want to make sure.)

Feb 19 2016, 4:58 PM · Diffusion, Bug Report
epriestley added a comment to T10349: Projects v3 Errata.

A task tagged with a sub-project, is still in the parent project, right? So it hasn't been "removed" from Dashboards

Feb 19 2016, 4:00 PM · Restricted Project, Projects (v3)
epriestley added a comment to T10349: Projects v3 Errata.

There's no space to show that columns in cards, but would it be possible to show them in a tooltip?

Feb 19 2016, 3:48 PM · Restricted Project, Projects (v3)
epriestley renamed T10364: Conpherence v4 (UI/UX) from Update Conpherence (v4) to Conpherence v4 (UI/UX).
Feb 19 2016, 3:32 PM · Conpherence (v4)
epriestley added a comment to T10387: Create UI for visual (drag and drop) rearranging of task hierarchy.

I think it's vanishingly unlikely that we'll write a visual DAG editor.

Feb 19 2016, 3:31 PM · Feature Request
epriestley added a subtask for T10387: Create UI for visual (drag and drop) rearranging of task hierarchy: T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies.
Feb 19 2016, 3:30 PM · Feature Request
epriestley added a parent task for T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies: T10387: Create UI for visual (drag and drop) rearranging of task hierarchy.
Feb 19 2016, 3:30 PM · Maniphest
epriestley triaged T10387: Create UI for visual (drag and drop) rearranging of task hierarchy as Wishlist priority.
Feb 19 2016, 3:29 PM · Feature Request
epriestley added a comment to T10388: Additional remarkup assistance buttons for decriptions.

In general, we can't possibly create buttons for everything -- there are way too many rules, and some of the rules don't lend themselves easily to clicking a button. The icon already links to the full documentation, which explains everything (and this document is huge, because there are ton of rules).

Feb 19 2016, 3:29 PM · Feature Request (Needs Information), Design, Remarkup
epriestley updated the answer details for Q320: How to remove a picture at a task at a workboard? (Answer 333).
Feb 19 2016, 3:24 PM
epriestley added Q320: How to remove a picture at a task at a workboard? (Answer 333).
Feb 19 2016, 3:22 PM
epriestley renamed T10390: Dashboards v2 (UX) from Dashboard v2 (Home + Usability) to Dashboards v2 (Home + Usability).
Feb 19 2016, 3:20 PM · Dashboards (v2)
epriestley created T10390: Dashboards v2 (UX).
Feb 19 2016, 3:20 PM · Dashboards (v2)
Luke081515.2 awarded T10333: Add groups to workboard columns a Like token.
Feb 19 2016, 3:19 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley moved T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards." from Backlog to v2 on the Dashboards board.
Feb 19 2016, 3:18 PM · Dashboards
epriestley moved T6443: Provide ApplicationSearch options for Dashboard from Backlog to v2 on the Dashboards board.
Feb 19 2016, 3:18 PM · Dashboards (v2)
epriestley moved T8033: Inform editor when panels have more restrictive policy than dashboard from Backlog to v2 on the Dashboards board.
Feb 19 2016, 3:18 PM · Dashboards
epriestley moved T10145: Adding a panel to a dashboard multiple times from Backlog to v2 on the Dashboards board.
Feb 19 2016, 3:17 PM · Dashboards (v2), Bug Report
epriestley closed T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery". as Resolved.

It sounds like no one can reproduce this problem anymore. If anyone runs into this again and can figure out reproduction steps, feel free to file a new task with details.

Feb 19 2016, 3:17 PM · Diffusion, Dashboards, Bug Report
epriestley edited projects for T10297: No queries available on Dashboard exception., added: Bug Report (Needs Information); removed Bug Report.
Feb 19 2016, 3:16 PM · Bug Report (Needs Information), Dashboards
epriestley moved T5317: UX for new administrators on fresh installs from Chad to v2 on the Dashboards board.
Feb 19 2016, 3:15 PM · Dashboards (v2), Phacility
epriestley moved T4883: Customizing the default homepage for all users from Chad to v2 on the Dashboards board.
Feb 19 2016, 3:15 PM · Dashboards (v2)
epriestley moved T5307: UX for taking actions with search results from Lyuba to v2 on the Dashboards board.
Feb 19 2016, 3:15 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
epriestley moved T5315: Remove the "welcome.html" configuration option when Dashboards is available from Evan to v2 on the Dashboards board.
Feb 19 2016, 3:15 PM · Dashboards (v2)
epriestley moved T3583: Fix the Swamp of Suck that is the home page content panel from Evan to v2 on the Dashboards board.
Feb 19 2016, 3:15 PM · Restricted Project, Dashboards (v2)
epriestley created Dashboards (v2).
Feb 19 2016, 3:15 PM
epriestley added a comment to T10387: Create UI for visual (drag and drop) rearranging of task hierarchy.

There's some context and discussion in T4207. Briefly, task dependencies are currently a directed acyclic graph, not a tree, and DAGs don't lend themselves well to visualization or drag-and-drop editing.

Feb 19 2016, 3:14 PM · Feature Request
epriestley added a comment to T5406: Offer read-only copy of a externally hosted repository via Diffusion clone url (https/ssh).

It has been greatly improved.

Feb 19 2016, 3:09 PM · Diffusion (v3)
epriestley added a comment to T5406: Offer read-only copy of a externally hosted repository via Diffusion clone url (https/ssh).

Oh, never mind, I figured it out. :3

Feb 19 2016, 3:06 PM · Diffusion (v3)
epriestley closed T10389: File listing is truncated in repository view as Resolved.

I think this issue was fixed by 58c2141 (Feb 16), which is a little ahead of where you are. You can update to master to pick it up right away, or it should be available in stable in about 24 hours (if you want, you can subscribe to the Changelog page to keep an eye on when we promote to stable).

Feb 19 2016, 2:55 PM · Diffusion, Bug Report
epriestley added a comment to T10389: File listing is truncated in repository view.

Can you either confirm that you're running HEAD of master, or tell me what version of Phabricator are you currently running?

Feb 19 2016, 2:36 PM · Diffusion, Bug Report
epriestley added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

Yes, I'd expect to do this:

Feb 19 2016, 2:26 PM · Dashboards
epriestley updated the task description for T5307: UX for taking actions with search results.
Feb 19 2016, 1:28 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
epriestley added a comment to P1853 InsecureRemarkupGraphvizBlockInterpreter.php.

Sorry -- I'm happy to walk you through the technical details in greater depth at consulting rates (see Consulting) but want to draw a hard line that "not supported" really means "not supported" on this.

Feb 19 2016, 1:20 PM
epriestley updated subscribers of T5406: Offer read-only copy of a externally hosted repository via Diffusion clone url (https/ssh).

@chad Was that just testing something, or a vote for this as a substantial problem?

Feb 19 2016, 1:11 PM · Diffusion (v3)
epriestley added a project to T10385: Diffusion code view doesn't hide blame pane: Diffusion (v3).
Feb 19 2016, 1:09 PM · Diffusion (v3), Mobile
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Feb 19 2016, 1:07 PM
epriestley added a comment to P1853 InsecureRemarkupGraphvizBlockInterpreter.php.

@thuffir, I can't come up with an easy fix for that.

Feb 19 2016, 12:59 PM
epriestley added a comment to T10384: Cannot add/edit workboard columns in a project editable by members.

No problem, and thanks for including all the relevant version information in your report! Let us know if that doesn't fix the issue for you.

Feb 19 2016, 1:35 AM · Workboards, Projects, Bug Report
epriestley closed T10384: Cannot add/edit workboard columns in a project editable by members as Resolved.

This was fixed by 329d036 (Feb 13) which should be available in stable in about 48 hours (or you can update to master before then).

Feb 19 2016, 12:55 AM · Workboards, Projects, Bug Report

Feb 18 2016

epriestley added a comment to T10383: auto link account / require multiple accounts.

A custom dashboard panel (that checks if the user has JIRA linked, gives them a big annoying flashing GIF "LINK YOUR JIRA ACCOUNT!!" button if they don't, and renders nothing if they do) on a custom homepage dashboard might be a similar achievable approach without an unreasonable amount of effort, given the technology of today.

Feb 18 2016, 8:33 PM · Restricted Project, Feature Request
epriestley added a comment to T10264: git clone using http hangs after update.

@dpatou Does reverting both 5e375482 and 8269fd6e fix the issue for you?

Feb 18 2016, 6:20 PM · Bug Report, Diffusion
epriestley moved T4245: Make repository URIs slightly prettier from Backlog to Amazing New Features on the Diffusion (v3) board.
Feb 18 2016, 3:43 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a comment to T10381: Tweak linebreak preservation behavior of PHUIRemarkupView.

(That's admittedly not communicated very clearly by my screenshot.)

Feb 18 2016, 3:12 PM · Remarkup
epriestley added a comment to T10381: Tweak linebreak preservation behavior of PHUIRemarkupView.

Old behavior was this:

Feb 18 2016, 3:11 PM · Remarkup
jonasoberschweiber awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Feb 18 2016, 2:42 PM · Workboards (v3), Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Feb 18 2016, 2:20 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Feb 18 2016, 1:57 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a comment to T10380: Editing subscribers list should allow selection of exact or closest matched username.

Given the system appears to mandate that I select from the list

Feb 18 2016, 1:50 PM · Wikimedia, Maniphest, Bug Report
epriestley added a project to T10381: Tweak linebreak preservation behavior of PHUIRemarkupView: Remarkup.
Feb 18 2016, 1:47 PM · Remarkup
epriestley created T10381: Tweak linebreak preservation behavior of PHUIRemarkupView.
Feb 18 2016, 1:47 PM · Remarkup
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Feb 18 2016, 1:29 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a comment to T4245: Make repository URIs slightly prettier.

D15302 was the change I was most worried about here, and it seems to have been entirely straightforward. I now expect to move forward like this:

Feb 18 2016, 1:16 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Feb 18 2016, 1:11 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a comment to T4245: Make repository URIs slightly prettier.

For repositories with a short name like "codebase", I imagine users would prefer /diffusion/codebase/ over /diffusion/123/ as the canonical URI.

Feb 18 2016, 12:37 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Restricted Differential Revision.
Feb 18 2016, 12:22 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Feb 18 2016, 11:13 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley updated subscribers of T5116: Amazon SES mailer does not allow specifying endpoint.
Feb 18 2016, 11:04 AM · Mail
epriestley merged task T10377: There should be a config setting for Amazon SES host/region into T5116: Amazon SES mailer does not allow specifying endpoint.
Feb 18 2016, 11:04 AM · Bug Report
epriestley added a revision to T10349: Projects v3 Errata: Unknown Object (Differential Revision).
Feb 18 2016, 3:00 AM · Restricted Project, Projects (v3)
epriestley added a comment to T10349: Projects v3 Errata.

We should maybe hide the tags for archived projects on worboard cards, I notice WMF has a lot of this:

Feb 18 2016, 2:54 AM · Restricted Project, Projects (v3)
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Feb 18 2016, 1:21 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Feb 18 2016, 1:15 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Restricted Differential Revision.
Feb 18 2016, 1:06 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Feb 18 2016, 12:46 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a comment to T10375: Support X-Forwarded-For in Access Log.

See also:

Feb 18 2016, 12:11 AM · Feature Request
epriestley added a comment to T10375: Support X-Forwarded-For in Access Log.

Doing this blindly would let clients spoof remote addresses on installs that are not behind load balancers. The current recommendation is to replace REMOTE_ADDR in preamble.php if you trust the connecting device. Here's what we do in the Phacility cluster (although we're in SiteConfig here, not preamble):

Feb 18 2016, 12:10 AM · Feature Request

Feb 17 2016

epriestley added a comment to T9524: Show aggregate subdirectory coverage in Diffusion browse views.

My planned pathway forward here is:

Feb 17 2016, 9:35 PM · Diffusion, Restricted Project
epriestley added a comment to T10349: Projects v3 Errata.

I will report you to the workboard police on T10215 if you keep it up! You better check yourself before you wreck the project roadmap for weeks by derailing it into abuse cleanup tools.

Feb 17 2016, 8:52 PM · Restricted Project, Projects (v3)
epriestley added a comment to T10349: Projects v3 Errata.

I have replaced your dumb 1x1 transparent GIF with a fearsome tyrannosaur.

Feb 17 2016, 8:50 PM · Restricted Project, Projects (v3)
epriestley added a comment to T10286: Design a Milestone Tag.

I really like the look of the inverse tag, although I haven't personally felt too much confusion about milestones vs nonmilestones on project pages.

Feb 17 2016, 8:37 PM · Restricted Project, Design, Projects (v3)
epriestley added a comment to T10349: Projects v3 Errata.

So is there any official/recommended way to work with global milestones?

Feb 17 2016, 8:10 PM · Restricted Project, Projects (v3)