Page MenuHomePhabricator
Create Task
Maniphest T10381

Tweak linebreak preservation behavior of PHUIRemarkupView
Closed, ResolvedPublic
Actions

Description

The recent swap to PHUIRemarkupView changed linebreak preservation of things like form instructions, so stuff like this has a slightly more poetic layout than originally intended:

Screen Shot 2016-02-18 at 5.45.12 AM.png (276×543 px, 36 KB)

The remarkupInstructions() sorts of things shouldn't preserve linebreaks.

Revisions and Commits

rP Phabricator
D15963rP3d3fff4991ab Fix weird remarkup linewrapping on a few instructions forms, plus move toward…

Related Objects

Event Timeline

epriestley created this task.Feb 18 2016, 1:47 PM
epriestley added a project: Remarkup.
chad added a subscriber: chad.Feb 18 2016, 3:09 PM

what did it look like before?

epriestley added a comment.Feb 18 2016, 3:11 PM

Old behavior was this:

Vinyl marfa health goth, brooklyn seitan cray +1. Cronut blog beard distillery slow-carb. Lomo church-key sriracha, quinoa salvia four loko ramps bespoke. Celiac whatever try-hard viral deep v, portland chillwave cred. Humblebrag cred poutine put a bird on it.

New behavior is:

Vinyl marfa health goth, brooklyn seitan cray +1. Cronut blog beard distillery
slow-carb. Lomo church-key sriracha, quinoa salvia four loko ramps bespoke.
Celiac whatever try-hard viral deep v, portland chillwave cred. Humblebrag cred
poutine put a bird on it.

epriestley added a comment.Feb 18 2016, 3:12 PM

(That's admittedly not communicated very clearly by my screenshot.)

epriestley mentioned this in T10903: Customize "open in new window" link behavior for RemarkupEngine.Apr 29 2016, 5:26 PM
epriestley added a revision: D15963: Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues.May 22 2016, 4:59 PM
epriestley closed this task as Resolved by committing rP3d3fff4991ab: Fix weird remarkup linewrapping on a few instructions forms, plus move toward….May 22 2016, 7:23 PM
epriestley added a commit: rP3d3fff4991ab: Fix weird remarkup linewrapping on a few instructions forms, plus move toward….
Herald added a subscriber: eadler. · View Herald TranscriptMay 22 2016, 7:23 PM
Phabricator · Built by Phacility