Page MenuHomePhabricator
Create Task
Maniphest T10396

Remarkup toolbar actions always cause comment box to scroll to bottom
Closed, ResolvedPublic
Actions

Description

This may be a feature but I figured I'd go ahead and file a task anyways.

Steps to reproduce
Paste a whole bunch of text into a remarkup comment box. Highlight some text at the top that you would like to see bolded and click the B (or any other action) toolbar action. See the window get scrolled to the bottom and you losing place of what you were doing.

I've reproduced this here on secure and on my own install.

Expected Behavior
The window does not scroll and I can continue editing.

This is really minor and I usually I don't even use the toolbar actions but I was feeling extra lazy today.

Revisions and Commits

rP Phabricator
D15313rP7b1b146620b5 Save, then restore scroll position in Chrome textareas on remarkup assist

Event Timeline

ftdysa created this task.Feb 19 2016, 7:56 PM
epriestley added a subscriber: epriestley.Feb 19 2016, 8:09 PM

On OSX, I can't reproduce this in Safari or Firefox, but it does reproduce in Chrome. Are you also using Chrome?

ftdysa added a comment.Feb 19 2016, 8:24 PM

Yep, Chrome on Kubuntu.

epriestley added a comment.Feb 19 2016, 9:17 PM

Thanks, I'll see if I can figure out what's going on in Chrome.

chad added projects: Google Chrome, Remarkup.Feb 19 2016, 9:25 PM
ftdysa added a comment.Feb 19 2016, 10:19 PM

So I looked into this and it is the call to area.focus() in the setSelectionRange method in https://secure.phabricator.com/diffusion/P/browse/master/webroot/rsrc/js/core/TextAreaUtils.js (unsure what line, my view of this file is plaintext here) that causes the scrolling. I removed this line and it seemed to have the expected behavior but who knows what other problems removing it may cause.

epriestley added a revision: D15313: Save, then restore scroll position in Chrome textareas on remarkup assist.Feb 19 2016, 10:49 PM
epriestley added a comment.Feb 19 2016, 10:55 PM

Yeah, I came to approximately the same conclusion. Save + restore on the scroll position appears to be a complete fix as far as I can tell.

epriestley closed this task as Resolved by committing rP7b1b146620b5: Save, then restore scroll position in Chrome textareas on remarkup assist.Feb 19 2016, 10:55 PM
epriestley added a commit: rP7b1b146620b5: Save, then restore scroll position in Chrome textareas on remarkup assist.
ftdysa added a comment.Feb 20 2016, 12:15 AM

Ah cool, good to know. Thanks for the quick fix!

Phabricator · Built by Phacility