Page MenuHomePhabricator
Feed Advanced Search

Dec 5 2014

richardvanvelzen added a comment to T6687: differential's `date time` space is narrow a bit..

You can check if the optimizelegibility is indeed the cause by disabling it via the web inspector. It is the issue for me, at least.

Dec 5 2014, 8:41 AM · Differential
richardvanvelzen created T6699: Inline comments on a revision don't appear in the timeline.
Dec 5 2014, 8:39 AM · Differential

Dec 4 2014

richardvanvelzen added a comment to T6687: differential's `date time` space is narrow a bit..

This is due to a bug in Chrome (most likely) which makes text-rendering: optimizeLegibility behave very strangely.

Dec 4 2014, 12:00 PM · Differential

Dec 3 2014

richardvanvelzen added a comment to T6675: Profile GC costs in XHProf.

Qafoolabs mentions a "proposed timing API" in a pull request. I can't seem to find anything about anything having been proposed, but it might be worthwhile to keep that in mind.

Dec 3 2014, 11:36 AM · XHProf

Dec 2 2014

richardvanvelzen added a comment to T6675: Profile GC costs in XHProf.

I do see that gc_runs and collected are available (via GC_G(...)) unconditionally? It's not much, but it's more than is available now.

Dec 2 2014, 7:03 PM · XHProf
richardvanvelzen added a comment to T6675: Profile GC costs in XHProf.

Pretty sure you've been across the same path as I was, but I want to share my findings just in case someone can find a way to use it:

Dec 2 2014, 6:27 PM · XHProf

Nov 19 2014

richardvanvelzen added a comment to T6592: Differential history mangles bullet numbering in quoted email forward.

Ah, no - I was wrong. It's because of the ---- line from the quoted section (- indicates a list item too). Observe:

> --
> Hello
> 1. One
> 2. Two

Hello

  1. One
  2. Two
Nov 19 2014, 7:31 PM · Remarkup
richardvanvelzen added a comment to T6592: Differential history mangles bullet numbering in quoted email forward.

I'm guessing that this is a side-effect from rPHU0db4b149c4e0. Strange though. :/

Nov 19 2014, 7:21 PM · Remarkup

Nov 7 2014

anton.vladimirov awarded T4139: Add support for desktop notifications a Like token.
Nov 7 2014, 10:56 PM · Aphlict

Nov 6 2014

richardvanvelzen added a comment to T6348: Windows 7: arc diff --nolint --nounit not working.

Specific link to the source, for future reference: http://git.php.net/?p=php-src.git;a=blob;f=ext/standard/exec.c;h=6106fe2c86bb687979e36e2070a99283cc0a0878;hb=HEAD#l365

Nov 6 2014, 4:03 PM · Arcanist, Windows
richardvanvelzen added a comment to T6112: Arcanist can not upload binaries when use Mercurial on Windows.

See T6348 for details on why this happens. escapeshellarg under Windows removed % signs.

Nov 6 2014, 12:54 PM · Mercurial, Arcanist

Nov 5 2014

richardvanvelzen added a comment to T6473: Provide Arcanist option to disable ANSI colours / Disable ANSI colours on Windows.

I believe the check for TERM should be fine. However, for reference, the Symfony framework uses a slightly simpler check - and will probably behave saner in most of these cases to do go wrong.

Nov 5 2014, 10:02 AM · libphutil, Arcanist

Oct 23 2014

richardvanvelzen updated the diff for D10743: Remove history support for console prompts on Windows.

Now with lint and unit tests running

Oct 23 2014, 7:59 PM
richardvanvelzen added a task to D10743: Remove history support for console prompts on Windows: T6348: Windows 7: arc diff --nolint --nounit not working.
Oct 23 2014, 7:59 PM
richardvanvelzen added a revision to T6348: Windows 7: arc diff --nolint --nounit not working: D10743: Remove history support for console prompts on Windows.
Oct 23 2014, 7:59 PM · Arcanist, Windows
richardvanvelzen added a comment to T6348: Windows 7: arc diff --nolint --nounit not working.

Basically, double quotes disappear when passed through escapeshellarg. The command for history basically becomes:

Oct 23 2014, 7:54 PM · Arcanist, Windows
richardvanvelzen claimed T6348: Windows 7: arc diff --nolint --nounit not working.

The history support is useful. I might be able to find out what's happening.

Oct 23 2014, 7:40 PM · Arcanist, Windows
richardvanvelzen retitled D10742: Support arbitrary start numbers for ordered lists in remarkup from to Support arbitrary start numbers for ordered lists in remarkup.
Oct 23 2014, 7:24 PM
richardvanvelzen added a revision to T6377: [remarkup] Allow specifying start number of an ordered list: D10742: Support arbitrary start numbers for ordered lists in remarkup.
Oct 23 2014, 7:24 PM · Remarkup

Oct 16 2014

richardvanvelzen renamed T6331: Closing a revision via a commit generates superfluous "mention" in Task from Closing a revision via a commit generates superfluous "mention" to Closing a revision via a commit generates superfluous "mention" in Task.
Oct 16 2014, 10:07 PM · Transactions, Diffusion
richardvanvelzen added a comment to T6331: Closing a revision via a commit generates superfluous "mention" in Task.

Oh, I notice I forgot to mention it was about a task :/ My apologies for
that.

Oct 16 2014, 4:05 PM · Transactions, Diffusion
richardvanvelzen added a comment to T6331: Closing a revision via a commit generates superfluous "mention" in Task.

I've now seen the same issue over several commits, leading me to believe
that it's not a fluke.

Oct 16 2014, 2:52 PM · Transactions, Diffusion
richardvanvelzen updated the task description for T6331: Closing a revision via a commit generates superfluous "mention" in Task.
Oct 16 2014, 1:12 PM · Transactions, Diffusion
richardvanvelzen created T6331: Closing a revision via a commit generates superfluous "mention" in Task.
Oct 16 2014, 1:12 PM · Transactions, Diffusion

Oct 4 2014

richardvanvelzen added a comment to T6243: Detect MySQL when ONLY_FULL_GROUP_BY is enabled.

It's not very rare, it's just that MySQL (by default) will allow non-standard behavior for the GROUP BY clause.

Oct 4 2014, 3:27 PM · Support Impact

Sep 22 2014

richardvanvelzen added a comment to T6154: XHPAST fails to recognise some syntax errors.

A related case with try..catch..finally (see D10337) works in the same way as @epriestley described. However, in that case it's easy to fix. This may be less trivial, but still worth fixing.

Sep 22 2014, 8:42 PM · XHPAST

Sep 12 2014

richardvanvelzen added a comment to T5368: Update page title to display notification count.

Having the favicon also change would be very cool. I usually have my phabricator tab pinned, which means that I don't see the title.

Sep 12 2014, 10:08 AM · Badge Awarded, Aphlict

Sep 2 2014

richardvanvelzen added a comment to T6003: Support non-Latin scripts in usernames.
  • However, I'm not sure if there's an agreed-upon or standard way to canonicalize combining marks.
Sep 2 2014, 6:56 AM · Wikimedia, People

Aug 22 2014

richardvanvelzen added a comment to D10337: Correctly support try..catch..finally in xhpast.

Note that the token constant values have changed because I built with Bison 3.0.2 instead of 2.7

Aug 22 2014, 2:08 PM
richardvanvelzen retitled D10337: Correctly support try..catch..finally in xhpast from to Correctly support try..catch..finally in xhpast.
Aug 22 2014, 12:50 PM
richardvanvelzen added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D10337: Correctly support try..catch..finally in xhpast.
Aug 22 2014, 12:50 PM · XHPAST

Aug 21 2014

richardvanvelzen added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

@epriestley: could you take a look at the comment above? I'd push out a diff but for some reason the values of the tokens change when I rebuild xhpast.

Aug 21 2014, 9:57 AM · XHPAST

Jul 30 2014

richardvanvelzen added a comment to T5745: Unable to post only inline comments to an audit.

Verified to work, thanks!

Jul 30 2014, 6:21 PM · Phabricator, Audit
richardvanvelzen created T5745: Unable to post only inline comments to an audit.
Jul 30 2014, 11:27 AM · Phabricator, Audit

Jul 18 2014

richardvanvelzen added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

Catches are optional when you have a while. This small diff fixes that:

Jul 18 2014, 7:27 AM · XHPAST

Jul 15 2014

maroux awarded T4139: Add support for desktop notifications a Like token.
Jul 15 2014, 1:55 AM · Aphlict

Jul 13 2014

richardvanvelzen accepted D9918: Fix issue in Mercurial repos with duplicate branch heads.

Thanks!

Jul 13 2014, 1:49 PM
richardvanvelzen updated the task description for T5613: Duplicate branch name causes diffusion to crash.
Jul 13 2014, 11:50 AM · Diffusion, Phabricator
richardvanvelzen assigned T5613: Duplicate branch name causes diffusion to crash to epriestley.
Jul 13 2014, 11:50 AM · Diffusion, Phabricator
richardvanvelzen created T5613: Duplicate branch name causes diffusion to crash.
Jul 13 2014, 11:44 AM · Diffusion, Phabricator

Jul 3 2014

richardvanvelzen added a comment to D9807: [harbormaster/run-build-plan] Implement build step for running another build plan.

Is this warning bugged because I'm using braces in the case statement? It doesn't occur for the other fallthrough statement at the end of the build step.

The braces aren't necessary and probably cause the message.

Jul 3 2014, 11:37 AM · Harbormaster

Jul 2 2014

richardvanvelzen updated the diff for D9797: Refactor author handling in the Mercurial API.

Debug-less

Jul 2 2014, 3:07 PM
richardvanvelzen retitled D9797: Refactor author handling in the Mercurial API from to Refactor author handling in the Mercurial API.
Jul 2 2014, 3:06 PM

Jun 25 2014

richardvanvelzen added a comment to D9723: `ArcanistChmodLinter` should not allow certain MIME types to be executable.

You could presumably also use identify from ImageMagick. Probably overkill though.

Jun 25 2014, 5:54 PM

Jun 24 2014

richardvanvelzen added a comment to D9711: Fix Differential DashHeaders.

suchwow

Jun 24 2014, 10:15 PM
richardvanvelzen created T5465: Differential workboard panel is not pretty.
Jun 24 2014, 7:15 PM · Dashboards

Jun 23 2014

richardvanvelzen added a comment to D9692: Make `arc feature` work consistently with and without branches/bookmarks.

This could of course break if people depend on arc feature with no branches/bookmarks having exit code 1.

Jun 23 2014, 5:44 PM
richardvanvelzen retitled D9692: Make `arc feature` work consistently with and without branches/bookmarks from to Make `arc feature` work consistently with and without branches/bookmarks.
Jun 23 2014, 5:39 PM
richardvanvelzen added a comment to T5431: Arcanist User Guide: Windows: wrong command line key for Sublime Text.

Well, I seem to remember it wrong; when I close the new-commit file in Sublime Text now, arc continues as it should.

Jun 23 2014, 5:34 PM · Arcanist, Windows
richardvanvelzen added a comment to T5431: Arcanist User Guide: Windows: wrong command line key for Sublime Text.

If I recall correctly, I had the same kind-of issue. The file opened in an already opened instance, and arc would only continue if I closed the entire instance. Adding -n helped in that only the new instance had to be closed.

Jun 23 2014, 5:17 PM · Arcanist, Windows

Jun 17 2014

richardvanvelzen retitled D9605: Don't parse mercurial usernames without email address as an email address from to Don't parse mercurial usernames without email address as an email address.
Jun 17 2014, 6:32 PM
richardvanvelzen edited this Maniphest Task.
Jun 17 2014, 12:13 PM · XHPAST, Arcanist
richardvanvelzen updated the diff for D9585: Let `arc liberate` throw on unsupported PHP features.

Use a simpler grammatical construct for the error message

Jun 17 2014, 12:06 PM
richardvanvelzen added a comment to D9585: Let `arc liberate` throw on unsupported PHP features.

I don't know, it was pretty late and I just pushed it out hoping for feedback. :-)

Jun 17 2014, 12:05 PM
richardvanvelzen edited this Maniphest Task.
Jun 17 2014, 11:53 AM · Arcanist
richardvanvelzen closed T5086: "arc feature" and "arc bookmark" do not handle 'no bookmarks' correctly as Resolved.

Closed by commit rARC3201239e85ea.

Jun 17 2014, 11:53 AM · Arcanist

Jun 16 2014

joshuaspence awarded D9584: Let `phutil_rebuild_map` show a progress bar a Haypence token.
Jun 16 2014, 11:45 PM
richardvanvelzen edited this Maniphest Task.
Jun 16 2014, 10:54 PM · Arcanist
richardvanvelzen updated D9588: Correctly recognize "no bookmarks" for Mercurial.
Jun 16 2014, 10:54 PM
richardvanvelzen retitled D9588: Correctly recognize "no bookmarks" for Mercurial from to Correctly recognize "no bookmarks" for Mercurial.
Jun 16 2014, 10:53 PM
richardvanvelzen retitled D9587: Let phutil_rebuild_map **really** be quiet from to Let phutil_rebuild_map **really** be quiet.
Jun 16 2014, 10:48 PM
richardvanvelzen retitled D9586: Allow PhutilConsoleProgressBar to be quiet from to Allow PhutilConsoleProgressBar to be quiet.
Jun 16 2014, 10:45 PM
richardvanvelzen added a comment to D9585: Let `arc liberate` throw on unsupported PHP features.

This probably needs quite some work.

Jun 16 2014, 10:05 PM
richardvanvelzen retitled D9585: Let `arc liberate` throw on unsupported PHP features from to Let `arc liberate` throw on unsupported PHP features.
Jun 16 2014, 10:05 PM
richardvanvelzen edited this Maniphest Task.
Jun 16 2014, 10:05 PM · XHPAST, Arcanist
richardvanvelzen retitled D9584: Let `phutil_rebuild_map` show a progress bar from to Let `phutil_rebuild_map` show a progress bar.
Jun 16 2014, 10:02 PM
richardvanvelzen accepted D9581: Rebuild `xhpast.exe` with static linkage.

It's crazy, but it does work.

Jun 16 2014, 8:36 PM

Jun 15 2014

richardvanvelzen added a comment to D9560: Support ansicon for ANSI support on Windows.

Taken on Windows running cmd.exe:

Jun 15 2014, 8:36 PM
richardvanvelzen retitled D9560: Support ansicon for ANSI support on Windows from to Support ansicon for ANSI support on Windows.
Jun 15 2014, 8:35 PM
richardvanvelzen added a comment to D9378: Update xhpast.exe.

It seems that this breaks when the user doesn't have MingW installed (which I don't have anymore - just did a reinstall).

Jun 15 2014, 3:30 PM

Jun 12 2014

richardvanvelzen updated the diff for D9504: Support interactive editing with Windows editors.

Not an actual update, just running with sublime text as well to be sure it's handled correctly.

Jun 12 2014, 9:23 PM
richardvanvelzen added a comment to D9378: Update xhpast.exe.

It's Windows, not that great a surprise actually...

Jun 12 2014, 8:42 PM
richardvanvelzen accepted D9378: Update xhpast.exe.

This now suddenly runs cleanly on my machine. Probably thanks to the reboot I just did. :/

Jun 12 2014, 8:35 PM
richardvanvelzen retitled D9504: Support interactive editing with Windows editors from to Support interactive editing with Windows editors.
Jun 12 2014, 8:27 PM

Jun 10 2014

richardvanvelzen updated the diff for D9450: Make retrieving parents for mercurial commits work consistently across platforms.

Separate out the template parameter

Jun 10 2014, 5:19 PM
richardvanvelzen added a comment to D9450: Make retrieving parents for mercurial commits work consistently across platforms.

This time I was smart enough to test it with a merge commit. The result looked okay to me.

Jun 10 2014, 4:56 PM
richardvanvelzen updated the diff for D9450: Make retrieving parents for mercurial commits work consistently across platforms.

Don't use the actual newline since Windows doesn't support it.

Jun 10 2014, 4:53 PM
richardvanvelzen added a comment to D9450: Make retrieving parents for mercurial commits work consistently across platforms.

Windows is so awesome it doesn't need newlines. Oh wait, it sucks!

Jun 10 2014, 3:07 PM
richardvanvelzen added a comment to D9450: Make retrieving parents for mercurial commits work consistently across platforms.

That should be handled by csprintf, right?

Jun 10 2014, 12:07 PM
richardvanvelzen retitled D9450: Make retrieving parents for mercurial commits work consistently across platforms from to Make retrieving parents for mercurial commits work consistently across platforms.
Jun 10 2014, 11:11 AM

Jun 9 2014

richardvanvelzen added a comment to D9378: Update xhpast.exe.

One step I actually did differently was running mingw32-make in my regular cmd. You only have to follow the steps here and it works just fine.

Jun 9 2014, 6:33 PM

Jun 5 2014

richardvanvelzen closed T4395: ArcanistPhpcsLinter issue with msdos and cygwin as Resolved.

Closed by commit rPHU3fe4daa19d2c.

Jun 5 2014, 4:41 PM · Arcanist, Windows
richardvanvelzen edited this Maniphest Task.
Jun 5 2014, 4:41 PM · Arcanist, Windows
richardvanvelzen updated D9348: Fix lint when working on windows.
Jun 5 2014, 5:53 AM
richardvanvelzen updated the diff for D9348: Fix lint when working on windows.

Remove the rebuild xhpast.exe and expand the comment a bit.

Jun 5 2014, 5:52 AM
richardvanvelzen added a comment to D9378: Update xhpast.exe.

The steps pretty much seem the same as what I have experienced.

Jun 5 2014, 5:31 AM

Jun 4 2014

richardvanvelzen added a comment to D9376: Fix undefinded $changesets when submitting inline comments in Differential.

This very much seems okay to me.

Jun 4 2014, 9:00 PM
richardvanvelzen added a comment to D9373: Really pin "applications" to the bottom of the menu, for serious.

minioncheer

Jun 4 2014, 7:49 PM
richardvanvelzen edited P1170 trace.
Jun 4 2014, 7:41 PM

Jun 2 2014

richardvanvelzen edited this Maniphest Task.
Jun 2 2014, 8:59 PM · XHPAST, Windows
richardvanvelzen edited this Maniphest Task.
Jun 2 2014, 8:59 PM · Arcanist, Windows
richardvanvelzen retitled D9348: Fix lint when working on windows from Fixes T4395. Ref T4592. to Fix lint when working on windows.
Jun 2 2014, 8:59 PM
richardvanvelzen retitled D9348: Fix lint when working on windows from to Fixes T4395. Ref T4592..
Jun 2 2014, 8:59 PM

May 12 2014

richardvanvelzen added a comment to T4395: ArcanistPhpcsLinter issue with msdos and cygwin.

The fix @epriestley mentioned, indeed.

May 12 2014, 6:33 PM · Arcanist, Windows

May 11 2014

richardvanvelzen added a comment to T4395: ArcanistPhpcsLinter issue with msdos and cygwin.

I can confirm that your fix makes the problem go away at my Windows pc. Nice :)

May 11 2014, 8:24 PM · Arcanist, Windows

May 1 2014

richardvanvelzen created T4936: Phame is not accessible on a custom domain without `policy.allow-public`.
May 1 2014, 12:54 PM · Phame

Apr 23 2014

nicereddy awarded T4139: Add support for desktop notifications a Like token.
Apr 23 2014, 11:57 PM · Aphlict

Feb 20 2014

richardvanvelzen assigned T4466: Custom fields in maniphest get updated even when they haven't changed to epriestley.
Feb 20 2014, 10:10 PM · Custom Fields

Feb 7 2014

richardvanvelzen added a comment to T4387: Investigate replacing uses of `hg grep`/`hg manifest` with `hg locate`.

The hg grep search doesn't seem to be too slow. Also, by replacing it with a hg locate command you lose the line numbers which seems to be a shame.

Feb 7 2014, 12:22 PM · Diffusion
richardvanvelzen edited this Maniphest Task.
Feb 7 2014, 11:44 AM · Diffusion