Page MenuHomePhabricator
Create Task
Maniphest T5745

Unable to post only inline comments to an audit
Closed, ResolvedPublic
Actions

Description

When trying to post a comment consisting of only inline comments to an audit, we get a fatal: Call to a member function getAction() on a non-object.

Traces from the log:

PHP Warning:  Uncaught exception 'RuntimeException' with message 'Undefined variable: comment' in /***/libphutil/src/error/PhutilErrorHandler.php:210
Stack trace:
#0 /***/phabricator/src/applications/audit/editor/PhabricatorAuditCommentEditor.php(77): PhutilErrorHandler::handleError(8, 'Undefined varia...', '/***/p...', 77, Array)
#1 /***/phabricator/src/applications/audit/controller/PhabricatorAuditAddCommentController.php(66): PhabricatorAuditCommentEditor->addComments(Array)
#2 /***/phabricator/webroot/index.php(95): PhabricatorAuditAddCommentController->processRequest()
#3 {main}
  thrown in /***/libphutil/src/error/PhutilErrorHandler.php on line 210

PHP Fatal error:  Call to a member function getAction() on a non-object in /***/phabricator/src/applications/audit/editor/PhabricatorAuditCommentEditor.php on line 77

Note: when adding regular comment text, it does work.

Revisions and Commits

rP Phabricator
D10078rP98c2ad38e564 Fix audit commenting where there are only inlines

Related Objects
Search...

StatusAssignedTask
Restricted Maniphest Task
 ResolvedepriestleyT1315 Phacility Launch Status
 ResolvedepriestleyT2795 Phacility (Mid Priority)
 ResolvedchadT2637 Unbeta Pholio
Restricted Maniphest Task
 ResolvedepriestleyT5644 Add controls to prevent `pygmentize` from saturating system resources
 ResolvedepriestleyT5179 Unearth Differential rendering technical debt
Restricted Maniphest Task
 ResolvedepriestleyT4264 Implement Repo/Project Herald rules to provide a middle ground between personal and global rules
 ResolvedepriestleyT5595 Allow all applications to filter results by project
 ResolvedepriestleyT2628 Add project tags to Pholio, Ponder, Differential, and other applications
 Resolved20after4T5685 Allow file data to be inaccessible, not undiscoverable
 ResolvedepriestleyT4589 Fully implement granular file permissions and upload defaults
 ResolvedchadT12824 Redesign Diffusion
 OpenNoneT929 Allow two arbitrary revisions to be compared in Diffusion
 DuplicateepriestleyT5654 Show more context for inline comments in Differential timeline
 WontfixepriestleyT5742 Add commentor column to "Revision Update History" table
Restricted Maniphest Task
 ResolvedepriestleyT7358 When Replying to an Inline Comment, provide original context in email?
 ResolvedepriestleyT1460 Add "Done" link to an inline comment
 ResolvedepriestleyT3956 audit updates don't trigger notifications
 ResolvedbtrahanT2497 Audit workflow email notifications cannot be configured
 ResolvedepriestleyT2393 Adds a "Needs Verification" state to Audits
 ResolvedNoneT5872 Include commit author context in audit emails
 DuplicateNoneT4484 Show Herald effects on objects in object transaction logs
 ResolvedbtrahanT4896 Move Audit to ApplicationTransactions
 ResolvedbtrahanT5745 Unable to post only inline comments to an audit

Event Timeline

richardvanvelzen created this task.Jul 30 2014, 11:27 AM
richardvanvelzen assigned this task to epriestley.
richardvanvelzen raised the priority of this task from to High.
richardvanvelzen updated the task description. (Show Details)
richardvanvelzen added projects: Audit, Phabricator.
richardvanvelzen added a subscriber: richardvanvelzen.
btrahan claimed this task.Jul 30 2014, 5:29 PM
btrahan added a subscriber: epriestley.

I'll take a gander.

epriestley added a comment.Jul 30 2014, 5:36 PM

This is probably something obvious/derpy, this code just got hit by a series of transitional-hack-arounds for T4896 on its way to glorious ApplicationTransactions.

btrahan added a revision: D10078: Fix audit commenting where there are only inlines.Jul 30 2014, 5:43 PM
btrahan closed this task as Resolved.Jul 30 2014, 5:47 PM
btrahan added a commit: rP98c2ad38e564: Fix audit commenting where there are only inlines.

Closed by commit rP98c2ad38e564.

richardvanvelzen added a comment.Jul 30 2014, 6:21 PM

Verified to work, thanks!

btrahan added a comment.Jul 30 2014, 6:26 PM

thanks for the report! =D

Phabricator · Built by Phacility