Page MenuHomePhabricator

Unable to post only inline comments to an audit
Closed, ResolvedPublic

Description

When trying to post a comment consisting of only inline comments to an audit, we get a fatal: Call to a member function getAction() on a non-object.

Traces from the log:

PHP Warning:  Uncaught exception 'RuntimeException' with message 'Undefined variable: comment' in /***/libphutil/src/error/PhutilErrorHandler.php:210
Stack trace:
#0 /***/phabricator/src/applications/audit/editor/PhabricatorAuditCommentEditor.php(77): PhutilErrorHandler::handleError(8, 'Undefined varia...', '/***/p...', 77, Array)
#1 /***/phabricator/src/applications/audit/controller/PhabricatorAuditAddCommentController.php(66): PhabricatorAuditCommentEditor->addComments(Array)
#2 /***/phabricator/webroot/index.php(95): PhabricatorAuditAddCommentController->processRequest()
#3 {main}
  thrown in /***/libphutil/src/error/PhutilErrorHandler.php on line 210

PHP Fatal error:  Call to a member function getAction() on a non-object in /***/phabricator/src/applications/audit/editor/PhabricatorAuditCommentEditor.php on line 77

Note: when adding regular comment text, it does work.

Related Objects

StatusAssignedTask
Resolvedepriestley
Resolvedepriestley
Resolvedchad
Resolvedepriestley
Resolvedepriestley
Resolvedepriestley
Resolvedepriestley
Resolvedepriestley
Resolved20after4
Resolvedepriestley
Resolvedchad
OpenNone
Duplicateepriestley
Wontfixepriestley
Resolvedepriestley
Resolvedepriestley
Resolvedepriestley
Resolvedbtrahan
Resolvedepriestley
ResolvedNone
DuplicateNone
Resolvedbtrahan
Resolvedbtrahan

Event Timeline

richardvanvelzen assigned this task to epriestley.
richardvanvelzen raised the priority of this task from to High.
richardvanvelzen updated the task description. (Show Details)
richardvanvelzen added a subscriber: richardvanvelzen.
btrahan claimed this task.Jul 30 2014, 5:29 PM
btrahan added a subscriber: epriestley.

I'll take a gander.

This is probably something obvious/derpy, this code just got hit by a series of transitional-hack-arounds for T4896 on its way to glorious ApplicationTransactions.

Verified to work, thanks!

thanks for the report! =D