Paths

Table of Contentst

Fix undefinded $changesets when submitting inline comments in Differential
ClosedPublic
Actions

Authored by epriestley on Jun 4 2014, 8:55 PM.

Tags

None

Referenced Files

	F15413391: D9376.id22347.diff
	Wed, Mar 19, 6:24 PM

	F15403180: D9376.id.diff
	Tue, Mar 18, 2:08 AM

	F15398085: D9376.id22347.diff
	Sun, Mar 16, 11:15 PM

	F15380993: D9376.id22347.diff
	Fri, Mar 14, 5:22 AM

	F15375871: D9376.id22347.diff
	Thu, Mar 13, 12:25 AM

	F15375870: D9376.id22358.diff
	Thu, Mar 13, 12:25 AM

	F15375790: D9376.id.diff
	Thu, Mar 13, 12:15 AM

	F15375749: D9376.diff
	Wed, Mar 12, 11:59 PM

View All Files

Subscribers

epriestley

richardvanvelzen

Details

Reviewers

chad

Maniphest Tasks

T5262: Undefined `$changesets` when adding inline comment

Commits

Restricted Diffusion Commit
rPba2ce8a5ca1a: Fix undefinded $changesets when submitting inline comments in Differential

Summary

Fixes T5262. This branch is overzealous, and causes us to fail to load changeses if metamta.differential.unified-comment-context is off. It was on for me locally for testing, which is why I missed this.

Test Plan

No more exception.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22347.Jun 4 2014, 8:55 PM

epriestley retitled this revision from to Fix undefinded $changesets when submitting inline comments in Differential.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T5262: Undefined `$changesets` when adding inline comment.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 4 2014, 8:55 PM

Harbormaster completed remote builds in B849: Diff 22347.Jun 4 2014, 8:56 PM

This very much seems okay to me.

chad accepted this revision.Jun 4 2014, 11:11 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 4 2014, 11:11 PM

Closed by commit rPba2ce8a5ca1a (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

17 lines

Diff 22358

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Fix undefinded $changesets when submitting inline comments in DifferentialClosedPublicActions