Fix undefinded $changesets when submitting inline comments in Differential
ClosedPublic
Actions

Authored by epriestley on Jun 4 2014, 8:55 PM.

Details

Reviewers

chad

Maniphest Tasks

T5262: Undefined `$changesets` when adding inline comment

Commits

Restricted Diffusion Commit
rPba2ce8a5ca1a: Fix undefinded $changesets when submitting inline comments in Differential

Summary

Fixes T5262. This branch is overzealous, and causes us to fail to load changeses if metamta.differential.unified-comment-context is off. It was on for me locally for testing, which is why I missed this.

Test Plan

No more exception.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22347.Jun 4 2014, 8:55 PM

epriestley retitled this revision from to Fix undefinded $changesets when submitting inline comments in Differential.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T5262: Undefined `$changesets` when adding inline comment.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 4 2014, 8:55 PM

Harbormaster completed remote builds in B849: Diff 22347.Jun 4 2014, 8:56 PM

This very much seems okay to me.

chad accepted this revision.Jun 4 2014, 11:11 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 4 2014, 11:11 PM

Closed by commit rPba2ce8a5ca1a (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

17 lines

Diff 22358

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Fix undefinded $changesets when submitting inline comments in DifferentialClosedPublicActions