Page MenuHomePhabricator
Differential D9378

Update xhpast.exe
ClosedPublic
Actions

Authored by epriestley on Jun 4 2014, 10:10 PM.
Tags
None
Referenced Files
F14058971: D9378.diff
Sun, Nov 17, 4:17 PM
F14046391: D9378.diff
Wed, Nov 13, 8:37 PM
F14036461: D9378.diff
Sun, Nov 10, 10:19 AM
F14032323: D9378.diff
Sat, Nov 9, 2:04 PM
F13998298: D9378.diff
Thu, Oct 24, 8:43 AM
F13992819: D9378.diff
Tue, Oct 22, 7:00 PM
F13988103: D9378.id.diff
Mon, Oct 21, 1:08 PM
Unknown Object (File)
Sep 25 2024, 11:27 AM
View All Files
Subscribers
epriestley

Details

Reviewers
richardvanvelzen
Maniphest Tasks
T4592: Use mingw to rebuild xhpast.exe on Windows
Commits
rPHUa19fc8fd2f3e: Update xhpast.exe
Summary

Fixes T4592. I think I got this working. Rough steps were:

  • Install mingw
  • Install git + git bash
  • Using mingw shell only, run build script
  • Oh you have to muck with PATH a lot
  • why is it hanging
  • I wish I could paste
  • this looks like a .exe
Test Plan

???

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22350.Jun 4 2014, 10:10 PM
epriestley retitled this revision from to Update xhpast.exe.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: richardvanvelzen.
epriestley added a task: T4592: Use mingw to rebuild xhpast.exe on Windows.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 4 2014, 10:10 PM
Harbormaster completed remote builds in B852: Diff 22350.Jun 4 2014, 10:11 PM
richardvanvelzen edited edge metadata.Jun 5 2014, 5:31 AM

The steps pretty much seem the same as what I have experienced.

However, I just patched this but for some reason .\src\parser\xhpast\bin\xhpast.exe -v doesn't give me anything. :(

epriestley planned changes to this revision.Jun 5 2014, 4:40 PM

I probably did something wrong, let me see if I can figure out what's up.

richardvanvelzen added a comment.Jun 9 2014, 6:33 PM

One step I actually did differently was running mingw32-make in my regular cmd. You only have to follow the steps here and it works just fine.

richardvanvelzen accepted this revision.Jun 12 2014, 8:35 PM
richardvanvelzen edited edge metadata.

This now suddenly runs cleanly on my machine. Probably thanks to the reboot I just did. :/

epriestley added a comment.Jun 12 2014, 8:35 PM

uhhh disconcerting

richardvanvelzen added a comment.Jun 12 2014, 8:42 PM

It's Windows, not that great a surprise actually...

epriestley closed this revision.Jun 13 2014, 2:55 PM
epriestley updated this revision to Diff 22798.

Closed by commit rPHUa19fc8fd2f3e (authored by @epriestley).

richardvanvelzen added a comment.EditedJun 15 2014, 3:30 PM

It seems that this breaks when the user doesn't have MingW installed (which I don't have anymore - just did a reinstall).

According to this stackoverflow answer, this can be resolved by adding -static-libgcc -static-libstdc++ to the compiler flags.

epriestley added a comment.Jun 15 2014, 4:00 PM

Ah, thanks! I'll get this rebuilt.

Revision Contents
Changeset List

PathSize
3 lines
src/
parser/
xhpast/
bin/

Diff 22798

View Options

.gitignore

Loading...
View Options

src/parser/xhpast/bin/xhpast.exe

Loading...
Phabricator · Built by Phacility