Page MenuHomePhabricator
Create Task
Maniphest T4387

Investigate replacing uses of `hg grep`/`hg manifest` with `hg locate`
Closed, ResolvedPublic
Actions

Description

We currently use hg manifest and hg grep to list and locate files, but these are potentially much less efficient than using hg locate. Particularly:

RichardJ: hg locate "set:grep(lemons) and not binary()" --rev . may be an alternative

The hg manifest replacements are probably straightforward. We also get a --print0 flag out of this.

Revisions and Commits

Restricted Differential Revision
Restricted Differential RevisionRestricted Diffusion Commit

Related Objects

Event Timeline

epriestley created this task.Feb 6 2014, 10:08 PM
epriestley raised the priority of this task from to Low.
epriestley updated the task description. (Show Details)
epriestley added a project: Diffusion.
epriestley added subscribers: epriestley, asherkin, richardvanvelzen.
richardvanvelzen edited this Maniphest Task.Feb 7 2014, 11:44 AM
richardvanvelzen added a comment.Feb 7 2014, 12:22 PM

The hg grep search doesn't seem to be too slow. Also, by replacing it with a hg locate command you lose the line numbers which seems to be a shame.

epriestley assigned this task to btrahan.Aug 25 2014, 3:27 AM
  • It looks like DiffusionQueryPathsConduitAPIMethod has another hg manifest call, which we should switch over.
  • We can leave the hg grep calls, per comment above.
  • You could maybe refactor both hg manifest calls into a DiffusionLowLevelMercurialPathsQuery or something, possibly, if sharing the code otherwise is a pain.
btrahan added a revision: Restricted Differential Revision.Aug 28 2014, 7:14 PM
btrahan closed this task as Resolved.Aug 28 2014, 8:05 PM
btrahan added a commit: Restricted Diffusion Commit.

Closed by commit rPd1936711a077.

epriestley mentioned this in T7375: Replace `hg locate` with `hg files` if `hg` is 3.2 or newer.Feb 25 2015, 4:13 PM
Phabricator · Built by Phacility