Page MenuHomePhabricator
Differential D9348

Fix lint when working on windows
ClosedPublic
Actions

Authored by richardvanvelzen on Jun 2 2014, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 9:32 AM
Unknown Object (File)
Fri, May 3, 9:32 AM
Unknown Object (File)
Fri, May 3, 6:49 AM
Unknown Object (File)
Tue, Apr 30, 12:36 AM
Unknown Object (File)
Wed, Apr 24, 10:59 PM
Unknown Object (File)
Sat, Apr 20, 3:57 AM
Unknown Object (File)
Wed, Apr 17, 3:18 PM
Unknown Object (File)
Sat, Apr 6, 8:43 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4592: Use mingw to rebuild xhpast.exe on Windows
T4395: ArcanistPhpcsLinter issue with msdos and cygwin
Commits
rPHU3fe4daa19d2c: Fix lint when working on windows
Summary

Fixes T4395.

Add quotes to ExecFuture strings on Windows to prevent cmd.exe from mucking up the command string.

Test Plan

Run arc lint on projects using phpcs. See everything working like it should.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

richardvanvelzen updated this revision to Diff 22257.Jun 2 2014, 8:59 PM
richardvanvelzen retitled this revision from to Fixes T4395. Ref T4592..
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2014, 8:59 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
richardvanvelzen retitled this revision from Fixes T4395. Ref T4592. to Fix lint when working on windows.Jun 2 2014, 8:59 PM
richardvanvelzen updated this object.
richardvanvelzen edited edge metadata.
richardvanvelzen added tasks: T4395: ArcanistPhpcsLinter issue with msdos and cygwin, T4592: Use mingw to rebuild xhpast.exe on Windows.
Harbormaster completed remote builds in B803: Diff 22257.Jun 2 2014, 9:00 PM
epriestley requested changes to this revision.Jun 4 2014, 9:26 PM
epriestley edited edge metadata.

I'll accept the quoting change if you expand the comment a little to summarize the issue (it should still link to T4395, but be slightly more descriptive).

Can you briefly walk me through the xhpast.exe rebuild? Not that I don't trust you, but I'd rather build binaries we ship from source. I'll take a shot at this locally and yell if I get stuck.

This revision now requires changes to proceed.Jun 4 2014, 9:26 PM
epriestley added a comment.Jun 4 2014, 10:11 PM

(D9378 has a .exe rebuild that I have chain-of-custody on.)

richardvanvelzen updated this revision to Diff 22378.Jun 5 2014, 5:52 AM
richardvanvelzen edited edge metadata.

Remove the rebuild xhpast.exe and expand the comment a bit.

Harbormaster completed remote builds in B865: Diff 22378.Jun 5 2014, 5:53 AM
richardvanvelzen updated this object.Jun 5 2014, 5:53 AM
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen edited edge metadata.
epriestley accepted this revision.Jun 5 2014, 4:40 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Jun 5 2014, 4:40 PM
epriestley closed this revision.Jun 5 2014, 4:41 PM
epriestley updated this revision to Diff 22393.

Closed by commit rPHU3fe4daa19d2c (authored by @richardvanvelzen, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
future/
exec/
12 lines

Diff 22393

View Options

src/future/exec/ExecFuture.php

Loading...
Phabricator · Built by Phacility