Page MenuHomePhabricator

Support interactive editing with Windows editors
ClosedPublic

Authored by richardvanvelzen on Jun 12 2014, 8:27 PM.
Tags
None
Referenced Files
F14103717: D9504.diff
Tue, Nov 26, 10:39 PM
F14097909: D9504.id.diff
Tue, Nov 26, 7:58 AM
F14097907: D9504.id22771.diff
Tue, Nov 26, 7:58 AM
F14097906: D9504.id22797.diff
Tue, Nov 26, 7:58 AM
F14097905: D9504.id22773.diff
Tue, Nov 26, 7:58 AM
F14097718: D9504.diff
Tue, Nov 26, 7:39 AM
Unknown Object (File)
Fri, Nov 22, 12:56 AM
Unknown Object (File)
Wed, Nov 20, 7:48 PM
Subscribers

Details

Summary

Currently, output is generated with *nix newlines (\n) but this doesn't work in (for example) notepad. (and oh, Notepad blocks just fine)

Test Plan

run arc diff with and without the patch. See a mess before, and beauty after

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

richardvanvelzen retitled this revision from to Support interactive editing with Windows editors.
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added a reviewer: epriestley.
richardvanvelzen edited edge metadata.

Not an actual update, just running with sublime text as well to be sure it's handled correctly.

epriestley edited edge metadata.

Per IRC:

  • This is mostly an issue with Notepad.
  • If this trips up other editors, a reasonable approach might be to try to trigger this logic for Notepad only.
  • Generally: yuck, but no clearer fix immediately presents itself.
This revision is now accepted and ready to land.Jun 13 2014, 2:51 PM
epriestley updated this revision to Diff 22797.

Closed by commit rPHU992ff5b489d2 (authored by @richardvanvelzen, committed by @epriestley).