Support arbitrary start numbers for ordered lists in remarkup
ClosedPublic
Actions

Authored by richardvanvelzen on Oct 23 2014, 7:24 PM.

Details

Reviewers

epriestley
• Thirtyate

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6377: [remarkup] Allow specifying start number of an ordered list

Commits

rPHU0db4b149c4e0: Support arbitrary start numbers for ordered lists in remarkup

Summary

Fixes T6377.

Test Plan

Unit tests, mostly. Also checked a local install to see if this felt sensible.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

richardvanvelzen updated this revision to Diff 25786.Oct 23 2014, 7:24 PM

richardvanvelzen retitled this revision from to Support arbitrary start numbers for ordered lists in remarkup.

richardvanvelzen updated this object.

richardvanvelzen edited the test plan for this revision. (Show Details)

richardvanvelzen added reviewers: epriestley, • Thirtyate.

richardvanvelzen added a task: T6377: [remarkup] Allow specifying start number of an ordered list.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 23 2014, 7:24 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Harbormaster completed remote builds in B2884: Diff 25786.Oct 23 2014, 7:25 PM

Thanks!

This revision is now accepted and ready to land.Oct 23 2014, 7:28 PM

Closed by commit rPHU0db4b149c4e0: Support arbitrary start numbers for ordered lists in remarkup (authored by richardvanvelzen, committed by epriestley). · Explain WhyOct 23 2014, 7:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

__tests__/

remarkup/

ordered-list-with-numbers.txt

20 lines

remarkup/

blockrule/

PhutilRemarkupListBlockRule.php

38 lines

Diff 25787

View Options

src/markup/engine/tests/remarkup/ordered-list-with-numbers.txt

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupListBlockRule.php

Support arbitrary start numbers for ordered lists in remarkupClosedPublicActions