Page MenuHomePhabricator
Differential D9585

Let `arc liberate` throw on unsupported PHP features
ClosedPublic
Actions

Authored by richardvanvelzen on Jun 16 2014, 10:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 7:47 AM
Unknown Object (File)
Sun, Dec 15, 5:38 AM
Unknown Object (File)
Fri, Dec 13, 2:52 PM
Unknown Object (File)
Fri, Dec 13, 10:50 AM
Unknown Object (File)
Fri, Dec 13, 9:49 AM
Unknown Object (File)
Thu, Dec 12, 12:53 AM
Unknown Object (File)
Tue, Dec 3, 10:40 PM
Unknown Object (File)
Tue, Dec 3, 11:04 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4725: `arc liberate` should throw when encountering (and eventually support) namespaces and traits
Commits
rARC3810cdbbccff: Let `arc liberate` throw on unsupported PHP features
Summary

Ref T4725.

Test Plan

add some files that have unsupported constructs all over the place and run arc liberate

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

richardvanvelzen updated this revision to Diff 22968.Jun 16 2014, 10:05 PM
richardvanvelzen retitled this revision from to Let `arc liberate` throw on unsupported PHP features.
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added a reviewer: epriestley.
richardvanvelzen added a task: T4725: `arc liberate` should throw when encountering (and eventually support) namespaces and traits.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 16 2014, 10:05 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
richardvanvelzen added a comment.Jun 16 2014, 10:05 PM

This probably needs quite some work.

Harbormaster completed remote builds in B1156: Diff 22968.Jun 16 2014, 10:06 PM
epriestley requested changes to this revision.Jun 17 2014, 11:40 AM
epriestley edited edge metadata.

This generally seems pretty reasonable to me. What sort of issues do you think it has?

One minor nitpick: it's sometimes hard/impossible to translate sentence fragments into other languages and end up with natural-sounding grammar. It would be better to just name the feature in $what (e.g., "namespaces" instead of "use a namespace") and then use an error string like this:

arc liberate has limited support for features introduced after PHP 5.2.3. This library uses an unsupported feature (%s) on line %d of %s

Then you can just pass "namespaces", "traits", "namespace 'use' statements", etc.

This revision now requires changes to proceed.Jun 17 2014, 11:40 AM
richardvanvelzen added a comment.Jun 17 2014, 12:05 PM

I don't know, it was pretty late and I just pushed it out hoping for feedback. :-)

richardvanvelzen updated this revision to Diff 22992.Jun 17 2014, 12:06 PM
richardvanvelzen edited edge metadata.

Use a simpler grammatical construct for the error message

Harbormaster completed remote builds in B1172: Diff 22992.Jun 17 2014, 12:07 PM
epriestley accepted this revision.Jun 17 2014, 12:12 PM
epriestley edited edge metadata.

Cool, let's see how this works. Thanks!

This revision is now accepted and ready to land.Jun 17 2014, 12:12 PM
epriestley closed this revision.Jun 17 2014, 12:13 PM
epriestley updated this revision to Diff 22993.

Closed by commit rARC3810cdbbccff (authored by @richardvanvelzen, committed by @epriestley).

Revision Contents
Changeset List

PathSize
scripts/
44 lines

Diff 22993

View Options

scripts/phutil_symbols.php

Loading...
Phabricator · Built by Phacility