Paths

Table of Contentst

Differential D9797

Refactor author handling in the Mercurial API
ClosedPublic
Actions

Authored by richardvanvelzen on Jul 2 2014, 3:06 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC792204db95cc: Refactor author handling in the Mercurial API

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

There were two callsites which needed some information from the username. Only one worked "correctly", causing arc diff to not amend commits anymore because the author could not be parser.

Test Plan

run arc diff with changes

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

richardvanvelzen updated this revision to Diff 23514.Jul 2 2014, 3:06 PM

richardvanvelzen retitled this revision from to Refactor author handling in the Mercurial API.

richardvanvelzen updated this object.

richardvanvelzen edited the test plan for this revision. (Show Details)

richardvanvelzen added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 2 2014, 3:06 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1484: Diff 23514.Jul 2 2014, 3:07 PM

Debug-less

Harbormaster completed remote builds in B1485: Diff 23515.Jul 2 2014, 3:08 PM

epriestley accepted this revision.Jul 2 2014, 8:58 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 2 2014, 8:58 PM

Closed by commit rARC792204db95cc (authored by Richard van Velzen <rvanvelzen@experty.com>, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistMercurialAPI.php

36 lines

Diff 23520

View Options

src/repository/api/ArcanistMercurialAPI.php

Refactor author handling in the Mercurial APIClosedPublicActions