Page MenuHomePhabricator
Create Task
Maniphest T6331

Closing a revision via a commit generates superfluous "mention" in Task
Closed, ResolvedPublic
Actions

Description

Probably introduced in rP3dd92a78ac2a (other commits since our last update don't seem to touch this code).

When someone pushes their commit, the revision gets closed, which gets mentioned in the task:

xxx added a commit: rXXabcdefabcdef: Use xx for xx to fix xx

However, it now also generates a mention:

xxx mentioned this in: rXXabcdefabcdef: Use xx for xx to fix xx

It seems a bit double. It doesn't bother me, but some coworkers were somewhat confused and thought they did something wrong.

(The commit(s) was not changed in any way after running arc amend)

Revisions and Commits

rP Phabricator
D10721rPd9dd098e405b Audit - fix erroneous mentions of tasks, etc via commit message

Related Objects

Event Timeline

richardvanvelzen created this task.Oct 16 2014, 1:12 PM
richardvanvelzen raised the priority of this task from to Needs Triage.
richardvanvelzen updated the task description. (Show Details)
richardvanvelzen added projects: Phabricator, Diffusion.
richardvanvelzen updated the task description. (Show Details)
richardvanvelzen added a subscriber: richardvanvelzen.
chad edited projects, added Transactions; removed Phabricator.Oct 16 2014, 2:17 PM
chad added a subscriber: btrahan.
chad added a subscriber: chad.

Nice catch.

btrahan added a comment.Oct 16 2014, 2:46 PM

I am not reproducing this in my test environment.

richardvanvelzen added a comment.Oct 16 2014, 2:52 PM

I've now seen the same issue over several commits, leading me to believe
that it's not a fluke.

btrahan added a comment.Oct 16 2014, 3:10 PM

Can you show me a raw commit message involved in these shenanigans?

rP3dd92a78ac2a4931b7a673cc94fa61eae05f3bd1 basically starts parsing the commit message to generate mentions. "Vanilla" Phabricator does not put any references to differential objects - just links to the actual differential - which is why its not happening in my test install.

btrahan added a comment.Oct 16 2014, 3:38 PM

(This didn't reproduce on this install just now. See D10712 and corresponding commit rPac83ff706023e266907ed625954ef9b988daf014 )

richardvanvelzen added a comment.Oct 16 2014, 4:05 PM

Oh, I notice I forgot to mention it was about a task :/ My apologies for
that.

If you look at T2497 you see the mention I meant.

btrahan claimed this task.Oct 16 2014, 5:08 PM

Ah, okay. Thanks! I'll get a patch out later today pr early tomorrow.

(If someone else wants to take a look, the phids from task fixes, task ref, and probably auditors need to get passed to setUnmentionablePHIDs in the editor. Challenge is probably getting all those relationships. Can likely be done just for TYPE_COMMIT transactions.)

GMTA added a subscriber: GMTA.Oct 16 2014, 5:47 PM
joshuaspence added a subscriber: joshuaspence.Oct 16 2014, 7:49 PM
richardvanvelzen renamed this task from Closing a revision via a commit generates superfluous "mention" to Closing a revision via a commit generates superfluous "mention" in Task.Oct 16 2014, 10:07 PM
richardvanvelzen updated the task description. (Show Details)
chad triaged this task as Normal priority.Oct 16 2014, 11:15 PM
btrahan added a revision: D10721: Audit - fix erroneous mentions of tasks, etc via commit message.Oct 16 2014, 11:49 PM
btrahan closed this task as Resolved.Oct 17 2014, 12:08 AM
btrahan added a commit: rPd9dd098e405b: Audit - fix erroneous mentions of tasks, etc via commit message.

Closed by commit rPd9dd098e405b.

btrahan mentioned this in rPd9dd098e405b: Audit - fix erroneous mentions of tasks, etc via commit message.Oct 17 2014, 12:08 AM
Phabricator · Built by Phacility