Page MenuHomePhabricator

Don't parse mercurial usernames without email address as an email address
ClosedPublic

Authored by richardvanvelzen on Jun 17 2014, 6:32 PM.
Tags
None
Referenced Files
F13267668: D9605.diff
Wed, May 29, 3:57 AM
F13253461: D9605.diff
Sat, May 25, 2:41 AM
F13232497: D9605.diff
Tue, May 21, 1:19 AM
F13228147: D9605.id23021.diff
Mon, May 20, 7:31 AM
F13213030: D9605.diff
Fri, May 17, 7:17 AM
Unknown Object (File)
Tue, May 7, 2:57 AM
Unknown Object (File)
May 3 2024, 6:13 AM
Unknown Object (File)
Apr 24 2024, 10:39 PM
Subscribers

Details

Summary

This leads to information being lost when others do arc patch because the name is used as the email address.

For example:

username = Richard van Velzen

Would give:

'authorName' => null,
'authorEmail' => 'Richard van Velzen'
Test Plan

ran it through my head a couple of times, and tested it with the common options which all gave the expected result:

'rvanvelzen@company.com',
'Richard van Velzen',
'Richard van Velzen <rvanvelzen@company.com>',
'Richard van Velzen rvanvelzen@company.com',

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

richardvanvelzen retitled this revision from to Don't parse mercurial usernames without email address as an email address.
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 17 2014, 6:46 PM
epriestley updated this revision to Diff 23022.

Closed by commit rARC680ec3670cd9 (authored by @richardvanvelzen, committed by @epriestley).