Page MenuHomePhabricator
Feed Advanced Search

Jun 1 2021

bbrdaric awarded Changelog a Heartbreak token.
Jun 1 2021, 8:41 AM

Aug 13 2019

jcox awarded Changelog a Love token.
Aug 13 2019, 4:30 PM

Apr 19 2019

remusvrm awarded Changelog a Like token.
Apr 19 2019, 7:09 PM

Jun 7 2017

sascha-egerer added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

T8442 would help a lot for those "I have to many repositories"

Today, you could save searches in different Spaces. For example, here I've done this:

  • Search for "Spaces: Phacility".
  • Save the search as "Phacility Repositories".

Screen Shot 2017-06-07 at 11.08.35 AM.png (1×1 px, 193 KB)

Do you use this strategy today? How would T8442 improve on this? If you don't do this already, but dividing repositories by Space is useful, why don't you currently do it? Put another way, what problem exists with search today that T8442 solves but search changes could not solve?

Jun 7 2017, 8:14 PM · Diffusion, Design
sascha-egerer added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

T8442 would help a lot for those "I have to many repositories"

Jun 7 2017, 4:22 PM · Diffusion, Design

Nov 1 2016

adam93 awarded T4026: Add relations between commits a Like token.
Nov 1 2016, 1:55 PM · Restricted Project, Audit

Sep 20 2016

sascha-egerer added a comment to T10725: Can't access binary files of differential revision.

I have that problem again. There is no relation between the file and the Diff. Don't know how that can happen...

Sep 20 2016, 4:06 PM · Restricted Project, Differential, Bug Report

Sep 12 2016

sascha-egerer closed mock M1469: Relation example.
Sep 12 2016, 6:08 AM
sascha-egerer updated the task description for T11619: Uploading an image in the Mock description does not attach it to the Mock.
Sep 12 2016, 5:32 AM · Bug Report
sascha-egerer created T11619: Uploading an image in the Mock description does not attach it to the Mock.
Sep 12 2016, 5:32 AM · Bug Report
sascha-egerer created M1469: Relation example.
Sep 12 2016, 5:27 AM

Aug 23 2016

sascha-egerer added a comment to T11515: `arc ade` should do something.

I hate commanding arc with these commands. Can we also please add please do a prefix for everything? Like arc please do a diff, arc please do a land

Aug 23 2016, 8:15 AM · Feature Request

Aug 16 2016

sascha-egerer added a comment to T11447: Make related object search more flexible.

Ok sorry for that - that was a really bad example... The problem is that only complete words are found and not parts of it.
So you'll get a result for "Hello" but not for "Hell".
So searching for "Component" will give no result if the title is "Components". Is that correct?

Aug 16 2016, 9:09 AM · Bug Report (Needs Information)

Aug 9 2016

sascha-egerer created T11447: Make related object search more flexible.
Aug 9 2016, 12:08 PM · Bug Report (Needs Information)

Jul 20 2016

sascha-egerer awarded D15880: Move 'should render' logic to PhutilUnitTestEngine a Like token.
Jul 20 2016, 10:55 AM
sascha-egerer renamed T11352: arc patch with invalid revision number fails with an exception from arc patch with revision number fails with an exception to arc patch with invalid revision number fails with an exception.
Jul 20 2016, 10:29 AM · Arcanist, Feature Request
sascha-egerer created T11352: arc patch with invalid revision number fails with an exception.
Jul 20 2016, 9:56 AM · Arcanist, Feature Request
sascha-egerer awarded T5568: Support `.arcunit`, similar to `.arclint` a Hungry Hippo token.
Jul 20 2016, 5:24 AM · Unit, Arcanist

May 24 2016

sascha-egerer added a comment to T10661: Can't create milestone.

@CodeMouse92 yes the project has a subproject. But changing the policies as described above works around that issue.

May 24 2016, 4:38 AM · Projects (v3), Bug Report

May 6 2016

sascha-egerer added a comment to T10928: Remote branches of git mirror are deleted.

Thanks! Maybe this can save some time for some people...

May 6 2016, 3:03 PM · Bug Report
sascha-egerer accepted D15861: Use more precise language to describe what mirroring is.

Great!

May 6 2016, 3:03 PM
sascha-egerer added a comment to T10928: Remote branches of git mirror are deleted.

I already thought that while writing the ticket ;-) That's the reason i added the last sentence to adjust the documentation. Maybe it would be good to know that this feature is using the git mirror function and may overwrite data of the mirror.

May 6 2016, 2:46 PM · Bug Report
sascha-egerer updated the task description for T10928: Remote branches of git mirror are deleted.
May 6 2016, 10:28 AM · Bug Report
sascha-egerer updated the task description for T10928: Remote branches of git mirror are deleted.
May 6 2016, 10:23 AM · Bug Report
sascha-egerer created T10928: Remote branches of git mirror are deleted.
May 6 2016, 9:54 AM · Bug Report

Apr 27 2016

sascha-egerer updated the task description for T10886: Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge.
Apr 27 2016, 12:46 PM · Pholio, Bug Report
sascha-egerer created T10886: Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge.
Apr 27 2016, 12:46 PM · Pholio, Bug Report

Apr 25 2016

sascha-egerer created T10865: Remarkup is not rendered in Pholio Application.
Apr 25 2016, 10:53 AM · Remarkup, Pholio, Bug Report

Apr 6 2016

sascha-egerer added a comment to T10731: Script-and-regex linter documentation does not make it clear enough that you really have to do what it says.

The use of sh as it is written in the documentation is important.

This is what you are intended to write:

$ sh -c 'echo "$0"' xxx
xxx

This is what it looks like you're writing:

$ echo $0 xxx
-bash xxx
Apr 6 2016, 1:47 PM · Lint, Bug Report
sascha-egerer added a comment to T10725: Can't access binary files of differential revision.

I've also added myself as a subscriber (even if i was auto subscribed because i'm the reviewer) but that doesn't change anything. Still no permissions.
The problem can also be reproduced when clicking on Download Raw Diff in the interface.

Apr 6 2016, 8:00 AM · Restricted Project, Differential, Bug Report
sascha-egerer added a comment to T10725: Can't access binary files of differential revision.
In T10725#168658, @chad wrote:

Files attached to other objects take on permissions of the object itself. So if you add a file to a restricted task, the restriction is also applied to the file.

Apr 6 2016, 6:26 AM · Restricted Project, Differential, Bug Report
sascha-egerer added a comment to T10725: Can't access binary files of differential revision.
In T10725#168645, @chad wrote:

My question was what is the relation to User B and the Diff. Is User B a reviewer, a subscriber, or ... ?

Apr 6 2016, 6:21 AM · Restricted Project, Differential, Bug Report
sascha-egerer created T10731: Script-and-regex linter documentation does not make it clear enough that you really have to do what it says.
Apr 6 2016, 6:17 AM · Lint, Bug Report
sascha-egerer added a comment to T10725: Can't access binary files of differential revision.
In T10725#168508, @chad wrote:

What's the relationship between user b and the patch, specifically?

Apr 6 2016, 6:01 AM · Restricted Project, Differential, Bug Report

Apr 5 2016

sascha-egerer created T10725: Can't access binary files of differential revision.
Apr 5 2016, 2:49 PM · Restricted Project, Differential, Bug Report

Apr 4 2016

sascha-egerer awarded M1461: Timeline / Remarkup Cleanup a Love token.
Apr 4 2016, 8:35 AM

Mar 30 2016

sascha-egerer awarded D12198: Added ESLint Support a Pterodactyl token.
Mar 30 2016, 7:39 AM

Mar 24 2016

sascha-egerer added a comment to T10661: Can't create milestone.

Ok i found the reason for the problem.
If you set ApplicationsProjectsEdit PoliciesDefault View Policy to Project Memebers i does not work. You can still create normal projects and subprojects but you can't create milestones. I think that is because milestones do not have members but the permissions are evaluated against the "project members".

Mar 24 2016, 9:52 PM · Projects (v3), Bug Report
sascha-egerer added a comment to T10661: Can't create milestone.

Ok, then I'll investigate further and give feedback as soon as i've found something

Mar 24 2016, 2:30 PM · Projects (v3), Bug Report
sascha-egerer added a comment to T10661: Can't create milestone.

Yes I'm member of all those groups as described above. I'm also an "Admin"

Mar 24 2016, 2:13 PM · Projects (v3), Bug Report
sascha-egerer added a comment to T10661: Can't create milestone.

I've posted a screenshot of my settings or do you need anything else?

Mar 24 2016, 2:08 PM · Projects (v3), Bug Report
sascha-egerer added a comment to T10661: Can't create milestone.

Yeah i did basically the same. What are the permissions of your project?

Mar 24 2016, 1:36 PM · Projects (v3), Bug Report
sascha-egerer created T10661: Can't create milestone.
Mar 24 2016, 11:39 AM · Projects (v3), Bug Report

Mar 22 2016

sascha-egerer added a comment to T9293: WebSockets access problems with reverse SSL proxy .

I would vote for X-Forwarded-Proto support in AphrontRequest::isHTTPS

Mar 22 2016, 8:52 AM · Restricted Project, Aphlict

Mar 16 2016

sascha-egerer added a comment to T8594: Develop system for dumping/backing up Phriction documents.

@jhurwitz I use conduit to fetch wiki pages and format them with conduit to get a html syntax. I do that to add Wiki-Pages to a Frontend-Styleguide. Then i just add the required phabricator css and everything looks fine.
So i think you can write your own simple script to do everything over conduit, right?

Mar 16 2016, 10:59 AM · Phriction, Restricted Project

Mar 14 2016

sascha-egerer created T10582: Support colspan and rowspan in tables.
Mar 14 2016, 11:07 AM · Remarkup, Feature Request

Mar 9 2016

sascha-egerer added a comment to D15025: fix bug.

Really good commit message! Thank you for that! Learned a lot again with your help...

Mar 9 2016, 4:58 PM

Mar 2 2016

sascha-egerer added a comment to T5254: Allow top-level wiki doc to display entire document hierarchy instead of only 2 levels.

Any progress here? What about setting the hierachy limit in the wiki document itself? So you can say "show X levels in the document hierachy of this page" where X is inherited and has a default value of 2?

Mar 2 2016, 3:32 PM · Phriction

Sep 30 2015

sascha-egerer added a comment to T9123: Build Phabricator in Harbormaster (v2).

We're kinda-sort doing builds for commits now:

Screen Shot 2015-09-29 at 2.15.22 PM.png (201×798 px, 38 KB)

Sep 30 2015, 11:19 AM · Prioritized, Harbormaster

Jun 1 2015

sascha-egerer merged task T8107: Current file is not highlighted in the filetree anymore into T8099: Mid-2015 Phabricator Redesign.
Jun 1 2015, 6:43 PM · Differential
sascha-egerer merged T8107: Current file is not highlighted in the filetree anymore into T8099: Mid-2015 Phabricator Redesign.
Jun 1 2015, 6:43 PM · Design

May 11 2015

sascha-egerer created T8159: Unit test and linter results are not accessible anymore if revision has been landed.
May 11 2015, 8:27 AM · Differential

May 8 2015

sascha-egerer accepted rARCa4d33ef117aa: Use phutil_json_decode instead of json_decode.

Fixed in rARC3e36b3fc430d

May 8 2015, 7:43 AM

May 7 2015

sascha-egerer retitled D12751: Fix broken ArcanistPhpunitTestResultParser from to Fix broken ArcanistPhpunitTestResultParser.
May 7 2015, 3:27 PM
sascha-egerer raised a concern with rARCa4d33ef117aa: Use phutil_json_decode instead of json_decode.

This patch has broken the ArcanistPhpunitTestResultParser.php as phutil_json_decode returns an array and not an object as json_decode has before. I'll push an patch for this

May 7 2015, 3:16 PM
sascha-egerer created T8107: Current file is not highlighted in the filetree anymore.
May 7 2015, 2:52 PM · Differential

Apr 26 2015

sascha-egerer awarded rP0ae08b394cd4: Raise a better error for SSH access by users with no permission to use Diffusion a Like token.
Apr 26 2015, 3:35 PM

Apr 23 2015

sascha-egerer added a comment to T7894: Give more specific error when git clone fails.

Create a bot User that has Access to a Repository but not to Diffusion. Try to clone which will fail.

Apr 23 2015, 5:41 PM · Diffusion
sascha-egerer created T7894: Give more specific error when git clone fails.
Apr 23 2015, 7:15 AM · Diffusion

Mar 24 2015

sascha-egerer added a comment to T5064: Make `arc land` run unit tests and lint.

What about a configuration option runUnitTestsOnLanding that could be disabled, allTests, changedFiles?
I don't see a benefit for running linters again as the comnination of 2 patches should not change any code style, right?

Mar 24 2015, 7:27 AM · Restricted Project, Arcanist

Feb 11 2015

sascha-egerer added a comment to D11515: Add configuration option for PHPUnit test dirs.

That does also fix the problem that unit tests are not executed when doing an arc diff if they are not stored directly in the tests folder.

Feb 11 2015, 4:09 PM

Feb 10 2015

johnny-bit awarded T7040: Create dependency for revisions automatically a Like token.
Feb 10 2015, 8:15 AM · Arcanist

Feb 4 2015

sascha-egerer added a comment to D11515: Add configuration option for PHPUnit test dirs.

Any comments on that?

Feb 4 2015, 9:02 AM
sascha-egerer added a comment to T7071: PHPCS is broken.

As far as i can see this can't work but is a bug in PHPCS. https://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer/CLI.php#L875
But i really don't understand why it works on your machine...

Feb 4 2015, 7:51 AM · Lint, Arcanist

Jan 29 2015

sascha-egerer added a task to D9034: PHPCS supports reading from stdin.: T7071: PHPCS is broken.
Jan 29 2015, 10:02 AM
sascha-egerer added a revision to T7071: PHPCS is broken: D9034: PHPCS supports reading from stdin..
Jan 29 2015, 10:02 AM · Lint, Arcanist
sascha-egerer added a comment to T7071: PHPCS is broken.

oh ok... i can reproduce that on 2 machines. What's your OS? What's your php version?
I'm on MacOS 10.9.5

Jan 29 2015, 9:38 AM · Lint, Arcanist
sascha-egerer added a comment to T7071: PHPCS is broken.

And you have this still applied?

public function supportsReadDataFromStdin() {
  return true;
}
Jan 29 2015, 9:01 AM · Lint, Arcanist
sascha-egerer added a comment to T7081: "Mark all notifications as read" dialog is behind overlay on iOS.

A the same problem for logout. So you can't logout currently on iOS by using the standard interface.

Jan 29 2015, 6:02 AM · PHUI
sascha-egerer updated the task description for T7081: "Mark all notifications as read" dialog is behind overlay on iOS.
Jan 29 2015, 6:01 AM · PHUI
sascha-egerer created T7081: "Mark all notifications as read" dialog is behind overlay on iOS.
Jan 29 2015, 6:00 AM · PHUI

Jan 28 2015

sascha-egerer created T7071: PHPCS is broken.
Jan 28 2015, 2:37 PM · Lint, Arcanist
sascha-egerer added a comment to D9034: PHPCS supports reading from stdin..

Now the linter does also fail when you have an empty php file. Instead of showing the correct message

arc lint foo.php
>>> Lint for foo.php:
Jan 28 2015, 2:35 PM

Jan 27 2015

sascha-egerer updated the diff for D11515: Add configuration option for PHPUnit test dirs.

Removed some whitespace changes

Jan 27 2015, 7:39 AM
sascha-egerer retitled D11515: Add configuration option for PHPUnit test dirs from to Add configuration option for PHPUnit test dirs.
Jan 27 2015, 7:35 AM

Jan 26 2015

sascha-egerer created T7040: Create dependency for revisions automatically.
Jan 26 2015, 12:42 PM · Arcanist

Jan 14 2015

sascha-egerer awarded T4752: Daemons may not have permission to remove files from local disk storage engine a The World Burns token.
Jan 14 2015, 12:18 PM · Files

Nov 19 2014

sascha-egerer awarded T5064: Make `arc land` run unit tests and lint a The World Burns token.
Nov 19 2014, 8:36 AM · Restricted Project, Arcanist
sascha-egerer added a comment to T5064: Make `arc land` run unit tests and lint.
In T5064#59055, @BYK wrote:

Can't we run arc unit and arc lint right before pushing and if they fail clean up by doing git reset --hard HEAD^1 and switching to the branch? Obviously I'm only thinking about the git case here where arc needs to handle hg and svn too but I'd like to hear more about this since I've landed code which actually broke unit tests in the past during a merge or rebase. It was not fun :)

Nov 19 2014, 8:36 AM · Restricted Project, Arcanist

Jul 2 2014

sascha-egerer added a comment to T5531: Dashboard with 3 columns.

Should i create a Task for "Dashboard with 4 columns"?
What about making the column amount flexible?

Jul 2 2014, 1:45 PM · Dashboards

May 28 2014

sascha-egerer added a comment to T5212: Add browser notification support for Conpherence.

Ups... Looks like I've Looked at a wrong task... There is no difference to T4139. Sorry...

May 28 2014, 8:32 PM · Conpherence
sascha-egerer added a comment to T5212: Add browser notification support for Conpherence.

These tasks are both not related to native browser notifications but to realtime Chat Updates. So i thought i create a new ticket. But if this will also Done in this tickets i'm Fine with that.

May 28 2014, 7:48 PM · Conpherence
sascha-egerer added a comment to T5211: Firefox has high CPU utilization when scaled background images (particularly avatars) are visible.

Demo comment to try to reproduce the issue

May 28 2014, 12:16 PM · Maniphest
sascha-egerer added a project to T5212: Add browser notification support for Conpherence: Conpherence.
May 28 2014, 12:04 PM · Conpherence
sascha-egerer created T5212: Add browser notification support for Conpherence.
May 28 2014, 12:04 PM · Conpherence
sascha-egerer awarded T4083: Implement support for automatically updating Conpherence when new messages appear a Love token.
May 28 2014, 12:02 PM · Conpherence

May 17 2014

sascha-egerer abandoned D9135: Add function to merge 2 arrays by overruling the first.

As already said in IRC I'll implement this function with a custom script and abondon this revision.

May 17 2014, 7:41 AM

May 15 2014

sascha-egerer added a comment to D9135: Add function to merge 2 arrays by overruling the first.

I've just run the unit test cases against +, array_merge, array_merge_recursive and array_merge_recursive_overrule to show the different result. P1142
Do you have a better idea how to handle these configurations?

May 15 2014, 7:57 PM
sascha-egerer edited P1142 Array merge.
May 15 2014, 7:55 PM
sascha-egerer added a comment to D9135: Add function to merge 2 arrays by overruling the first.
In D9135#6, @epriestley wrote:

This is e.g. usefull to merge a global configuration file with a stage specific configuration.

Where do you want to use this specifically?

I worry this won't be sufficient in the general case. If both configuration files have lists, sometimes those lists should be combined instead of overwritten, and other times they should be overwritten entirely.

May 15 2014, 3:28 PM
sascha-egerer retitled D9135: Add function to merge 2 arrays by overruling the first from to Add function to merge 2 arrays by overruling the first.
May 15 2014, 3:02 PM

Apr 8 2014

sascha-egerer added a comment to T4752: Daemons may not have permission to remove files from local disk storage engine.

Another approach might be to adjust the umask when we write stuff to the local disk engine.

Apr 8 2014, 7:47 AM · Files

Dec 4 2013

sascha-egerer awarded T4195: Implement pre-commit Herald rules a Love token.
Dec 4 2013, 2:50 PM · Diffusion

Nov 18 2013

sascha-egerer closed T4121: Nooooo as Invalid.
Nov 18 2013, 10:40 AM

Oct 26 2013

sascha-egerer edited this Maniphest Task.
Oct 26 2013, 5:29 PM · Restricted Project, Audit

Oct 25 2013

sascha-egerer edited this Maniphest Task.
Oct 25 2013, 7:47 PM · Remarkup, Diffusion
sascha-egerer raised the priority of T4027: Link commit header also to bugtraq url from to Needs Triage.
Oct 25 2013, 7:43 PM · Remarkup, Diffusion
sascha-egerer updated the task description for T4026: Add relations between commits.
Oct 25 2013, 7:11 PM · Restricted Project, Audit
sascha-egerer raised the priority of T4026: Add relations between commits from to Needs Triage.
Oct 25 2013, 7:08 PM · Restricted Project, Audit

Oct 22 2013

sascha-egerer awarded T1344: Create the ability to show a Trello style view for projects. a Love token.
Oct 22 2013, 2:21 PM · Maniphest, Workboards