Page MenuHomePhabricator

Fix broken ArcanistPhpunitTestResultParser
ClosedPublic

Authored by sascha-egerer on May 7 2015, 3:27 PM.
Tags
None
Referenced Files
F19074573: D12751.id.diff
Mon, Dec 1, 5:58 AM
F19073153: D12751.diff
Mon, Dec 1, 12:53 AM
F19049024: D12751.id30638.diff
Thu, Nov 27, 3:54 PM
F18943042: D12751.diff
Nov 11 2025, 1:10 PM
F18838373: D12751.diff
Oct 27 2025, 10:28 AM
F18826848: D12751.id.diff
Oct 24 2025, 5:59 AM
F18773176: D12751.id30640.diff
Oct 9 2025, 7:52 AM
F18768141: D12751.id30638.diff
Oct 8 2025, 1:56 AM

Details

Summary

The ArcanistPhpunitTestResultParser has been changed
to use phutil_json_decode instead of json_decode in
rARCa4d33ef117aa8702181154b60ce1ce52bcfc119b
That has broken the functionality as json_decode has returned
an object before but phutil_json_decode does return an array.
The code has now been adopted to work with the array result
instead of an object.

Test Plan

Run a phpunit test case

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sascha-egerer retitled this revision from to Fix broken ArcanistPhpunitTestResultParser.
sascha-egerer updated this object.
sascha-egerer edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.May 7 2015, 3:40 PM
Closed by commit rARC3e36b3fc430d: Fix broken ArcanistPhpunitTestResultParser (authored by Sascha Egerer <sascha.egerer@dkd.de>, committed by epriestley). · Explain WhyMay 7 2015, 3:41 PM
This revision was automatically updated to reflect the committed changes.