Page MenuHomePhabricator

Fix broken ArcanistPhpunitTestResultParser
ClosedPublic

Authored by sascha-egerer on May 7 2015, 3:27 PM.

Details

Summary

The ArcanistPhpunitTestResultParser has been changed
to use phutil_json_decode instead of json_decode in
rARCa4d33ef117aa8702181154b60ce1ce52bcfc119b
That has broken the functionality as json_decode has returned
an object before but phutil_json_decode does return an array.
The code has now been adopted to work with the array result
instead of an object.

Test Plan

Run a phpunit test case

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sascha-egerer retitled this revision from to Fix broken ArcanistPhpunitTestResultParser.
sascha-egerer updated this object.
sascha-egerer edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.May 7 2015, 3:40 PM
Closed by commit rARC3e36b3fc430d: Fix broken ArcanistPhpunitTestResultParser (authored by Sascha Egerer <sascha.egerer@dkd.de>, committed by epriestley). · Explain WhyMay 7 2015, 3:41 PM
This revision was automatically updated to reflect the committed changes.