Page MenuHomePhabricator

jhurwitz (Jacob Hurwitz)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
May 8 2014, 8:31 PM (258 w, 6 d)
Availability
Available

Recent Activity

Aug 17 2016

jhurwitz added a comment to T11482: Build a changeset cache for Diffusion to improve move/copy detection behvaior.

Thanks for the detailed investigation -- glad we've root-caused this and proposed a solution :)

Aug 17 2016, 6:12 AM · Diffusion (v3), Bug Report

Aug 16 2016

jhurwitz created T11482: Build a changeset cache for Diffusion to improve move/copy detection behvaior.
Aug 16 2016, 2:38 AM · Diffusion (v3), Bug Report

Jan 5 2016

jhurwitz added a comment to T10088: ability to wontfix a maniphest task via an email command.

@dgoldstein, also, for future reference the way you find the list of email commands is to open an object of the type you care about (here, a task), click the circle/lifeboat thing, and then click "email commands."

Jan 5 2016, 10:52 PM · Maniphest, Restricted Project, Feature Request

Nov 20 2015

jhurwitz added a comment to T7732: Convoluted flow when locked out of account with only one auth provider.

That worked for now -- hacky, but thanks.

Nov 20 2015, 7:55 PM · Restricted Project, Auth
jhurwitz added a comment to T7732: Convoluted flow when locked out of account with only one auth provider.

The workaround I provided in the task description ("If you click the "refresh" icon next to the Google provider, you can add a second account.") no longer works after D14319.

Nov 20 2015, 6:47 PM · Restricted Project, Auth

Nov 3 2015

jhurwitz moved T9696: /paste/ fails to load from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 3 2015, 12:57 AM · Paste, Restricted Project

Nov 2 2015

jhurwitz created T9696: /paste/ fails to load.
Nov 2 2015, 11:54 PM · Paste, Restricted Project

Oct 28 2015

jhurwitz awarded D14356: Make "arc land" great again a Baby Tequila token.
Oct 28 2015, 6:44 AM

Oct 27 2015

jhurwitz moved T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Oct 27 2015, 10:17 PM · Restricted Project, Arcanist
jhurwitz added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

@epriestley, do you have a time estimate of how long this would take to fix?

Oct 27 2015, 10:12 PM · Restricted Project, Arcanist

Oct 25 2015

CaptSpot awarded Changelog a Like token.
Oct 25 2015, 9:38 AM

Oct 23 2015

vinzent awarded Changelog a Like token.
Oct 23 2015, 9:26 AM

Oct 22 2015

jhurwitz added a project to T9611: arc upgrade doesn't check for git failures: Restricted Project.
Oct 22 2015, 3:35 AM · Restricted Project

Oct 19 2015

jhurwitz moved T8483: Odd text in inline comment transaction from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Oct 19 2015, 8:52 AM · Restricted Project, Transactions, Differential

Oct 8 2015

jhurwitz added a comment to T731: Allow revisions to have alternate acceptance conditions.

Some people on our install are asking about this task.

Oct 8 2015, 6:20 PM · Restricted Project, Restricted Project, Differential

Oct 1 2015

jhurwitz moved T9028: Phabricator handles commits which are published and later deleted poorly from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Oct 1 2015, 9:06 PM · Restricted Project, Prioritized, Audit, Restricted Project
jhurwitz added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

I think my preference would be the "Improve the error message and provide a button to close the audit" option. @epriestley, how long would this take? Assuming it's small, I think we'd want to prioritize this.

Oct 1 2015, 8:52 PM · Restricted Project, Prioritized, Audit, Restricted Project

Sep 10 2015

jhurwitz added a project to T5030: Improve behavior when jumping to inline comments: Restricted Project.
Sep 10 2015, 6:14 PM · Inline Comments, Restricted Project, Differential
jhurwitz updated subscribers of T5030: Improve behavior when jumping to inline comments.
Sep 10 2015, 6:13 PM · Inline Comments, Restricted Project, Differential
jhurwitz merged task T8592: "View on previous revision" button on ghosted comment can jump to wrong place into T5030: Improve behavior when jumping to inline comments.
Sep 10 2015, 6:13 PM · Differential, Restricted Project
jhurwitz added a comment to T8592: "View on previous revision" button on ghosted comment can jump to wrong place.

I suspect they're the same, but I'm not confident. I'm happy with closing this as a duplicate, and then trying to repro after T5030 is fixed.

Sep 10 2015, 6:13 PM · Differential, Restricted Project
jhurwitz added a comment to T7477: Handle inbound email with phabricator address in the CC.

This just bit us again, via a different repro.

Sep 10 2015, 6:24 AM · llvm, Restricted Project, Restricted Project, Mail

Sep 2 2015

jhurwitz added a comment to T9311: Marking a diff as Requires Changes no longer removes it from Blocking Others.

We haven't yet applied a local patch for T9263. None of our patches seem to be relevant here.

Sep 2 2015, 7:24 PM · Differential, Restricted Project

Aug 31 2015

jhurwitz added a comment to T8901: Maniphest priority color palette not expressive enough.

Actually, I just saw that you switched from .phui-object-item-bar-color-red to .phui-icon-view.red. It looks like we now have 14 color options; that's probably good enough for us for now.

Aug 31 2015, 9:20 PM · PHUI, Maniphest, Restricted Project
jhurwitz added a comment to T8901: Maniphest priority color palette not expressive enough.

We have 7 priorities (one more than the default). Our new priority is "Blocker!", which we put in between High and Needs Triage.

Aug 31 2015, 9:17 PM · PHUI, Maniphest, Restricted Project
jhurwitz added a comment to T8901: Maniphest priority color palette not expressive enough.

Also, barColor does not exist in master, we use icon + color now to convey information instead of just color (and yes, icons are configurable for Maniphest).

Aug 31 2015, 9:04 PM · PHUI, Maniphest, Restricted Project
jhurwitz moved T9279: Sort commit history chronologically from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Aug 31 2015, 5:24 PM · Audit, Restricted Project

Aug 29 2015

jhurwitz added a project to T418: Integrate CustomField into more interfaces: Restricted Project.
Aug 29 2015, 12:28 AM · Restricted Project, Restricted Project, Restricted Project, Maniphest, Custom Fields

Aug 28 2015

jhurwitz added a comment to T9279: Sort commit history chronologically.

I think ordering by commit date would be great!

Aug 28 2015, 12:22 AM · Audit, Restricted Project

Aug 27 2015

jhurwitz added a comment to T9279: Sort commit history chronologically.

To give more info: I'm sure the order makes sense for some use case (though I can't quite figure out what it is right now). The use case we have (in this scenario) is:

Aug 27 2015, 11:48 PM · Audit, Restricted Project

Aug 25 2015

jhurwitz added a comment to T9257: Error: Parameter passed to "setChar()" must be an integer. when using ArcanistPyLintLinter..

[deleted]

Aug 25 2015, 3:29 AM · Lint, Restricted Project
jhurwitz added a project to T9257: Error: Parameter passed to "setChar()" must be an integer. when using ArcanistPyLintLinter.: Restricted Project.
Aug 25 2015, 2:50 AM · Lint, Restricted Project

Aug 12 2015

jhurwitz added a comment to T9143: arc land hangs if git pre-push hook creates child daemon processes.

Worth adding:

Aug 12 2015, 5:23 AM · Arcanist

Aug 4 2015

jhurwitz added a comment to T9012: Nag users who reply-all.

Thanks for the pointer. We CC external mailing lists on most objects because we use Google Groups as the source of truth for group membership, and it's impossible to keep everything else synchronized with it. T3980 sounds interesting.

Aug 4 2015, 10:30 PM · llvm, Mail, Restricted Project
jhurwitz added a project to T3980: Support "Bind to External Thing" to define project membership: Restricted Project.
Aug 4 2015, 10:29 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
jhurwitz added a comment to T9054: Undefined class constant ACTION_BLOCK.

Thanks!

Aug 4 2015, 2:11 AM · Herald
jhurwitz added a comment to T9057: Searching the wiki takes too many clicks.

Our install isn't running any custom CSS. One of our engineers published a Chrome extension that re-skins Phabricator, and it looks like @ianm is running that extension. Ian, disabling the extension should help.

Aug 4 2015, 2:07 AM · Phriction, Restricted Project
jhurwitz added a comment to T9057: Searching the wiki takes too many clicks.

By inspecting the network call that that search field makes, I was able to find a URL for the custom search engine use case:
https://secure.phabricator.com/search/?query=foo&search:scope=application&search:application=PhabricatorPhrictionApplication&search:primary=true

Aug 4 2015, 1:19 AM · Phriction, Restricted Project
jhurwitz added a comment to T9057: Searching the wiki takes too many clicks.

Faster method:

  • Perform a search using the search bar at the top of the page
Aug 4 2015, 1:17 AM · Phriction, Restricted Project
jhurwitz added a comment to T9054: Undefined class constant ACTION_BLOCK.

Any workarounds you can suggest until this fix is pushed? I just tried to edit a Herald rule on this install (https://secure.phabricator.com/herald/edit/109/) and can't because of this error.

Aug 4 2015, 1:15 AM · Herald
jhurwitz updated subscribers of T9028: Phabricator handles commits which are published and later deleted poorly.
Aug 4 2015, 1:14 AM · Restricted Project, Prioritized, Audit, Restricted Project

Aug 3 2015

jhurwitz added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

Thanks for the comment! @epriestley, with that in mind, is bin/remove destroy our best option? Will we be able to receive upstream support if this command causes issues?

Aug 3 2015, 10:52 PM · Infrastructure, Restricted Project
jhurwitz added a project to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest: Restricted Project.
Aug 3 2015, 10:35 PM · Restricted Project, User Delight, Maniphest
jhurwitz added a project to T731: Allow revisions to have alternate acceptance conditions: Restricted Project.
Aug 3 2015, 10:25 PM · Restricted Project, Restricted Project, Differential
jhurwitz added a project to T5591: Add default domain to Google auth: Restricted Project.
Aug 3 2015, 2:20 AM · Restricted Project, Restricted Project, Auth
jhurwitz created T9040: Google SSO fails if `auth.email-domains` is set and you're not logged into the correct Google account.
Aug 3 2015, 1:32 AM · Auth, Restricted Project

Aug 1 2015

jhurwitz added a comment to T8405: Making lint easier to use.

@devd, I want to make sure I understand this correctly -- the task seems to be about making one specific use case of lint easier (not linting in general) but is vague about what that use case is.

Aug 1 2015, 5:39 AM · Lint, Restricted Project

Jul 31 2015

jhurwitz updated the task description for T9028: Phabricator handles commits which are published and later deleted poorly.
Jul 31 2015, 12:00 AM · Restricted Project, Prioritized, Audit, Restricted Project

Jul 30 2015

jhurwitz updated the task description for T9028: Phabricator handles commits which are published and later deleted poorly.
Jul 30 2015, 11:59 PM · Restricted Project, Prioritized, Audit, Restricted Project
jhurwitz updated the task description for T9028: Phabricator handles commits which are published and later deleted poorly.
Jul 30 2015, 11:59 PM · Restricted Project, Prioritized, Audit, Restricted Project
jhurwitz updated the task description for T9028: Phabricator handles commits which are published and later deleted poorly.
Jul 30 2015, 11:57 PM · Restricted Project, Prioritized, Audit, Restricted Project
jhurwitz created T9028: Phabricator handles commits which are published and later deleted poorly.
Jul 30 2015, 11:51 PM · Restricted Project, Prioritized, Audit, Restricted Project

Jul 21 2015

Herald updated subscribers of T4863: Allow Workboard Cards to be customized for display.
Jul 21 2015, 1:52 AM · Projects, Wikimedia, Workboards
jhurwitz added a comment to T8901: Maniphest priority color palette not expressive enough.

At a glance, in views that don't otherwise indicate priority (eg, workboard with natural sort order), I'd like to be able to visually distinguish between all of our different priorities.

Jul 21 2015, 1:39 AM · PHUI, Maniphest, Restricted Project
jhurwitz created T8901: Maniphest priority color palette not expressive enough.
Jul 21 2015, 12:05 AM · PHUI, Maniphest, Restricted Project

Jul 15 2015

jhurwitz added a comment to T8854: Display unit test results on home view.

It sounds like the problem you want to solve is that people sometimes land code before tests have finished running, correct?

Jul 15 2015, 10:53 PM · Unit, Arcanist, Restricted Project
jhurwitz added a comment to T8573: All reviewers should be allowed to mark a comment as done.

@epriestley, what do you think of the problems/use cases @aj described?

Jul 15 2015, 9:34 PM · Restricted Project, Differential, Restricted Project
jhurwitz moved T8588: One instance has a severe, global performance issue from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 15 2015, 9:29 PM · Restricted Project
jhurwitz moved T8708: Undefined variable: message when trying to move a phriction page to a lower level from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 15 2015, 9:29 PM · Phriction, Restricted Project
jhurwitz closed T8566: Specify branch in commit email as Resolved.
Jul 15 2015, 9:12 PM · Diffusion, Restricted Project
jhurwitz moved T8566: Specify branch in commit email from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 15 2015, 9:12 PM · Diffusion, Restricted Project
jhurwitz added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

Sorry, I spoke without actually knowing for sure what bin/remove destroy does. I was guessing based on the warning text ("Destroying objects may cause related objects to stop working, and may leave scattered references to objects which no longer exist.") that it would leave dangling edges.

Jul 15 2015, 9:10 PM · Infrastructure, Restricted Project

Jul 13 2015

jhurwitz updated subscribers of T8835: Replacement for actAsUser in Conduit API.
Jul 13 2015, 9:41 PM · Restricted Project, Conduit
jhurwitz created T8835: Replacement for actAsUser in Conduit API.
Jul 13 2015, 9:40 PM · Restricted Project, Conduit
jhurwitz reopened T7484: Lock is not locked by this process as "Open".

We think we just ran into this today? But the problem mysteriously resolved itself after 2 hours, so we can't be much help in reproing.

Jul 13 2015, 9:04 PM · Restricted Project, Daemons
jhurwitz added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

@ryanseu, can you explain the use case and why setting the view policy isn't sufficient?

Jul 13 2015, 6:40 PM · Infrastructure, Restricted Project
jhurwitz renamed T8830: `bin/remove destroy` is dangerous and leaves dangling edges from /bin/destroy is dangerous and leaves dangling edges to `bin/remove destroy` is dangerous and leaves dangling edges.
Jul 13 2015, 6:14 PM · Infrastructure, Restricted Project
jhurwitz renamed T8830: `bin/remove destroy` is dangerous and leaves dangling edges from bin_destroy is dangerous and leaves dangling edges to /bin/destroy is dangerous and leaves dangling edges.
Jul 13 2015, 6:12 PM · Infrastructure, Restricted Project

Jul 8 2015

jhurwitz added a comment to T8588: One instance has a severe, global performance issue.

Just installed XHProf and ran another profile. Services:

Jul 8 2015, 6:31 PM · Restricted Project
jhurwitz added a comment to T8588: One instance has a severe, global performance issue.

Chrome network console shows 654ms for the AJAX call to /differential/comment/inline/edit/####. The Services profile shows:

Jul 8 2015, 12:24 AM · Restricted Project

Jun 30 2015

jhurwitz updated subscribers of T8588: One instance has a severe, global performance issue.
Jun 30 2015, 12:28 AM · Restricted Project
jhurwitz merged task T8689: Inline commenting that’s actually fast and real-time into T8588: One instance has a severe, global performance issue.
Jun 30 2015, 12:28 AM · Differential, Restricted Project
jhurwitz added a comment to T8689: Inline commenting that’s actually fast and real-time.

In that case, this is a dupe of T8588.

Jun 30 2015, 12:28 AM · Differential, Restricted Project

Jun 24 2015

jhurwitz created T8660: Top search bar is not consistent about searching open vs closed document types.
Jun 24 2015, 8:32 PM · FreeBSD, Search, Restricted Project

Jun 22 2015

jhurwitz added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

Now that I think about it, one possible explanation is if we're executing O(N^2) queries for each workboard column of N open tasks. (The sum of the squares of the number of open tasks in each column is 2924.)

Jun 22 2015, 11:13 PM · Restricted Project, Workboards
jhurwitz added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

According to DarkConsole's services tab, query takes 12s overall.

Jun 22 2015, 9:57 PM · Restricted Project, Workboards

Jun 18 2015

jhurwitz added a comment to T8594: Develop system for dumping/backing up Phriction documents.

That sounds like another great solution option for this problem :)

Jun 18 2015, 7:43 PM · Phriction, Restricted Project

Jun 17 2015

jhurwitz added a project to T8594: Develop system for dumping/backing up Phriction documents: Phriction.
Jun 17 2015, 10:54 PM · Phriction, Restricted Project
jhurwitz created T8594: Develop system for dumping/backing up Phriction documents.
Jun 17 2015, 10:45 PM · Phriction, Restricted Project
jhurwitz created T8592: "View on previous revision" button on ghosted comment can jump to wrong place.
Jun 17 2015, 9:55 PM · Differential, Restricted Project
jhurwitz updated the task description for T8588: One instance has a severe, global performance issue.
Jun 17 2015, 9:11 PM · Restricted Project

Jun 16 2015

jhurwitz added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

I just updated T8522 with some more information -- we had database issues that night (possibly related to the later corruption, unsure) and I can't repro it.

Jun 16 2015, 10:48 PM · Restricted Project, Workboards
jhurwitz closed T8522: Marking a comment as done is very slow as Invalid.

I think this was a fluke. I later discovered that, about 15 minutes before I filed this bug, our database host had gone read-only and we needed to reboot it. This caused transient issues for the rest of the night (eg, none of our phdaemons were running for about an hour until someone kicked them).

Jun 16 2015, 10:47 PM · Differential, Restricted Project
jhurwitz moved T8444: Increase typeahead speed from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 16 2015, 9:12 PM · Typeahead, PHUI, Restricted Project
jhurwitz moved T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error) from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 16 2015, 9:12 PM · Restricted Project, Workboards
jhurwitz added a comment to T8444: Increase typeahead speed.

I would propose that we make this task into: Prefetch/cache 50 users and 50 projects for the typeahead.

Jun 16 2015, 9:12 PM · Typeahead, PHUI, Restricted Project
jhurwitz renamed T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error) from Fatal error while moving a task on a workboard to Moving a task on a workboard is very slow (and sometimes times out with a fatal error).
Jun 16 2015, 9:11 PM · Restricted Project, Workboards
jhurwitz added a comment to T8520: Cannot disable email during batch operations.

Another option: after T5791 is closed, you could temporarily write a global Herald rule to disable emails for the actions you're about to take, then delete the rule when you're done.

Jun 16 2015, 9:02 PM · Restricted Project
jhurwitz added a comment to T7617: Make it easier to know why herald adds reviewers.

I really enjoyed reading this comment thread! :)

Jun 16 2015, 8:57 PM · Restricted Project, Herald
jhurwitz added a comment to T8444: Increase typeahead speed.

Re-running my experiment (typing two characters at a time), AJAX calls are now taking 700-1000 ms.

Jun 16 2015, 8:51 PM · Typeahead, PHUI, Restricted Project
jhurwitz added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

At rPee8de4a, this is (mostly) no longer timing out -- but the AJAX request is taking anywhere from 7 to 29 seconds to complete.

Jun 16 2015, 8:48 PM · Restricted Project, Workboards
jhurwitz moved T8006: drag and drop fails on Workboards from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 16 2015, 8:41 PM · Restricted Project

Jun 12 2015

jhurwitz added a comment to T8483: Odd text in inline comment transaction.

In addition to the text being wrong (it always says "marked 0 inline comments as not done."), I'm observing that state is not being saved -- I mark a bunch of things as done and submit/save, only to see that many have become un-marked as done.

Jun 12 2015, 5:21 AM · Restricted Project, Transactions, Differential
jhurwitz created T8522: Marking a comment as done is very slow.
Jun 12 2015, 5:17 AM · Differential, Restricted Project
jhurwitz moved T8483: Odd text in inline comment transaction from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 12 2015, 5:15 AM · Restricted Project, Transactions, Differential
jhurwitz added a project to T8483: Odd text in inline comment transaction: Restricted Project.
Jun 12 2015, 5:14 AM · Restricted Project, Transactions, Differential

Jun 11 2015

ox awarded Changelog a Yellow Medal token.
Jun 11 2015, 4:03 PM

Jun 10 2015

jhurwitz added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

Yes, it is.

Jun 10 2015, 9:15 PM · Restricted Project, Auth
jhurwitz added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

Some more useful data:

  • Last week (before we upgraded Phabricator), I needed to create a user for something. I created a user from /people/, used ./bin/auth recover to log in as that user, and then the web UI immediately presented me with a "you must verify your email to use the website" screen.
  • Today, I just went through the same steps -- and instead of seeing "you must verify your email," I see the "login failure" page.
  • I checked our database to find a full list of all users with isEmailVerified=0. It's a bunch of really old test accounts, and then new accounts created this week. Every other account on our install is email verified.
  • I double-checked our settings. auth.reuqire-email-verification displays as "false" in the list of all config settings, but when I click into it, it says "Value (Use Default)" and then further clarifies "By default, verification is optional unless auth.email-domains is nonempty." Our auth.email-domains setting is non-empty, so I think we do require email verification.
Jun 10 2015, 9:14 PM · Restricted Project, Auth
jhurwitz added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

auth.require-approval is false
auth.require-email-verification is false

Jun 10 2015, 8:17 PM · Restricted Project, Auth