Page MenuHomePhabricator

Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge
Closed, ResolvedPublic

Description

On Pholio mocks, inline comments that another user has made which have not yet been published incorrectly increase the count on the "number of inline comments" badge UI element.

For example, if an image has one published inline and one unpublished draft inline from another user, it will show "2" for an inline count for that image. This is not correct, because you can not see the second inline. Instead, the badge should show "1".

(If it's your unpublished inline, it should probably show "2".)

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley renamed this task from Inline comments in Pholio are not visible anymore to Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge.Apr 27 2016, 1:06 PM
epriestley triaged this task as Low priority.
epriestley updated the task description. (Show Details)
epriestley added a project: Pholio.
epriestley added a revision: Restricted Differential Revision.Jun 9 2016, 3:19 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jun 9 2016, 3:43 PM
epriestley added a commit: Restricted Diffusion Commit.