Page MenuHomePhabricator
Feed Advanced Search

Feb 19 2021

epriestley closed T12795: Move PHUICircleView to PHUIButtonView as Wontfix.

It appears that PHUICircleView no longer exists, so calling this moot.

Feb 19 2021, 10:55 PM · PHUI

May 23 2019

epriestley moved T12191: Remarkup autocomplete can remain open after keyboard form submission from Backlog to Next on the Remarkup board.
May 23 2019, 2:48 PM · Remarkup, PHUI

Mar 12 2019

epriestley closed T11974: Projects should allow setting of any icon, a subtask of T11971: Build an Icon Typeahead, as Resolved.
Mar 12 2019, 3:17 AM · PHUI

Nov 15 2018

epriestley closed T8440: Tooltip flicker at certain cursor positions as Resolved by committing rPea6d2afa8685: Fix flickering tooltips in Chrome when the tip container overlaps the….
Nov 15 2018, 6:44 PM · PHUI
epriestley added a revision to T8440: Tooltip flicker at certain cursor positions: D19808: Fix flickering tooltips in Chrome when the tip container overlaps the triggering element.
Nov 15 2018, 12:05 PM · PHUI
epriestley added a comment to T8440: Tooltip flicker at certain cursor positions.

Here's the DOM with the tooltip container and timestamp container colored:

Nov 15 2018, 12:03 PM · PHUI

Oct 7 2018

avivey added a comment to T8440: Tooltip flicker at certain cursor positions.

https://discourse.phabricator-community.org/t/differential-ui-tooltip-flicks-on-hover/1970 has some css witchcraft to make this not happen.

Oct 7 2018, 9:42 PM · PHUI

Apr 27 2018

amckinley closed T13128: Phriction document header doesn't render policy strength variations as Resolved by committing rP9a0dd55442d7: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.
Apr 27 2018, 11:56 PM · Policy, PHUI, Phriction

Apr 26 2018

amckinley added a revision to T13128: Phriction document header doesn't render policy strength variations: D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.
Apr 26 2018, 12:06 AM · Policy, PHUI, Phriction

Apr 25 2018

epriestley added a comment to T13128: Phriction document header doesn't render policy strength variations.

I suppose the approach proposed above gets a questionable result here:

Apr 25 2018, 8:43 PM · Policy, PHUI, Phriction
epriestley added a comment to T13128: Phriction document header doesn't render policy strength variations.

After actually looking at the code, it looks like null can already be returned and works, it's just kind of wrong for some objects (like Dashboards) because they really do have a default policy -- it's just hard-coded.

Apr 25 2018, 8:28 PM · Policy, PHUI, Phriction

Apr 24 2018

epriestley added a comment to T13128: Phriction document header doesn't render policy strength variations.

I'm going to tentatively put this (the Phriction rule, specifically) into T13130 for this week although I'm not sure how much work getting getDefaultPolicyForObject() to return the root document policy is and maybe that's Unbelievably Difficult. Let me take a quick look at that and you can either run with it or I can pick it up if it's some kind of weird arcana.

Apr 24 2018, 4:26 PM · Policy, PHUI, Phriction

Apr 18 2018

amckinley lowered the priority of T13128: Phriction document header doesn't render policy strength variations from Normal to Low.
Apr 18 2018, 9:41 PM · Policy, PHUI, Phriction

Mar 21 2018

epriestley closed T11145: Dialog submit buttons don't disable on click as Resolved by committing rPc8583b016daf: When workflow dialog buttons are clicked, disable the button.
Mar 21 2018, 6:58 PM · Restricted Project, PHUI, Bug Report
epriestley added a revision to T11145: Dialog submit buttons don't disable on click: D19246: When workflow dialog buttons are clicked, disable the button.
Mar 21 2018, 6:55 PM · Restricted Project, PHUI, Bug Report

Feb 14 2018

epriestley closed T11478: Build PHUICMSView as Wontfix.

This never got fleshed out into an actionable plan, see T13077 for the next planned phase here.

Feb 14 2018, 2:44 PM · Design, PHUI, Phriction

Feb 12 2018

epriestley removed projects from T12180: Cropped text in Property List: Drydock, Bug Report.
Feb 12 2018, 10:57 PM · PHUI

Aug 28 2017

chad closed T8944: Unread vs read notifications are difficult to distinguish when viewed at an indirect angle on a 13" Macbook Air as Resolved by committing rPed75250f1a9d: Update notification UI a little.
Aug 28 2017, 9:52 PM · PHUI, Notifications
chad added a revision to T8944: Unread vs read notifications are difficult to distinguish when viewed at an indirect angle on a 13" Macbook Air: D18485: Update notification UI a little.
Aug 28 2017, 9:49 PM · PHUI, Notifications

Aug 6 2017

chad closed T7754: View Options Menu doesn't stay relative to the button as Resolved.

No longer reproduces.

Aug 6 2017, 3:55 AM · Mobile, PHUI
chad closed T8122: Unable to scroll on mobile if horizontal scroll is available as Invalid.

No longer valid as far as I can find.

Aug 6 2017, 3:52 AM · Google Chrome, PHUI, Mobile
chad closed T9868: PHUIDocumentViewPro ToC menu improvements as Resolved.
Aug 6 2017, 2:48 AM · PHUI
chad closed T12099: Implement caret as part of PHUIIconView as Resolved.

caret now appears when attaching dropdown menus to buttons.

Aug 6 2017, 2:47 AM · PHUI, Design
chad closed T9974: Create PHUIObjectItemMiniView as Wontfix.
Aug 6 2017, 2:46 AM · PHUI

Jun 4 2017

chad created T12795: Move PHUICircleView to PHUIButtonView.
Jun 4 2017, 10:59 PM · PHUI

May 26 2017

epriestley removed a project from T9868: PHUIDocumentViewPro ToC menu improvements: Customer Impact.

I think D18025 reasonably covered the immediate request we received, so just kicking this off the board until the next Phriction iteration.

May 26 2017, 4:19 PM · PHUI
chad added a revision to T9868: PHUIDocumentViewPro ToC menu improvements: D18025: Add a little style to Phriction ToC menu.
May 26 2017, 4:00 PM · PHUI
epriestley moved T9868: PHUIDocumentViewPro ToC menu improvements from Backlog to Requests on the Customer Impact board.
May 26 2017, 2:00 PM · PHUI
epriestley added a project to T9868: PHUIDocumentViewPro ToC menu improvements: Customer Impact.
May 26 2017, 2:00 PM · PHUI

May 9 2017

gregprice changed the status of T8588: One instance has a severe, global performance issue, a subtask of T8444: Increase typeahead speed, from Wontfix to Resolved.
May 9 2017, 2:14 AM · Typeahead, PHUI, Restricted Project

Apr 21 2017

chad reopened T9868: PHUIDocumentViewPro ToC menu improvements as "Open".

No no, I am wrong. I did plan this into the mocks.

Apr 21 2017, 4:17 PM · PHUI
chad closed T9868: PHUIDocumentViewPro ToC menu improvements as Wontfix.

No plans to move forward with this.

Apr 21 2017, 4:11 PM · PHUI

Apr 17 2017

chad closed T12577: Icon buttons in Calendar for "Next Month" / "Previous Month" are aligned awkwardly as Resolved by committing rPecbeec35b263: Tweak some icon buttons.
Apr 17 2017, 9:37 PM · PHUI, Design, Calendar
chad added a revision to T12577: Icon buttons in Calendar for "Next Month" / "Previous Month" are aligned awkwardly: D17709: Tweak some icon buttons.
Apr 17 2017, 9:35 PM · PHUI, Design, Calendar
chad claimed T12577: Icon buttons in Calendar for "Next Month" / "Previous Month" are aligned awkwardly.
Apr 17 2017, 9:00 PM · PHUI, Design, Calendar
epriestley renamed T12577: Icon buttons in Calendar for "Next Month" / "Previous Month" are aligned awkwardly from Icon buttons in Calendar are aligned awkwardly to Icon buttons in Calendar for "Next Month" / "Previous Month" are aligned awkwardly.
Apr 17 2017, 6:02 PM · PHUI, Design, Calendar
epriestley created T12577: Icon buttons in Calendar for "Next Month" / "Previous Month" are aligned awkwardly.
Apr 17 2017, 6:02 PM · PHUI, Design, Calendar
epriestley closed T7978: Persist document scroll position across "back" navigation in Quicksand as Resolved.

I believe the resolution of T8151 also resolved this.

Apr 17 2017, 12:06 PM · Quicksand, PHUI

Apr 10 2017

epriestley closed T12503: Curtain sections may overflow boundaries in the UI as Resolved by committing rP5cf53f7b3b42: Fix some minor curtain overflow/wrap issues.
Apr 10 2017, 11:02 PM · PHUI
epriestley added a revision to T12503: Curtain sections may overflow boundaries in the UI: D17650: Fix some minor curtain overflow/wrap issues.
Apr 10 2017, 10:09 PM · PHUI
epriestley closed T12504: Files "Temporary" badge is white-on-grey as Resolved by committing rP49132b884b6f: Sell Yellow! Buy Indigo!.
Apr 10 2017, 10:01 PM · Files, PHUI
epriestley added a revision to T12504: Files "Temporary" badge is white-on-grey: D17649: Sell Yellow! Buy Indigo!.
Apr 10 2017, 9:57 PM · Files, PHUI

Apr 4 2017

chad added a comment to T12504: Files "Temporary" badge is white-on-grey.

1mon9v.jpg (400×600 px, 63 KB)

Apr 4 2017, 9:01 PM · Files, PHUI
epriestley moved T12504: Files "Temporary" badge is white-on-grey from Backlog to vNext on the Files board.
Apr 4 2017, 6:56 PM · Files, PHUI
epriestley created T12504: Files "Temporary" badge is white-on-grey.
Apr 4 2017, 6:56 PM · Files, PHUI
epriestley created T12503: Curtain sections may overflow boundaries in the UI.
Apr 4 2017, 6:52 PM · PHUI

Mar 28 2017

epriestley closed T8588: One instance has a severe, global performance issue, a subtask of T8444: Increase typeahead speed, as Wontfix.
Mar 28 2017, 10:26 PM · Typeahead, PHUI, Restricted Project

Mar 27 2017

chad moved T12139: Add a proper emoji picker to Remarkup bar from Backlog to Tomfoolery on the Remarkup board.
Mar 27 2017, 4:01 PM · Remarkup, PHUI

Mar 23 2017

chad triaged T12273: Single input/typeahead dialogs should be consistently simpler as Wishlist priority.
Mar 23 2017, 6:40 PM · PHUI, Design

Mar 19 2017

epriestley closed T12417: Show failing status of Diffusion repositories in top main menu bar. as Wontfix.
Mar 19 2017, 12:07 AM · Diffusion, PHUI, Feature Request

Mar 18 2017

eliaspro created T12417: Show failing status of Diffusion repositories in top main menu bar..
Mar 18 2017, 11:09 PM · Diffusion, PHUI, Feature Request

Mar 9 2017

chad closed T12326: Long tag names can break out of hovercards as Resolved by committing rP3277d8b8c822: Use text ellipsis on hovercard tags.
Mar 9 2017, 7:09 PM · Bug Report, Hovercards, PHUI
chad added a revision to T12326: Long tag names can break out of hovercards: D17486: Use text ellipsis on hovercard tags.
Mar 9 2017, 7:06 PM · Bug Report, Hovercards, PHUI

Mar 8 2017

chad closed T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead as Resolved by committing rP2ebdf2e080d1: Remove server side limit on policy control names.
Mar 8 2017, 12:38 AM · PHUI, Bug Report
chad closed T12366: Long Project names outgrow dropdown widget as Resolved by committing rP683b0221c33c: Fix long project names in policy controls.
Mar 8 2017, 12:36 AM · PHUI, Bug Report

Mar 7 2017

chad added a revision to T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead: D17479: Remove server side limit on policy control names.
Mar 7 2017, 9:29 PM · PHUI, Bug Report
chad added a comment to T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead.

But other interfaces around Phabricator are not going to fair as well, just FYI.

Mar 7 2017, 9:25 PM · PHUI, Bug Report
chad added a comment to T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead.

Server side reduces this quite a bit:

Mar 7 2017, 9:25 PM · PHUI, Bug Report
chad added a comment to T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead.

We can look at the server side issue, but we already have text-overflow on this element, so it's not going to resolve the core problem.

Mar 7 2017, 9:14 PM · PHUI, Bug Report
eliaspro added a comment to T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead.

I agree that long project names might a problem on its own - but for now this was a compromise I had to make to compensate for the fact that projects are just "generic" containers which can't be further classified to distinguish between ACL groups/projects/tags.

Mar 7 2017, 9:13 PM · PHUI, Bug Report
chad added a comment to T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead.

This is working as intended. If you choose significantly long project names, many pieces of Phabricator will naturally become less useful and more difficult for you users to use.

Mar 7 2017, 9:02 PM · PHUI, Bug Report
eliaspro created T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead.
Mar 7 2017, 8:00 PM · PHUI, Bug Report
eliaspro updated the task description for T12366: Long Project names outgrow dropdown widget.
Mar 7 2017, 7:55 PM · PHUI, Bug Report
chad added a revision to T12366: Long Project names outgrow dropdown widget: D17478: Fix long project names in policy controls.
Mar 7 2017, 7:53 PM · PHUI, Bug Report
eliaspro added a project to T12366: Long Project names outgrow dropdown widget: PHUI.
Mar 7 2017, 7:21 PM · PHUI, Bug Report

Mar 3 2017

chad triaged T12348: Allow any IconSet to be extended as Low priority.
Mar 3 2017, 9:50 PM · PHUI, Design
chad added a comment to T12273: Single input/typeahead dialogs should be consistently simpler.

I already have an open task on making typeahead-only dialogs simpler, better, so merging into here.

Mar 3 2017, 9:49 PM · PHUI, Design
chad merged T12341: Set cursor default focus to input field when selecting "Other Project" from access policy dropdown into T12273: Single input/typeahead dialogs should be consistently simpler.
Mar 3 2017, 9:49 PM · PHUI, Design
chad created T12348: Allow any IconSet to be extended.
Mar 3 2017, 9:48 PM · PHUI, Design
chad closed T9010: Allow badges to have any Font Awesome icon, a subtask of T11971: Build an Icon Typeahead, as Resolved.
Mar 3 2017, 9:47 PM · PHUI

Feb 28 2017

20after4 added a comment to T12326: Long tag names can break out of hovercards.

This actually seems a little difficult to fix...maybe just make it truncate with an ellipsis?

Feb 28 2017, 1:47 AM · Bug Report, Hovercards, PHUI
20after4 added a comment to T12326: Long tag names can break out of hovercards.

heh nice. And I didn't even have to cheat by using U+00A0.

Feb 28 2017, 1:41 AM · Bug Report, Hovercards, PHUI

Feb 27 2017

chad updated subscribers of T12326: Long tag names can break out of hovercards.

@20after4 😆

Feb 27 2017, 11:15 PM · Bug Report, Hovercards, PHUI
chad created T12326: Long tag names can break out of hovercards.
Feb 27 2017, 11:15 PM · Bug Report, Hovercards, PHUI

Feb 18 2017

avivey added a comment to T10687: jx-tooltip does whatever it feels like.

Some more shenanigans:

Feb 18 2017, 8:13 AM · PHUI, Bug Report

Feb 15 2017

chad updated the task description for T12273: Single input/typeahead dialogs should be consistently simpler.
Feb 15 2017, 9:19 PM · PHUI, Design
chad created T12273: Single input/typeahead dialogs should be consistently simpler.
Feb 15 2017, 9:19 PM · PHUI, Design
chad updated subscribers of T12139: Add a proper emoji picker to Remarkup bar.

@beng pointed out this resource for future use: http://cldr.unicode.org/

Feb 15 2017, 9:16 PM · Remarkup, PHUI

Feb 8 2017

chad closed T11973: Dashboards should allow setting of an icon, a subtask of T11971: Build an Icon Typeahead, as Resolved.
Feb 8 2017, 7:54 PM · PHUI
jcox merged T12231: Projects with very long names cause menu bar to overlap workboard into T12214: Navigation menus in applications have no maximum width.
Feb 8 2017, 3:23 PM · PHUI

Feb 7 2017

chad closed T9336: Link profile image in feed as Resolved by committing rP638f2a012b2d: Add AuthorHref to feed story images.
Feb 7 2017, 6:09 PM · Badge Awarded, PHUI
fosskevin added a comment to T9336: Link profile image in feed.

Is there any way to sort Differential diffs by how simple the change is? Is there a tag for small bug fixes so newbs can come in and see how a small problem was fixed?

Feb 7 2017, 6:08 PM · Badge Awarded, PHUI
fosskevin added a comment to T9336: Link profile image in feed.

Thanks!

Feb 7 2017, 6:01 PM · Badge Awarded, PHUI
chad added a comment to T9336: Link profile image in feed.

There is a Badge Awarded tag for easy-ish contributions.

Feb 7 2017, 5:58 PM · Badge Awarded, PHUI
chad added a comment to T9336: Link profile image in feed.

Unfortunately if it's a 5-10 minute bug fix, we'll just fix it.

Feb 7 2017, 5:57 PM · Badge Awarded, PHUI
fosskevin added a comment to T9336: Link profile image in feed.

Poking around the source code was fun. Please find time to put up minor issues like these for newbs. Thanks :)

Feb 7 2017, 5:52 PM · Badge Awarded, PHUI
chad added a revision to T9336: Link profile image in feed: D17322: Add AuthorHref to feed story images.
Feb 7 2017, 5:45 PM · Badge Awarded, PHUI
chad added a comment to T9336: Link profile image in feed.

It took me a little, but I found the source and fixed it. Sorry, this was probably a bit hairier than expected.

Feb 7 2017, 5:45 PM · Badge Awarded, PHUI
chad added a comment to T9336: Link profile image in feed.

I don't know where the bug is, so I'm not sure how to guide you to fix it without fixing it myself.

Feb 7 2017, 5:39 PM · Badge Awarded, PHUI
fosskevin added a comment to T9336: Link profile image in feed.

Is it in PhabricatorFeedStory or PhabricatorFeedBuilder from the folder src/applications/feed. If I'm looking in the wrong place, could you please clarify what you meant as "level or two up".

Feb 7 2017, 5:36 PM · Badge Awarded, PHUI
chad added a comment to T9336: Link profile image in feed.

I'd say it's a level or two up from the view controller, since setImageHref exists in PHUIFeedStory, but isn't being called.

Feb 7 2017, 5:10 PM · Badge Awarded, PHUI
fosskevin added a comment to T9336: Link profile image in feed.

I just noticed this task as a beginner task. Shall I try to fix this?

Feb 7 2017, 5:01 PM · Badge Awarded, PHUI

Feb 6 2017

chad added a comment to T12214: Navigation menus in applications have no maximum width.

I was joking.

Feb 6 2017, 5:03 PM · PHUI
epriestley added a comment to T12214: Navigation menus in applications have no maximum width.

(Maybe the real user report was something only indirectly related, like putting the query on a Dashboard? That would make sense given that the name talks about dashboards...)

Feb 6 2017, 4:58 PM · PHUI
chad closed T12214: Navigation menus in applications have no maximum width as Resolved by committing rPb33bb3714bdb: Add some max-width to basic-nav.
Feb 6 2017, 4:58 PM · PHUI
chad added a comment to T12214: Navigation menus in applications have no maximum width.

oh, yeah I meant just with searches.

Feb 6 2017, 4:56 PM · PHUI
chad added a revision to T12214: Navigation menus in applications have no maximum width: D17318: Add some max-width to basic-nav.
Feb 6 2017, 4:55 PM · PHUI
epriestley added a comment to T12214: Navigation menus in applications have no maximum width.

I think it should use the same global/personal paradigm (let administrators save Global queries, supplementing the current ability for users to save personal queries).

Feb 6 2017, 4:55 PM · PHUI
chad added a comment to T12214: Navigation menus in applications have no maximum width.

I was thinking menu item could work in ApplicationSearch as well, the Global/Personal menu paradigm.

Feb 6 2017, 4:50 PM · PHUI
chad added a comment to T12214: Navigation menus in applications have no maximum width.

See https://secure.phabricator.com/book/phabcontrib/article/feature_requests/#hypotheticals

Feb 6 2017, 4:49 PM · PHUI