Page MenuHomePhabricator
Create Task
Maniphest T11145

Dialog submit buttons don't disable on click
Closed, ResolvedPublic
Actions

Description

I have seen this bug manifest in two different ways:

  1. Duplicate tickets are created.
  2. Duplicate transactions are created.

See the transactions on T11143 and T11144 for an example. In order to reproduce this issue, you should be able to follow these steps:

  1. Create a new Maniphest task and fill out all relevant details (they aren't important here).
  2. Click on the "Create New Task" button several times in quick succession. More clicks gives you more XP.

The same steps apply to the "Merge Duplicate Tasks" workflow as well.

Revisions and Commits

rP Phabricator
D19246rPc8583b016daf When workflow dialog buttons are clicked, disable the button

Related Objects

Event Timeline

joshuaspence created this task.Jun 14 2016, 3:49 AM
Herald added a subscriber: eadler. · View Herald TranscriptJun 14 2016, 3:49 AM
chad added a subscriber: chad.EditedJun 14 2016, 4:12 AM

I can't reproduce locally or on Phacility in Chrome/Mac. Is there a specific browser/os I should test?

joshuaspence added a comment.Jun 14 2016, 4:16 AM

I am using Chrome on Ubuntu, but I don't think k the browser/OS has much to do with it. I'm guessing that you can't reproduce it because you have more internets than I do. If you can artificially throttle the connection speed then it might be easier to reproduce.

chad added a comment.Jun 14 2016, 4:24 AM

Wouldn't form re-submission be disabled through javascript on the client?

chad added a comment.Jun 14 2016, 4:26 AM

Does the submit button not go "disabled" when you click on it? JS should be immediately doing this. I can't not get it to do this on anything I test.

joshuaspence added a comment.Jun 14 2016, 5:01 AM

Ah I see. So for the "create ticket" workflow, it only seems to happen when creating a ticket from a workboard. In this case, I do not see the button go disabled.

chad added a comment.Jun 14 2016, 5:08 AM

Nice! I was able to duplicate that. Might be all? dialogs.

chad renamed this task from Race conditions with form submissions to Dialog submit buttons don't disable on click.Jun 14 2016, 8:11 PM
chad edited projects, added PHUI; removed Maniphest, Transactions.
chad added a subscriber: epriestley.
eadler added a project: Restricted Project.Jun 16 2016, 6:26 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jun 16 2016, 6:28 PM
epriestley merged a task: T11262: On slow connections, it's possible to submit the Create Task form on workboards multiple times.Jul 3 2016, 8:37 AM
epriestley added a subscriber: hach-que.
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:02 PM
avivey mentioned this in Z1336: General Chat.Aug 17 2016, 11:28 PM
avivey added a subscriber: avivey.Aug 18 2016, 12:24 AM

https://secure.phabricator.com/diffusion/P/browse/master/webroot/rsrc/js/core/behavior-form.js:57
looks like it's supposed to be listening to submit, but there's no submit event being fired while in a dialog; It does fire when the same dialog is loaded as a full-page, so some magic is happening there.

There's also a lot of if (workflow) return; in that file, which makes me think dialogs are supposed to handle their own submit?

epriestley mentioned this in T13058: Indicate that the "upload file" modal dialog is doing something when uploading large files.Feb 1 2018, 3:07 AM
epriestley mentioned this in T13108: Plans: 2018 Week 12 Bonus Content.Mar 21 2018, 6:20 PM
epriestley added a revision: D19246: When workflow dialog buttons are clicked, disable the button.Mar 21 2018, 6:54 PM
epriestley closed this task as Resolved by committing rPc8583b016daf: When workflow dialog buttons are clicked, disable the button.Mar 21 2018, 6:58 PM
epriestley added a commit: rPc8583b016daf: When workflow dialog buttons are clicked, disable the button.
Phabricator · Built by Phacility