Page MenuHomePhabricator

Persist document scroll position across "back" navigation in Quicksand
Closed, ResolvedPublic

Description

When navigating in phab (without the chat bar), using the browser's back button, the page we return to jumps to the top of the page.

Expected (and common) behavior is to return to the same offset in the page as we navigated away from.

(42.0.2311.90 m (64-bit), Windows)

Event Timeline

avivey raised the priority of this task from to Needs Triage.
avivey updated the task description. (Show Details)
avivey added a subscriber: avivey.

I believe there is a wontfix duplicate floating around somewhere.

We can possibly fake this with Quickling in the common case once we summon the courage to enable it without the column open.

bring the native scrollbars back?

Can Quicksand save scroll position? The page reload thing would be User Delight

chad moved this task from Backlog to Scrollbar on the PHUI board.

Disabling the pretty scrollbar alone wouldn't fix this without also removing the container frame which enables the chat column to exist.

Why can the darkconsole work without all this magic and not the chat column?

DarkConsole shares the same scrollbar with the rest of the page, but the chat column has its own scrollbar, and needs to scroll independently of the main page content.

We could float it at the right of the page instead of framing the page, but then you get two scrollbars at the far right: the chat column scrollbar, then the main page scrollbar. This is pretty ugly and can be confusing, since the leftmost scrollbar doesn't control page content and the page scrollbar isn't adjacent to the content it affects.

This is ultimately an issue of tradeoffs. It's arguable that the price we're paying to make the scrollbars work like they would if this were a desktop application is too high, but so far most of the downsides of custom scrollbars have been (or can be) mitigated. We can mitigate this one after T7573.

What about floating the chat column on the left side of the page? Or moving the native scrollbars to to the left side of the main frame (http://jsfiddle.net/avrahamcool/uPwfn/1/)?

Once you have chat and nav, you're taking up 40% of the page before the user's content even starts. I think it'd feel a bit awkward.

RTL doesn't flip scrollbars for me on that fiddle:

Screen Shot 2015-04-28 at 11.12.14 AM.png (1×776 px, 65 KB)

There's no technical reason we couldn't put chat on the far left, but it would be an unusual decision for the product. Sites like Facebook, Google and Twitch all put chat on the right. Dropbox just launched a new feature with chat on the right:

commenting_ss_final.png (760×1 px, 183 KB)

The only product I'm aware of offhand with left-chat is Quip.

The left also has commonly-used navigation elements, and they'll move around with a conditional chat bar. We also show the filetree on the left.

I guess I value the native scrollbars way more than you do.

epriestley renamed this task from browser BACK jumps to top of page to Persist document scroll position across "back" navigation in Quicksand.May 4 2015, 1:33 PM
epriestley claimed this task.

I believe the resolution of T8151 also resolved this.