- User Since
- Mar 6 2011, 12:49 AM (411 w, 2 d)
Mar 22 2017
Hmm, I could definitely see "Philters" in the near future! Imagine the sponsorship opportunities to add Branded Comments™ via Phabricator® Philters™.
@epriestley: Yeah, I think the brightness level is off. I got a very dark picture as well, although it wasn't all-black.
@epriestley: Evidently imagesnap no longer works on macOS 10.11 "El Capitan":
That would be revealing whether or not FB has already been internally A/B testing precisely this on engineers.
I view this as a really effective mechanism to ensure timely code review. Don't review my diff within 24 hours? Poof, code is deleted.
Jul 29 2015
I strongly recommend a standard panda icon be shipped as a recommended alternate icon.
Sep 29 2014
This would fix all collation issues and make sorting locale-dependent, but allow "Diffusion" and "DIFFUSION" again without collision.
Makes sense. Could just do that now, of course..
Sure—as long as the original data is present and we can rebuild collation indices later, it probably doesn't matter too much. (I'm not sure how the migration would work, but hopefully it's not lossy.)
For now, it seems like we don't need to do that -- in all cases where we ORDER BY a column (i.e., want utf8mb4_unicode_ci collation), collisions are either irrelevant (there's no unique key on the column) or collating is correct (we do want projects named "Diffusion" and "DIFFUSION" to collide). See D10602 for details.
Remember that comparing two strings ignoring differences in case (or accents, etc.) is a fairly locale-specific operation. The default Unicode collation algorithm tries to be as agnostic as it can of locale rules, but it falls down spectacularly for a few languages.
Consider using column-level collation directives on a secondary column used only for collation so you don't affect the primary key.