Page MenuHomePhabricator

beng (Ben Hamilton)
Guru Meditation Error

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 6 2011, 12:49 AM (432 w, 4 d)
Availability
Available

Recent Activity

Mar 22 2017

beng added a comment to T12441: Implement "Phabricator Stories".

🔥 🔥 🔥

Mar 22 2017, 9:03 PM
beng added a comment to T12441: Implement "Phabricator Stories".

Hmm, I could definitely see "Philters" in the near future! Imagine the sponsorship opportunities to add Branded Comments™ via Phabricator® Philters™.

Mar 22 2017, 8:58 PM
beng added a comment to T12441: Implement "Phabricator Stories".

@epriestley: Yeah, I think the brightness level is off. I got a very dark picture as well, although it wasn't all-black.

Mar 22 2017, 8:36 PM
beng added a comment to T12441: Implement "Phabricator Stories".

@epriestley: Evidently imagesnap no longer works on macOS 10.11 "El Capitan":

Mar 22 2017, 7:56 PM
beng added a comment to T12441: Implement "Phabricator Stories".

That would be revealing whether or not FB has already been internally A/B testing precisely this on engineers.

Mar 22 2017, 7:51 PM
beng added a comment to T12441: Implement "Phabricator Stories".

I view this as a really effective mechanism to ensure timely code review. Don't review my diff within 24 hours? Poof, code is deleted.

Mar 22 2017, 7:49 PM
beng added a comment to T12441: Implement "Phabricator Stories".

+1

Mar 22 2017, 7:45 PM

Jul 29 2015

beng added a comment to T4214: Allow installs to change or supplement the "Phabricator" icon.

I strongly recommend a standard panda icon be shipped as a recommended alternate icon.

Jul 29 2015, 10:08 PM · Design

Sep 29 2014

beng added a comment to D10602: Use binary collations for most text.

This would fix all collation issues and make sorting locale-dependent, but allow "Diffusion" and "DIFFUSION" again without collision.

Sep 29 2014, 6:30 PM
beng added a comment to D10602: Use binary collations for most text.

Makes sense. Could just do that now, of course..

Sep 29 2014, 6:29 PM
beng added a comment to D10602: Use binary collations for most text.

Sure—as long as the original data is present and we can rebuild collation indices later, it probably doesn't matter too much. (I'm not sure how the migration would work, but hopefully it's not lossy.)

Sep 29 2014, 5:30 PM
beng added a comment to T1191: Comments are truncated at first non-base-plane character.

For now, it seems like we don't need to do that -- in all cases where we ORDER BY a column (i.e., want utf8mb4_unicode_ci collation), collisions are either irrelevant (there's no unique key on the column) or collating is correct (we do want projects named "Diffusion" and "DIFFUSION" to collide). See D10602 for details.

Sep 29 2014, 4:03 PM · Wikimedia, Support Impact, High Support Impact, Differential
beng added a comment to D10602: Use binary collations for most text.

Remember that comparing two strings ignoring differences in case (or accents, etc.) is a fairly locale-specific operation. The default Unicode collation algorithm tries to be as agnostic as it can of locale rules, but it falls down spectacularly for a few languages.

Sep 29 2014, 4:01 PM
beng added a comment to T1191: Comments are truncated at first non-base-plane character.

Consider using column-level collation directives on a secondary column used only for collation so you don't affect the primary key.

Sep 29 2014, 3:42 PM · Wikimedia, Support Impact, High Support Impact, Differential