Page MenuHomePhabricator
Feed Advanced Search

Aug 4 2017

epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Restricted Differential Revision.
Aug 4 2017, 3:14 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 4 2017, 12:33 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

PHI27 is likely adjacent here.

Aug 4 2017, 11:40 AM · Restricted Project, Search

Aug 3 2017

epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Aug 3 2017, 9:37 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Aug 3 2017, 7:39 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Aug 3 2017, 7:20 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Aug 3 2017, 6:41 PM · Phacility, Support
epriestley merged T12950: Regenerating thumbnails for memes is difficult into T5258: Memes use older image transform code without modern error handling.
Aug 3 2017, 5:40 PM · Restricted Project, Files, Macros
epriestley merged task T12950: Regenerating thumbnails for memes is difficult into T5258: Memes use older image transform code without modern error handling.
Aug 3 2017, 5:40 PM · Feature Request, Macros
epriestley added a comment to T12950: Regenerating thumbnails for memes is difficult.

I'm just going to merge this into T5258. There are two separate issues here:

Aug 3 2017, 5:40 PM · Feature Request, Macros
epriestley renamed T12948: Remove the `bin/files purge` workflow from `bin/files purge` can run out of memory for large files to Remove the `bin/files purge` workflow.
Aug 3 2017, 2:53 PM · Bug Report, Files
epriestley added a comment to T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.

I retargeted this; I think the proposed solution is not the best solution we can find to the problem.

Aug 3 2017, 2:53 PM · Bug Report, Files, Setup
epriestley renamed T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource from CloudFront documentation should recommend forwarding query string to File transform regeneration should not rely on passing a query string to a CDN'able resource.
Aug 3 2017, 2:52 PM · Bug Report, Files, Setup

Aug 2 2017

epriestley added a revision to T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index: Unknown Object (Differential Revision).
Aug 2 2017, 11:03 PM · Customer Impact, Search
epriestley added a comment to T5523: Make bulk moves easier on Workboards.

See Planning for information on progress and priorities.

Aug 2 2017, 6:02 PM · Restricted Project, Workboards
epriestley added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

This is an unusually low-tech solution but I can't think of any reasons why it won't work.

Aug 2 2017, 4:46 PM · Dashboards
epriestley renamed T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one from If a ProfileMenu has Link items, and one or more have request URI as the link target, highlight the first one to If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.
Aug 2 2017, 4:43 PM · Dashboards
epriestley renamed T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one from Build a Workboard Query MenuItem? to If a ProfileMenu has Link items, and one or more have request URI as the link target, highlight the first one.
Aug 2 2017, 4:40 PM · Dashboards
epriestley added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

Is there any reason that the rule "if any menu items have the same link target as the request URI, highlight the first one" wouldn't work?

Aug 2 2017, 4:37 PM · Dashboards
epriestley added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.
  • What's the root problem?
  • Why can't they use links?
  • How is this different from T12374?
Aug 2 2017, 4:31 PM · Dashboards
epriestley triaged T12947: Hard to detect typos in *.edit endpoints as Wishlist priority.
Aug 2 2017, 2:58 PM · Conduit, ApplicationEditor
epriestley triaged T12948: Remove the `bin/files purge` workflow as Wishlist priority.

We should probably just remove this workflow, it's not clear to me that there's ever any reason for anyone to run bin/files purge in the modern codebase.

Aug 2 2017, 2:53 PM · Bug Report, Files
epriestley added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Have you enabled diffusion.allow-http-auth?

Aug 2 2017, 12:19 PM · Feature Request

Aug 1 2017

epriestley added a comment to T12932: GC old Differential changesets into File storage.

Just keeping an eye on this: growth on these shards is slow and both are still below the 80% caution threshold, so I'm punting this for another week.

Aug 1 2017, 4:03 PM · Files, Differential, Phacility, Ops
epriestley closed T12946: When users `bin/remove destroy` a repository, emit a reminder message about paths on disk as Resolved by committing Restricted Diffusion Commit.
Aug 1 2017, 3:57 PM · Diffusion
epriestley added a revision to T12946: When users `bin/remove destroy` a repository, emit a reminder message about paths on disk: Unknown Object (Differential Revision).
Aug 1 2017, 3:53 PM · Diffusion
epriestley closed T12942: Add a "Binary Versions" page to Config as Resolved by committing Restricted Diffusion Commit.
Aug 1 2017, 2:14 PM · Config
NDKilla awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Aug 1 2017, 12:11 PM · Workboards (v3), Restricted Project

Jul 31 2017

epriestley created T12946: When users `bin/remove destroy` a repository, emit a reminder message about paths on disk.
Jul 31 2017, 9:07 PM · Diffusion
avivey awarded T12942: Add a "Binary Versions" page to Config a 100 token.
Jul 31 2017, 7:50 PM · Config
epriestley added a revision to T12942: Add a "Binary Versions" page to Config: Unknown Object (Differential Revision).
Jul 31 2017, 7:23 PM · Config
epriestley added a revision to T12942: Add a "Binary Versions" page to Config: Unknown Object (Differential Revision).
Jul 31 2017, 7:19 PM · Config
epriestley closed T12945: "Mismatched origin" error on pulls may show credentials when origins have HTTP credentials as Resolved by committing Restricted Diffusion Commit.
Jul 31 2017, 4:43 PM · Diffusion
epriestley added a revision to T12945: "Mismatched origin" error on pulls may show credentials when origins have HTTP credentials: Unknown Object (Differential Revision).
Jul 31 2017, 4:42 PM · Diffusion
epriestley added a project to T12945: "Mismatched origin" error on pulls may show credentials when origins have HTTP credentials: Diffusion.
Jul 31 2017, 2:07 PM · Diffusion
epriestley created T12945: "Mismatched origin" error on pulls may show credentials when origins have HTTP credentials.
Jul 31 2017, 2:07 PM · Diffusion

Jul 30 2017

epriestley closed T12943: titulo de ejemplo as Invalid.
Jul 30 2017, 1:55 PM
epriestley closed T12944: titulo de ejemplo as Invalid.
Jul 30 2017, 1:55 PM

Jul 29 2017

epriestley added a comment to T11456: Don't lose user in NUX flow because of Timezone issues.

Most browsers can only give us a timezone offset, like "UTC-7", not a locale name like "America/Los_Angeles". We already attempt to read this value (D15962, T3025#176547) but when I wrote that stuff it was only available in Chrome and not necessarily reliable. We do try to guess the default zone selection based on the information we get from the browser, but currently ask the user to confirm it in all cases.

Jul 29 2017, 12:40 PM · Design, Phacility, NUX
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

@kfsone Are you aware of arc diff --only (briefly mentioned above -- "just generate a diff to look at in the web UI, without other slow/complicated steps")? How do you picture arc selfreview differing from arc diff --only?

Jul 29 2017, 2:03 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Jul 28 2017

epriestley edited the content of Changelog.
Jul 28 2017, 10:24 PM
epriestley created 2017 Week 30 (Very Late July).
Jul 28 2017, 10:17 PM
epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

The simplest way to approach this is probably to do double writes: start writing the new tables, switch readers over, stop writing the old tables.

Jul 28 2017, 9:46 PM · Customer Impact, Diffusion, Bug Report
epriestley renamed T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs from "The ref "master" is ambiguous in this repository" in rP to Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.
Jul 28 2017, 6:37 PM · Customer Impact, Diffusion, Bug Report
epriestley added a comment to T12942: Add a "Binary Versions" page to Config.

This could also just go on the existing page at the bottom. We tell people to copy/paste it when submitting bug reports, but it's probably fine if they're including more information, especially since there is a nice walled garden moat around my personally having to deal with it.

Jul 28 2017, 6:20 PM · Config
epriestley added a comment to T12942: Add a "Binary Versions" page to Config.

See also PHI22.

Jul 28 2017, 6:18 PM · Config
epriestley created T12942: Add a "Binary Versions" page to Config.
Jul 28 2017, 6:15 PM · Config
epriestley added a comment to T2383: Run PHP environment checks from CLI.

T12941 is a third case of a user with no mysql or mysqli.

Jul 28 2017, 10:55 AM · Setup
epriestley merged T12941: missing mysql extension incredibly difficult to debug into T2383: Run PHP environment checks from CLI.
Jul 28 2017, 10:54 AM · Setup
epriestley merged task T12941: missing mysql extension incredibly difficult to debug into T2383: Run PHP environment checks from CLI.
Jul 28 2017, 10:54 AM

Jul 27 2017

epriestley added a comment to T12940: Account Setup Issues shown to users before signing TOS.

The particulars in T8918 are slightly different, but the root issue (showing too much stuff to users with partial sessions) is the same.

Jul 27 2017, 9:24 PM
epriestley merged T12940: Account Setup Issues shown to users before signing TOS into T8918: Header shows number of notifications and various other controls on the 2FA auth screen.
Jul 27 2017, 9:23 PM · Security, Auth
epriestley merged task T12940: Account Setup Issues shown to users before signing TOS into T8918: Header shows number of notifications and various other controls on the 2FA auth screen.
Jul 27 2017, 9:23 PM
epriestley merged T11639: InvalidArgumentException when clicking "Show Older Changes" on diff into T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Jul 27 2017, 4:53 PM · Quicksand, Bug Report
epriestley merged task T11639: InvalidArgumentException when clicking "Show Older Changes" on diff into T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Jul 27 2017, 4:53 PM · Restricted Project, Bug Report
epriestley closed T11835: Diffs/Patches should optionally not be generated for generated files until the item is expanded. as Invalid.

This is vague and may not actually identify a problem; I don't plan to pursue it.

Jul 27 2017, 4:50 PM · Diffusion, Feature Request
epriestley closed T11989: Wage an endless war against HP Printer Fax Support as Resolved.

We've closed registration on this install, mooting this.

Jul 27 2017, 4:45 PM · Abuse
epriestley closed T11989: Wage an endless war against HP Printer Fax Support, a subtask of T10215: Provide tools to combat and recover from abuse, as Resolved.
Jul 27 2017, 4:45 PM · Abuse
epriestley closed T12136: What to do with "Application Counts" with MenuItem, a subtask of T11957: Add MenuEngine to Home, as Wontfix.
Jul 27 2017, 4:42 PM · Profile Menu Item, Dashboards
epriestley closed T12136: What to do with "Application Counts" with MenuItem as Wontfix.

Dropping these doesn't seem to have caused any major pushback.

Jul 27 2017, 4:42 PM · Profile Menu Item
epriestley closed T12208: Collapsable Menu Item as Resolved.

This presumably counts as "not much interest" or should move to Discourse now or something, maybe.

Jul 27 2017, 4:32 PM · Profile Menu Item
epriestley merged T12278: Choose specific form on Create Subtask into T12588: create subtask side menu to allow creation of subtasks of different types to the parent task.
Jul 27 2017, 4:29 PM · Feature Request
epriestley merged task T12278: Choose specific form on Create Subtask into T12588: create subtask side menu to allow creation of subtasks of different types to the parent task.
Jul 27 2017, 4:29 PM · Maniphest, Feature Request
epriestley closed T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way as Wontfix.

This seems to mostly be a matter of taste, and we already have behavior similar to the behavior of git, which seems reasonable.

Jul 27 2017, 4:28 PM · Diffusion, Feature Request
epriestley closed T12292: Diffusion commit details references HEAD -> master broken as Invalid.

We don't have reproduction steps for this and thus can't move forward.

Jul 27 2017, 4:26 PM · Bug Report (Needs Information)
epriestley merged T12308: Access forbidden on homepage if the first dashboard in menu is not visible to user into T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.
Jul 27 2017, 4:25 PM · Policy, Dashboards, Bug Report
epriestley merged task T12308: Access forbidden on homepage if the first dashboard in menu is not visible to user into T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.
Jul 27 2017, 4:25 PM · Dashboards, Profile Menu Item, Bug Report
epriestley added a comment to T12404: Implement a first-party SMTP client.

This doesn't affect us, but more fuel on the fire -- XSS in example code which ships with PHPMailer (we don't distribute this code):

Jul 27 2017, 2:55 PM · Infrastructure, Mail
epriestley closed T12515: Upgrading: File Integrity Hashing and SHA1 as Resolved.

We appear to have survived this.

Jul 27 2017, 2:47 PM · Files, Guides, Security
epriestley closed T12560: Unintuitive interaction between autofixes and `arc diff` as Invalid.

Per above, this is not a bug.

Jul 27 2017, 2:43 PM · Bug Report
epriestley closed T12569: Conpherence rooms with no title now show nothing in the UI as Wontfix.

No one but me cares.

Jul 27 2017, 2:42 PM · Conpherence
epriestley closed T12572: Spend a week making Conpherence less bad as Resolved.

We kinda did some of this, it can live on in subtasks.

Jul 27 2017, 2:42 PM · Conpherence (v4)
epriestley closed T12594: Scrolling to the right-hand side locks the mouse arrow to the orizonatal scroll bar and prevents navigation as Invalid.

This appears to lack reproduction steps, so we can't move forward.

Jul 27 2017, 2:40 PM · Bug Report
epriestley closed T12601: Set default arguments of `ArcanistWorkflow` as Invalid.
Jul 27 2017, 2:40 PM · Feature Request
epriestley closed T12629: Start daemons that should be running but aren't as Invalid.

We aren't going to implement a bin/phd start-missing-daemon command.

Jul 27 2017, 2:32 PM · Daemons, Feature Request
epriestley renamed T12891: Phacility does not currently offer instances in the Sydney region from Slow cloning over Phacility SSH for large repository to Phacility does not currently offer instances in the Sydney region.
Jul 27 2017, 2:18 PM · Feature Request
epriestley triaged T12891: Phacility does not currently offer instances in the Sydney region as Wishlist priority.

What is the network speed of transferring a similar file (e.g., a 400MB file from /dev/urandom) via ssh cat <file>?

Jul 27 2017, 2:17 PM · Feature Request
epriestley updated the task description for T12904: Support Pact Errata.
Jul 27 2017, 2:02 PM · Phacility, Support
epriestley triaged T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way as Wishlist priority.
Jul 27 2017, 2:01 PM · Firefox, Bug Report
epriestley added a project to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way: Firefox.
Jul 27 2017, 2:00 PM · Firefox, Bug Report
epriestley renamed T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way from Dropdown styles menu on Firefox/OSX has changed to Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.
Jul 27 2017, 2:00 PM · Firefox, Bug Report
epriestley reassigned T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way from epriestley to chad.

Per above, the decision to color the default state is explicit so this is likely just a design tradeoff in the short term. I can test things locally if you want to keep fishing.

Jul 27 2017, 1:59 PM · Firefox, Bug Report
epriestley added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

There's probably no reason for us to have color: ... on the <select />

Jul 27 2017, 1:57 PM · Firefox, Bug Report
epriestley claimed T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

Is this the current status here?

Jul 27 2017, 1:40 PM · Firefox, Bug Report
epriestley merged T12939: Ponder seems to ignore all email settings into T10448: Modularize mail tags.
Jul 27 2017, 1:33 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley merged task T12939: Ponder seems to ignore all email settings into T10448: Modularize mail tags.
Jul 27 2017, 1:33 PM · Bug Report, Ponder
epriestley added a comment to T12939: Ponder seems to ignore all email settings.

I'm just going to merge this into T10448.

Jul 27 2017, 1:33 PM · Bug Report, Ponder
epriestley merged T12909: Calendar ignores email preferences if a user is invited via a project into T10448: Modularize mail tags.
Jul 27 2017, 1:31 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley merged task T12909: Calendar ignores email preferences if a user is invited via a project into T10448: Modularize mail tags.
Jul 27 2017, 1:31 PM · Calendar, Bug Report
epriestley added a comment to T12909: Calendar ignores email preferences if a user is invited via a project.

This almost certainly has nothing to do with being invited via a project. I'm just going to merge this into T10448, which will moot it.

Jul 27 2017, 1:30 PM · Calendar, Bug Report
epriestley added a comment to T12939: Ponder seems to ignore all email settings.

I suspect this is actually more like: actions on Ponder answers are not covered by the "Ponder Questions" email preferences, because a "Ponder Answer" is not the same type of object as a "Ponder Question".

Jul 27 2017, 1:26 PM · Bug Report, Ponder
yelirekim awarded T12935: Automatically detect merge-ability in Differential a Like token.
Jul 27 2017, 1:16 PM · Customer Impact, Harbormaster, Drydock, Differential
epriestley removed a member for Ops: • bnealey.
Jul 27 2017, 10:52 AM
epriestley removed a member for Ops: • Hektve.
Jul 27 2017, 10:52 AM
epriestley removed a member for Ops: • z4a4n2008lv.
Jul 27 2017, 10:52 AM
epriestley removed a watcher for Ops: • bnealey.
Jul 27 2017, 10:52 AM
epriestley removed a watcher for Ops: • Hektve.
Jul 27 2017, 10:52 AM

Jul 26 2017

• tomekj2ee awarded T12935: Automatically detect merge-ability in Differential a Like token.
Jul 26 2017, 7:56 PM · Customer Impact, Harbormaster, Drydock, Differential
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Jul 26 2017, 5:50 PM · Phacility, Support
epriestley added a comment to T5505: Plan Legalpad v2.

I think it should be possible to backfill this from the transaction record, but definitely a bit involved. Holding it until we do history (and major/minor versions) makes sense.

Jul 26 2017, 5:04 PM · Restricted Project, Restricted Project