Page MenuHomePhabricator

Hard to detect typos in *.edit endpoints
Open, WishlistPublic

Description

(From https://discourse.phabricator-community.org/t/how-to-use-project-edit-api-in-conduit/182)

A user was trying to make a transaction using project.edit, but used "values" instead of "value", and the only thing that happened was that there was no response (The transaction defaulted to "empty value", and then dropped because it didn't change anything).

There should be a stricter checks on the content of the values there.

To reproduce:

Using the Conduit explorer, invoke project.edit to with a transaction like this:

[ { "type": "members.set", "values":  ["PHID-USER-vkaqas55v4pfhejgus7d"] } ]

(Note bad values key, and maybe use a phid that's real).

The result is no error, and (Assuming there were no members before), an empty transaction list.

On masterish.