Page MenuHomePhabricator
Feed Advanced Search

Apr 10 2017

epriestley added a revision to T12504: Files "Temporary" badge is white-on-grey: Unknown Object (Differential Revision).
Apr 10 2017, 9:57 PM · Files, PHUI
epriestley closed T12529: Documentation improvement: avoid potentially problematic manual edits to /etc/shadow as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 9:15 PM · Bug Report
epriestley added a project to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Phacility.

A SAAS install reported bumping into this.

Apr 10 2017, 9:15 PM · Search, Customer Impact, Bug Report
epriestley added a comment to T12529: Documentation improvement: avoid potentially problematic manual edits to /etc/shadow.

Does the language in D17648 look OK?

Apr 10 2017, 7:23 PM · Bug Report
epriestley added a revision to T12529: Documentation improvement: avoid potentially problematic manual edits to /etc/shadow: Unknown Object (Differential Revision).
Apr 10 2017, 7:23 PM · Bug Report
epriestley added a comment to T12529: Documentation improvement: avoid potentially problematic manual edits to /etc/shadow.
epriestley@orbital ~ $ usermod
-bash: usermod: command not found
Apr 10 2017, 7:16 PM · Bug Report
epriestley added a comment to T11073: Allow the user to specify a date in a different timezone using date controls.

Do you routinely schedule events in timezones other than UTC or your local time? If so, why? (For example, do you frequently travel between two timezones? Do you schedule events on behalf of a team that works in a different, non-UTC timezone?)

Apr 10 2017, 7:15 PM · KDE, Calendar, Feature Request
epriestley closed T12528: Can't send confirmation email if two mails are available as Resolved.

The address is verified but the verified flag on your account is not set.

Apr 10 2017, 5:53 PM · Mail, Bug Report
epriestley closed T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns, a subtask of T12101: Phabricator PHP 7 Compatibility, as Resolved.
Apr 10 2017, 5:34 PM · Infrastructure, Guides
epriestley closed T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 5:34 PM · libphutil, Security
epriestley added a revision to T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns: Unknown Object (Differential Revision).
Apr 10 2017, 4:54 PM · libphutil, Security
epriestley added a comment to T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns.

I think this is, to at least some degree, a legitimate security problem. Consider:

Apr 10 2017, 4:26 PM · libphutil, Security
epriestley closed T12356: Calendar Notification is not respecting my Time Zone Settings as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 3:48 PM · Calendar, Bug Report
epriestley closed T12488: Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 3:47 PM · Calendar, Bug Report
epriestley added a parent task for T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns: T12101: Phabricator PHP 7 Compatibility.
Apr 10 2017, 3:46 PM · libphutil, Security
epriestley added a subtask for T12101: Phabricator PHP 7 Compatibility: T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns.
Apr 10 2017, 3:46 PM · Infrastructure, Guides
epriestley closed T11561: Write a "Contributor Onboarding" document as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 3:36 PM · Documentation, Contributor Onboarding
epriestley updated the task description for T12525: amckinley's Onboarding.
Apr 10 2017, 3:26 PM · Phacility, Contributor Onboarding
epriestley created Phage (Phacility).
Apr 10 2017, 3:23 PM
epriestley edited the content of Phacility Cluster CLI Tools.
Apr 10 2017, 3:08 PM
epriestley moved T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate from Backlog to Future Work (v2+) on the Calendar board.
Apr 10 2017, 2:54 PM · Calendar, Bug Report
epriestley moved T12356: Calendar Notification is not respecting my Time Zone Settings from Backlog to Unprototype (v1) on the Calendar board.
Apr 10 2017, 2:54 PM · Calendar, Bug Report
epriestley added a comment to T12356: Calendar Notification is not respecting my Time Zone Settings.
  • After D17646, event reminder mail should render with timezone information.
  • Additionally, timezone information in this mail and other modern ModularTransactions mail will now render with timezone abbreviations where available: (PDT) instead of (UTC-7), for example.
  • I wasn't able to identify or reproduce any actual bug here. Hopefully the additional information in D17646 will make it clear what's happening. The expectation is that the mail you receive should use the same locale as your account uses in Settings → Date and Time → Timezone, and in all my local attempts to reproduce this that was the case. Note that if an event is scheduled in UTC but instances cross daylight savings time in a particular locale the local time of the event may change. I don't think that's what happened here, just mentioning it. See also T11073.
Apr 10 2017, 2:54 PM · Calendar, Bug Report
epriestley added a revision to T12356: Calendar Notification is not respecting my Time Zone Settings: Unknown Object (Differential Revision).
Apr 10 2017, 2:48 PM · Calendar, Bug Report
epriestley created T12527: Calendar notifications for recurring events are only sent if you accept invites to every instance.
Apr 10 2017, 2:19 PM · Calendar
epriestley added a comment to T12356: Calendar Notification is not respecting my Time Zone Settings.

I think this is a legitimate bug where the viewer's timezone on the event becomes stuck as the last invitee we process, so events with multiple invitees in different timezones can generate mail with the last user's timezone.

Apr 10 2017, 2:03 PM · Calendar, Bug Report
epriestley added a comment to T12295: Allow commenting on imported calendar events.

Go ahead and create a new request -- knowing which things people actually want/use will be helpful since other calendaring applications seem to have very complex controls here without much consistency and with different supported sets of capabilities.

Apr 10 2017, 1:46 PM · Calendar, Feature Request
epriestley renamed T12488: Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export from Export ICS Exception to Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export.
Apr 10 2017, 1:36 PM · Calendar, Bug Report
epriestley moved T12488: Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export from Backlog to Unprototype (v1) on the Calendar board.
Apr 10 2017, 1:35 PM · Calendar, Bug Report
epriestley closed T11816: Calendar: Feedback and Suggestions as Resolved.

Future instances of recurring events aren't visible in panels when an item limit is set:

Apr 10 2017, 1:35 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Apr 10 2017, 1:33 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Apr 10 2017, 1:28 PM · Restricted Project, Calendar
epriestley created T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns.
Apr 10 2017, 1:26 PM · libphutil, Security
epriestley added a comment to T11073: Allow the user to specify a date in a different timezone using date controls.

I'm just trying to understand whether this is a common problem that all users of Calendar software routinely experience, or a problem that is experienced much more strongly at WMF that by most other users.

Apr 10 2017, 12:39 PM · KDE, Calendar, Feature Request
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Apr 10 2017, 11:58 AM · Restricted Project, Calendar
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

This is her status at 13:45 today...
She doesn't have any events till 14:00 today.

Apr 10 2017, 11:45 AM · Restricted Project, Calendar
epriestley added a revision to T12488: Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export: Unknown Object (Differential Revision).
Apr 10 2017, 11:37 AM · Calendar, Bug Report
epriestley added a comment to T12488: Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export.

I believe this occurs only if an install has improperly migrated legacy data. This install does; presumably yours does as well.

Apr 10 2017, 11:33 AM · Calendar, Bug Report
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

@ivo, I'll follow up for this on T12488 which appears to be a similar standalone report:

Apr 10 2017, 11:20 AM · Restricted Project, Calendar
epriestley moved T11073: Allow the user to specify a date in a different timezone using date controls from Backlog to Future Work (v2+) on the Calendar board.
Apr 10 2017, 11:16 AM · KDE, Calendar, Feature Request
epriestley added a project to T11073: Allow the user to specify a date in a different timezone using date controls: Calendar.
Apr 10 2017, 11:15 AM · KDE, Calendar, Feature Request
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

@EddieGP, see T11073.

Apr 10 2017, 11:15 AM · Restricted Project, Calendar
epriestley closed T11801: Calendar: ICS Import Errata as Resolved.

ICS issues seem to have calmed down so I'm going to call this resolved; future issues can just be filed as separate tasks.

Apr 10 2017, 11:05 AM · Bug Report, Calendar
epriestley triaged T11399: Add support for locations in calendar events as Wishlist priority.
Apr 10 2017, 11:04 AM · Calendar, Feature Request
epriestley moved T12295: Allow commenting on imported calendar events from Backlog to Future Work (v2+) on the Calendar board.
Apr 10 2017, 11:04 AM · Calendar, Feature Request
epriestley triaged T12295: Allow commenting on imported calendar events as Wishlist priority.

This is technically possible (and I believe imported events do have some support for mutation within Phabricator today: for example, I believe you can award them tokens). However, I'm very hesitant to start making imported events writable.

Apr 10 2017, 11:04 AM · Calendar, Feature Request
epriestley added a subtask for T12295: Allow commenting on imported calendar events: T11800: When duplicate events are imported into Calendar, show viewers only the best version.
Apr 10 2017, 10:58 AM · Calendar, Feature Request
epriestley added a parent task for T11800: When duplicate events are imported into Calendar, show viewers only the best version: T12295: Allow commenting on imported calendar events.
Apr 10 2017, 10:58 AM · Calendar
nmcalabroso awarded T10038: Plan the mid-term pathway for unit-test/linter bindings a Burninate token.
Apr 10 2017, 10:23 AM · Lint, Arcanist
avivey awarded T12525: amckinley's Onboarding a Party Time token.
Apr 10 2017, 5:21 AM · Phacility, Contributor Onboarding

Apr 9 2017

• tomekj2ee awarded T3569: Make Phrequent somewhat usable a Like token.
Apr 9 2017, 10:07 PM · Phrequent
• tomekj2ee awarded T4213: Provide custom themes, skinning, or custom CSS a Love token.
Apr 9 2017, 4:39 PM · Design
epriestley created T12525: amckinley's Onboarding.
Apr 9 2017, 1:46 PM · Phacility, Contributor Onboarding
epriestley added a revision to T11561: Write a "Contributor Onboarding" document: Unknown Object (Differential Revision).
Apr 9 2017, 11:58 AM · Documentation, Contributor Onboarding
epriestley moved T11561: Write a "Contributor Onboarding" document from Backlog to Meta on the Contributor Onboarding board.
Apr 9 2017, 11:28 AM · Documentation, Contributor Onboarding
epriestley moved T11476: Record transaction histories when users edit application capabilities from Backlog to Intermediate on the Contributor Onboarding board.
Apr 9 2017, 11:28 AM · Contributor Onboarding, Restricted Project, Applications, Feature Request
epriestley moved T11217: Make Tokens modular / real application from Intermediate to Backlog on the Contributor Onboarding board.
Apr 9 2017, 11:27 AM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley added a comment to T8788: Allow querying for files by name.

We ultimately built an "ngram index" for this task, see T9979 for discussion.

Apr 9 2017, 11:24 AM · Contributor Onboarding, Files
epriestley moved T8788: Allow querying for files by name from Backlog to Intermediate on the Contributor Onboarding board.
Apr 9 2017, 11:18 AM · Contributor Onboarding, Files
epriestley moved T11632: Display invisible characters on erroneous user input from Backlog to Basic on the Contributor Onboarding board.
Apr 9 2017, 11:17 AM · Restricted Project, Contributor Onboarding
epriestley added a comment to T11632: Display invisible characters on erroneous user input.
  • T11586 has context.
  • D16541 added PHUIInvisibleCharacterView and has usage examples.
  • Go hunt down as many error messages which include user input in a validation error as you can find/test and wrap them in PHUIInvisibleCharacterView. The task description lists some. I don't think there's any systematic way to find these, and we shouldn't expect to be exhaustive.
  • Close this when satisfied / bored / everything else is too much of a pain to test.
  • Primary goal here is just an onboarding goal of poking around some different applications, we haven't really seen users hit this stuff.
Apr 9 2017, 11:17 AM · Restricted Project, Contributor Onboarding
epriestley added a comment to T10828: File deletion should be queued up and run by daemons.
  • When you click "Delete File", we currently delete the file in the web process. Since we've supported enormous files and pluggable storage backends for a while, this could take an arbitrarily long amount of time to complete.
    • Instead, we want to flag the file as "deleted", hide it in the web UI, and queue up a task in the daemons to actually get rid of the data.
Apr 9 2017, 11:13 AM · Contributor Onboarding, Daemons, Files, Bug Report
epriestley moved T10828: File deletion should be queued up and run by daemons from Backlog to Intermediate on the Contributor Onboarding board.
Apr 9 2017, 10:56 AM · Contributor Onboarding, Daemons, Files, Bug Report
epriestley moved T6411: Countdown Panel from Backlog to v2 on the Countdown board.
Apr 9 2017, 10:55 AM · Countdown
epriestley moved T11956: Enhance Countdown to include "count up" functionality from Backlog to v2 on the Countdown board.
Apr 9 2017, 10:55 AM · Countdown, Feature Request
epriestley edited projects for T12325: Dynamically adjust the display precision of countdowns to increase dramatic tension, added: Phacility; removed Contributor Onboarding.

Actually, this will probably take longer to provide guidance for than to implement.

Apr 9 2017, 10:55 AM · Customer Impact, Countdown, Feature Request
epriestley moved T11629: Support "editor link" for repos without a callsign from Ready to Basic on the Contributor Onboarding board.
Apr 9 2017, 10:54 AM · Contributor Onboarding, FreeBSD, Restricted Project, Feature Request
epriestley moved T8628: Modernize AphrontControllers to implement handleRequest from Ready to Basic on the Contributor Onboarding board.
Apr 9 2017, 10:54 AM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
epriestley moved T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations from Ready to Basic on the Contributor Onboarding board.
Apr 9 2017, 10:54 AM · Contributor Onboarding, Bug Report
epriestley moved T11701: Add a lint rule for `if (CONSTANT) { ... }` from Ready to Intermediate on the Contributor Onboarding board.
Apr 9 2017, 10:53 AM · Contributor Onboarding, Infrastructure, Arcanist, Lint
epriestley moved T11360: Detect MySQL `read_only` and degrade masters to replicas from Ready to Intermediate on the Contributor Onboarding board.
Apr 9 2017, 10:53 AM · Contributor Onboarding, Restricted Project, Clusters
epriestley created T12524: Modernize Countdown.
Apr 9 2017, 10:42 AM · Countdown
epriestley created T12523: Remove the ability to delete countdowns.
Apr 9 2017, 10:33 AM · Countdown
epriestley moved T12325: Dynamically adjust the display precision of countdowns to increase dramatic tension from Backlog to v2 on the Countdown board.
Apr 9 2017, 10:28 AM · Customer Impact, Countdown, Feature Request
epriestley closed T11563: Provide a way to get all diffs associated with tasks from the API as Resolved.

This is now possible with edge.search.

Apr 9 2017, 10:15 AM · Restricted Project, Conduit
epriestley added a project to T3689: Add 'create macro' to 'create meme' dialog: Macros.
Apr 9 2017, 10:02 AM · Macros, Remarkup
epriestley closed T2794: Implement Phage (like Hypershell), a subtask of T12218: Reduce the operational cost of a larger Phacility cluster, as Resolved.
Apr 9 2017, 10:02 AM · Ops, Phacility
epriestley closed T2794: Implement Phage (like Hypershell) as Resolved.

I've been doing production deployments with this for a while without hitting any meaningful issues. It's not general-purpose yet but followups can live in Phage from here on out.

Apr 9 2017, 10:02 AM · Phage, Infrastructure
epriestley created Phage.
Apr 9 2017, 10:00 AM

Apr 8 2017

epriestley edited the content of Phacility Cluster Documentation.
Apr 8 2017, 10:59 PM
epriestley added a member for Phacility Root Access: amckinley.
Apr 8 2017, 10:33 PM
epriestley added a member for Phacility Keystore Access: amckinley.
Apr 8 2017, 10:33 PM
epriestley added a member for Phacility Core Access: amckinley.
Apr 8 2017, 10:33 PM
epriestley added a member for Phacility High Command: amckinley.
Apr 8 2017, 10:27 PM
epriestley added a member for Blessed Reviewers: amckinley.
Apr 8 2017, 10:27 PM
epriestley added a member for Blessed Committers: amckinley.
Apr 8 2017, 10:26 PM
epriestley added a member for Community: amckinley.
Apr 8 2017, 10:26 PM
epriestley awarded Phacility to recipient: amckinley.
Apr 8 2017, 10:26 PM
epriestley closed T12522: diffusion.commit.search requires repositories to be specified by PHID as Wontfix.

Use diffusion.repository.search or phid.lookup to map repository identifiers to PHIDs.

Apr 8 2017, 3:07 PM · Diffusion, Conduit, Bug Report

Apr 7 2017

epriestley added a comment to T10319: Generate unique? profile images for each new user.

I think it does, but only if you ever don't have a profile picture:

Apr 7 2017, 9:19 PM · Feature Request, People
epriestley edited the content of Changelog.
Apr 7 2017, 8:41 PM
epriestley created 2017 Week 14 (Early April).
Apr 7 2017, 8:40 PM
epriestley closed T12517: Some strings are not outputted by pht() method as Resolved by committing Restricted Diffusion Commit.
Apr 7 2017, 5:07 PM · Contributor Onboarding, Localization, Bug Report
epriestley closed T12520: tes as Invalid.
Apr 7 2017, 3:56 PM · Bug Report
epriestley closed T5330: Countdown dashboards showing timers about to expire, created via scripts as Invalid.

This is extremely old and doesn't have any use case information, which we require for modern feature requests (see Contributing Feature Requests).

Apr 7 2017, 1:31 PM · Countdown
epriestley updated the task description for T8783: Unprototype Nuance (v1).
Apr 7 2017, 1:29 PM · Nuance, Restricted Project
epriestley deleted Nuance.
Apr 7 2017, 1:25 PM
epriestley deleted Oauthserver.
Apr 7 2017, 1:25 PM
epriestley deleted New Document2.
Apr 7 2017, 1:25 PM
epriestley moved T406: Support "Oncall" Users from Backlog to Far Future on the Nuance board.
Apr 7 2017, 1:24 PM · Nuance, Oncall Tool, Facebook