Just filing this to keep track of some technical debt... D10698 introduced AphrontController::handleRequest() which replaces AphrontController::willProcessRequest() and AphrontController::processRequest(). As such, all controllers should eventually be modernized to implement handleRequest() instead of willProcessRequest() and processRequest().
Revisions and Commits
- Mentioned In
- rPb5bd4c65c2ea: Update transactions for handleRequest
rP1b61af126fe8: Update Subscriptions for handleRequest
rPf5be68c59c39: Update Notifications for handleRequest
rP3b0ca7b76995: Partially update Maniphest for handleProcess
rPf087bce27da5: Update Audit for handleRequest
rP36103dfa182c: Update Auth for handleRequest
rP1d2c47f1104c: Update Phortune for handleRequest
rP2ff460158423: Update Calendar for handleRequest
rP917fa250d016: Update Paste for handleRequest
rPeea94aaf6724: Update XHProf for handleRequest
rP6d59f3d1f2d4: Update Herald for handleRequest
rP9c39a9b361bd: Update UIExamples for handleRequest
rPdeb06727eaf2: Update Help for handleRequest
rP564aa2c4ba6e: Update Config app for handleRequest
rP6fb43305be70: Convert Passhrase to handleRequest
rP18a9fe85c835: Convert Macro to handleRequest
rP1643685e7216: Modernize Phame process handlers
rP44d5dff83215: Update Tokens for handleRequest
rP0bbcd3888c8d: Update Dashboard for handleRequest
rP96cecebf65b2: Update Phriction for handleRequest
rP1aed0e67a9a9: Update Ponder for handleRequest
- Mentioned Here
- D10698: Decouple some aspects of request routing and construction
This is an opportunity to earn valuable contributor points and explore the dark corners of the codebase. Spooky!
We still have a few old callsites to willProcessRequest(array $data) and processRequest() in subclasses of PhabricatorController. These were replaced with handleRequest(AphrontRequest $request) a while ago. In practice, the old API was just confusing and weird and the new one is essentially always simpler.
For example, PhabricatorRobotsController, which powers /robots.txt, uses processRequest(). This should be replaced with handleRequest(AphrontRequest $request).
There should be no visible effect on behavior as a result of these changes, except that we can eventually delete the old methods.
Some of these are probably fairly tricky to test or convert, although some (like Robots) are probably quite easy. You can look at other revisions on this task for examples of conversions.
There's no real urgency to finishing this cleanup, so just do however much you want and then we can throw this back in the pond.