This is an opportunity to earn valuable contributor points and explore the dark corners of the codebase. Spooky!

We still have a few old callsites to willProcessRequest(array $data) and processRequest() in subclasses of PhabricatorController. These were replaced with handleRequest(AphrontRequest $request) a while ago. In practice, the old API was just confusing and weird and the new one is essentially always simpler.

For example, PhabricatorRobotsController, which powers /robots.txt, uses processRequest(). This should be replaced with handleRequest(AphrontRequest $request).

There should be no visible effect on behavior as a result of these changes, except that we can eventually delete the old methods.

Some of these are probably fairly tricky to test or convert, although some (like Robots) are probably quite easy. You can look at other revisions on this task for examples of conversions.

There's no real urgency to finishing this cleanup, so just do however much you want and then we can throw this back in the pond.