Page MenuHomePhabricator

Support "editor link" for repos without a callsign
Open, LowPublic

Description

This is a straightforward feature request.
Root cause: I sometimes notice a bug when browsing in a code review or in diffusion. I'd like to be able to open these files in my IDE so that I can get that wonderful feeling of using the JVM to edit a file.
Our repos do not have callsigns so the option %r for "Repository Callsign" is useless. Ideally these can be modularized. Personally I'd like "short name" as this perfectly maps to the name of the repo on the filesystem but even offering the non-human-readable ID which I can symlink would work.

Event Timeline

eadler added projects: Restricted Project, FreeBSD.
epriestley added a subscriber: epriestley.

This stuff is defined in PhabricatorUser->loadEditorLink(), which ain't great but probably not worth generalizing.

  • Add %d (repository ID) and %s (repository short name) or similar, following the example provided by %r.
  • Document these options in PhabricatorEditorSetting.
  • Test by configuring a link in SettingsDisplay Preferences and then using Open in Editor from a file content page in Diffusion.
epriestley moved this task from Backlog to Ready on the Contributor Onboarding board.