Page MenuHomePhabricator
Feed Advanced Search

Sep 10 2015

epriestley added a comment to T8592: "View on previous revision" button on ghosted comment can jump to wrong place.

This is likely the same as T5030, but I haven't observed it myself and haven't spent the time to try to reproduce it.

Sep 10 2015, 12:13 AM · Differential, Restricted Project
epriestley added a comment to T8594: Develop system for dumping/backing up Phriction documents.

This is a fairly huge amount of complexity for a very niche use case, which makes me hesitant to pursue it in the upstream. I expect the number of installs which would use this feature is on the order of 1, and that it essentially amounts to custom development.

Sep 10 2015, 12:12 AM · Phriction, Restricted Project

Sep 9 2015

epriestley assigned T8607: Half-done comments on posted on arc diff to angie.

We don't understand this use case, so we aren't sure how to proceed here.

Sep 9 2015, 11:59 PM · Restricted Project
epriestley added a comment to T5031: Draft Comment Persists After Submission.

This is fairly straightforward but blocked on T9132, which is prioritized elsewhere. This is likely to be completed adjacently with T9132 anyway.

Sep 9 2015, 11:59 PM · Restricted Project, Support Impact, Mobile
epriestley added a comment to T8610: No threaded comments --hard to follow in line comments when two bugs exist on one line.

We're aware of requests in this vein but unlikely to implement the specific suggestions here, for a variety of reasons. The product pathway forward here is generally a murky one. We will likely need to resolve T1460 (itself, murky) before having more clarity here. Resolving it may also introduce satisfactory threading.

Sep 9 2015, 11:58 PM · Restricted Project
epriestley added a comment to T8646: Provide more context for search results, particularly wiki documents.

This is technically straightforward but probably needs some design work. I'd guess it's on the order of 2-4 hours depending how messy application/customfield stuff ends up, although that may happen in a technical block and a separate design block. This can be slipped in if approved.

Sep 9 2015, 11:55 PM · Design, Search, Restricted Project
epriestley added a comment to T8660: Top search bar is not consistent about searching open vs closed document types.

This is easy to change but I'm not really convinced it's better, even though it is inconsistent.

Sep 9 2015, 11:52 PM · FreeBSD, Search, Restricted Project
epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

I plan to try to collect the above into documentation to try to better explain this, but I don't think that has any specific impact on anyone. I don't plan to make any behavioral changes. I'm open to suggestions here, but we can't write a bin/time rewind and can not fully redact data which has been committed to the system and published to email and other external channels.

Sep 9 2015, 11:44 PM · Infrastructure, Restricted Project
epriestley closed T8854: Display unit test results on home view as Invalid.

Presuming this is a problem with extensions since there's a warning in the upstream.

Sep 9 2015, 11:39 PM · Unit, Arcanist, Restricted Project
epriestley added a comment to T9012: Nag users who reply-all.

This should probably wait for T3980 and be reevaluated after that.

Sep 9 2015, 11:38 PM · llvm, Mail, Restricted Project
epriestley added a comment to T5181: Parse in-line replies in email responses.

In particular, I think we're going to hit cases like this:

Sep 9 2015, 11:38 PM · llvm, Restricted Project, Mail
epriestley added a comment to T5181: Parse in-line replies in email responses.

Well, there's an unrelated bug.

Sep 9 2015, 11:37 PM · llvm, Restricted Project, Mail
epriestley added a comment to T5181: Parse in-line replies in email responses.

(Just creating an example via email for my next reply.)

Sep 9 2015, 11:32 PM · llvm, Restricted Project, Mail
epriestley assigned T9026: arc land might identify wrong revision if branch is missing revision to angie.

I do this routinely without errors and am not sure how to reproduce it.

Sep 9 2015, 11:30 PM · Restricted Project, Arcanist
epriestley added a comment to T5591: Add default domain to Google auth.

This is straightforward and probably <1 hour of work. It can be squeezed in if approved for prioritization.

Sep 9 2015, 11:27 PM · Restricted Project, Restricted Project, Auth
epriestley added a subtask for T7820: Add "Closed, Duplicate" option to Status Action in Maniphest: T9132: Build an ApplicationEditor abstraction.
Sep 9 2015, 11:27 PM · Restricted Project, User Delight, Maniphest
epriestley added a parent task for T9132: Build an ApplicationEditor abstraction: T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.
Sep 9 2015, 11:27 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

This probably now also blocks on T9132.

Sep 9 2015, 11:27 PM · Restricted Project, User Delight, Maniphest
epriestley added a comment to T3980: Support "Bind to External Thing" to define project membership.

This is not blocked, but large and not adjacent to other prioritized work. I've included it in "Projects v3" (T9378).

Sep 9 2015, 11:26 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
epriestley moved T8783: Unprototype Nuance (v1) from Backlog to Preflight on the Prioritized board.
Sep 9 2015, 11:25 PM · Nuance, Restricted Project
epriestley moved T9378: Build Projects v3 from Backlog to Preflight on the Prioritized board.
Sep 9 2015, 11:25 PM · Projects (v3), Prioritized
epriestley added a project to T9378: Build Projects v3: Prioritized.
Sep 9 2015, 11:25 PM · Projects (v3), Prioritized
epriestley added a project to T8783: Unprototype Nuance (v1): Prioritized.
Sep 9 2015, 11:24 PM · Nuance, Restricted Project
epriestley updated the task description for T9378: Build Projects v3.
Sep 9 2015, 11:24 PM · Projects (v3), Prioritized
epriestley updated the task description for T9378: Build Projects v3.
Sep 9 2015, 11:24 PM · Projects (v3), Prioritized
epriestley moved T5558: Fix the bog of questionable value that is Project detail pages from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:23 PM · Dashboards, Projects
epriestley moved T5953: Build a modular user account batch importer from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:23 PM · Restricted Project, Auth, Projects
epriestley moved T6288: Projects - when creating project from Maniphest, icon doesn't show from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:23 PM · Projects, Maniphest
epriestley moved T6287: Custom Fields - add concept of "needed for quick create" for a given field from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:23 PM · Custom Fields, Projects
epriestley moved T6856: Make Project Images that match Typeahead choices from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:23 PM · Design, Projects
epriestley updated the task description for T9378: Build Projects v3.
Sep 9 2015, 11:22 PM · Projects (v3), Prioritized
epriestley moved T7005: Find somewhat simple way to have Phriction be a part of new Projects layout from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:22 PM · FreeBSD, Phriction, Projects
epriestley moved T7305: project hashtags should work better re: spaces from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:22 PM · Projects
epriestley moved T7341: Colons ":" in project names create unusable hashtags from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:22 PM · Projects
epriestley moved T9088: Make whole workboard column a drop target from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:21 PM · Workboards, Projects
epriestley created T9378: Build Projects v3.
Sep 9 2015, 11:21 PM · Projects (v3), Prioritized
epriestley moved T9156: Lipsum generated projects have no tags from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:20 PM · Projects
epriestley moved T9019: Create a "Project Members" object policy for Projects from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:20 PM · Projects, Policy
epriestley moved T8509: Exception when creating project with same tag as primary slug. from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:20 PM · Projects
epriestley moved T6961: Rendering of workboard columns on card objects could be marginally more efficient from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:20 PM · Projects, Performance
epriestley moved T5403: Display more high-level info in project hovercards from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:19 PM · Hovercards, Projects
epriestley moved T5240: Dragging items (cards, panels) could be better in Workboards from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:19 PM · Projects (v3), Workboards
epriestley moved T4136: Project options shown in Policy control should be smarter and more powerful from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:19 PM · Policy, Projects
epriestley moved T3980: Support "Bind to External Thing" to define project membership from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:19 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
epriestley moved T3670: Add subprojects from Backlog to Projects v3 on the Projects board.
Sep 9 2015, 11:19 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley assigned T9108: Don't die horribly when large commit is pushed to angie.

We don't have enough information to reproduce this or otherwise move forward on it.

Sep 9 2015, 11:17 PM · Diffusion, Restricted Project
epriestley added a comment to T9126: diffusion history page should give browse links for each committed version of the file.

This is reasonable and straightforward, and I have some adjacent UI adjustments I'd like to try making concurrently. This is <1 hour and can slip in somewhere if approved for prioritization.

Sep 9 2015, 11:17 PM · Prioritized, Diffusion, Restricted Project
epriestley added a comment to T418: Integrate CustomField into more interfaces.

This isn't blocked on anything but not adjacent to other planned work in the near future. It likely makes sense as part of a "Projects v3" with T3670. I'll see what else is in queue and tentatively organize anything projects-related if there's some more of it.

Sep 9 2015, 11:15 PM · Restricted Project, Restricted Project, Restricted Project, Custom Fields, Maniphest
epriestley closed T9311: Marking a diff as Requires Changes no longer removes it from Blocking Others as Invalid.

Presuming this is just related to bucketing errors since we're aware of bucketing assignment occasionally being surprising, see T9372 for some discussion.

Sep 9 2015, 11:13 PM · Differential, Restricted Project
epriestley added subtasks for T9367: Add another accept state for code review: T731: Allow revisions to have alternate acceptance conditions, T9372: Plan the future of "Bucketing" Query UIs.
Sep 9 2015, 11:11 PM · Differential, Restricted Project
epriestley added a parent task for T731: Allow revisions to have alternate acceptance conditions: T9367: Add another accept state for code review.
Sep 9 2015, 11:11 PM · Restricted Project, Restricted Project, Differential
epriestley added a parent task for T9372: Plan the future of "Bucketing" Query UIs: T9367: Add another accept state for code review.
Sep 9 2015, 11:11 PM · Restricted Project, Audit, ApplicationSearch, Differential
epriestley added a comment to T3670: Add subprojects.

T4100 is complete and this is technically unblocked, but needs significant planning work. I intend to wait until we're closer to being able to act on it to do that planning, since things are likely to change at least somewhat between now and then.

Sep 9 2015, 11:10 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley added a subtask for T5815: Make it easier to work through a queue of stuff: T9132: Build an ApplicationEditor abstraction.
Sep 9 2015, 11:08 PM · Restricted Project, Maniphest, Differential, Audit
epriestley added a parent task for T9132: Build an ApplicationEditor abstraction: T5815: Make it easier to work through a queue of stuff.
Sep 9 2015, 11:08 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a comment to T5815: Make it easier to work through a queue of stuff.

This is blocked by T8783 (building Nuance to initial release quality) and T5307 (taking actions with search results).

Sep 9 2015, 11:08 PM · Restricted Project, Maniphest, Differential, Audit
epriestley added subtasks for T5815: Make it easier to work through a queue of stuff: T8783: Unprototype Nuance (v1), T5307: UX for taking actions with search results.
Sep 9 2015, 11:03 PM · Restricted Project, Maniphest, Differential, Audit
epriestley added a parent task for T8783: Unprototype Nuance (v1): T5815: Make it easier to work through a queue of stuff.
Sep 9 2015, 11:03 PM · Nuance, Restricted Project
epriestley added a parent task for T5307: UX for taking actions with search results: T5815: Make it easier to work through a queue of stuff.
Sep 9 2015, 11:03 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
epriestley added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

I want to resolve T8588 before pursuing this to make sure the issues aren't conflated, although I think this isn't related.

Sep 9 2015, 11:03 PM · Restricted Project, Workboards
epriestley added a parent task for T8588: One instance has a severe, global performance issue: T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).
Sep 9 2015, 11:01 PM · Restricted Project
epriestley added a subtask for T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error): T8588: One instance has a severe, global performance issue.
Sep 9 2015, 11:01 PM · Restricted Project, Workboards
epriestley added a comment to T8444: Increase typeahead speed.

I ideally want to resolve T8588 before pursuing this since it's the more fundamental performance issue, even though this isn't particularly entwined with that.

Sep 9 2015, 11:01 PM · Typeahead, PHUI, Restricted Project
epriestley added a subtask for T8444: Increase typeahead speed: T8588: One instance has a severe, global performance issue.
Sep 9 2015, 10:58 PM · Typeahead, PHUI, Restricted Project
epriestley added a parent task for T8588: One instance has a severe, global performance issue: T8444: Increase typeahead speed.
Sep 9 2015, 10:58 PM · Restricted Project
epriestley renamed T8588: One instance has a severe, global performance issue from Making a new comment UI is too slow to One instance has a severe, global performance issue.
Sep 9 2015, 10:58 PM · Restricted Project
eklitzke awarded T9123: Build Phabricator in Harbormaster (v2) a Mountain of Wealth token.
Sep 9 2015, 10:31 PM · Prioritized, Harbormaster
epriestley added a comment to T9377: Image lightbox perceived slow due to always creating new urls.

(We can cache actual image objects in the browser, although this may create other problems, and is generally a mess that needs to be individually hard-coded in every case where we show images.)

Sep 9 2015, 9:45 PM · Files, Wikimedia
epriestley added a comment to T9377: Image lightbox perceived slow due to always creating new urls.

This is largely because of specific requirements from WMF, see T5685. We can reduce the number of redirects, but per requirements in that task we can not reuse URIs and can not make these resources cacheable.

Sep 9 2015, 9:42 PM · Files, Wikimedia
epriestley closed T9369: Author of email not added to maniphest subscribers as Resolved by committing Restricted Diffusion Commit.
Sep 9 2015, 9:07 PM · Mail, Maniphest
epriestley closed T9368: managing_daemons documentation contains "{article@contributor:Adding New Classes}" as Resolved by committing Restricted Diffusion Commit.
Sep 9 2015, 9:06 PM · Documentation
epriestley added a revision to T9368: managing_daemons documentation contains "{article@contributor:Adding New Classes}": Unknown Object (Differential Revision).
Sep 9 2015, 8:59 PM · Documentation
epriestley created T9374: Allow `bin/remote` commands to operate on a range of hosts.
Sep 9 2015, 7:11 PM · Ops, Phacility
epriestley moved T9373: Deploy an "aux" tier in the cluster from Backlog to Onboarding/NUX on the Phacility board.
Sep 9 2015, 7:07 PM · Ops, Phacility
epriestley created T9373: Deploy an "aux" tier in the cluster.
Sep 9 2015, 7:07 PM · Ops, Phacility
epriestley edited the content of Adding Hardware.
Sep 9 2015, 7:05 PM
epriestley edited the content of Phacility Cluster Devices.
Sep 9 2015, 7:04 PM
epriestley added a comment to T9252: Unprototype Drydock (v1).

I expect the general shape of the code to survive, but a lot of the particulars to churn. There are lot of issues with state handling, error handling, locks, which things are responsible for what, etc., right now.

Sep 9 2015, 6:44 PM · Prioritized, Drydock
epriestley created T9372: Plan the future of "Bucketing" Query UIs.
Sep 9 2015, 6:34 PM · Restricted Project, Audit, ApplicationSearch, Differential
epriestley added a comment to T9371: Subscribers not inherited for wiki pages.

Yeah, I think that's probably the cleanest way to approach this today. That mostly works around the management mess, too.

Sep 9 2015, 6:07 PM · Phriction
epriestley added a comment to T6709: Update server requirements in docs.

I left this open because I think the information in the description is useful for us in eventually crafting setup checks and possibly including in the documentation.

Sep 9 2015, 5:04 PM · Documentation
epriestley closed Q124: Is it possible to run the Phabricator daemons (phd) in the foreground? as resolved.
Sep 9 2015, 4:44 PM · Daemons
epriestley added a comment to T9371: Subscribers not inherited for wiki pages.

The described behavior is working as expected, I think.

Sep 9 2015, 4:08 PM · Phriction
stevex awarded T6526: Implement "Badges" or "Medals", for annotating special users a Like token.
Sep 9 2015, 3:40 PM · Restricted Project, Badges (v0), People
epriestley added a comment to T9309: Minor Phacility onboarding UX gripes.

Now done:

Sep 9 2015, 3:06 PM · Phacility
epriestley added a comment to T9371: Subscribers not inherited for wiki pages.

I think changing the proposed behavior (making subscribers inherited in some form) is possibly reasonable, in that this is probably a common desire, although it seems like users might also reasonably want to subscribe to /x/ without subscribing to /x/*. We could let you "subscribe (this page only)" vs "subscribe (this page and all sub-pages)" but Subscriptions would need to expand substantially to accommodate that and there are no other use cases in other applications that I can think of (except sort-of Projects).

Sep 9 2015, 2:50 PM · Phriction
epriestley added a comment to T9367: Add another accept state for code review.

Another workaround involves working with remote offices. The reviewer prefer not to block the author, so they resign as a reviewer and suggest someone from the author’s office as reviewer. This has two big issues. First, the commit message will not have the original reviewer on it, so if there’s a prod issue, or someone is just going through git log for context, they wouldn’t see who the actual reviewer was. Second, the diff doesn’t appear in the author’s queue but in the new reviewer’s queue. And the next action should be taken by the author.

Sep 9 2015, 1:47 PM · Differential, Restricted Project

Sep 8 2015

epriestley moved T9352: Write some custom Herald glue for driving builds through Owners from Backlog to v2 on the Harbormaster board.
Sep 8 2015, 11:21 PM · Harbormaster, Herald, Owners, Prioritized
epriestley moved T9365: Harbormaster results are hard to aggregate from Backlog to v2 on the Harbormaster board.
Sep 8 2015, 11:21 PM · Harbormaster, Restricted Project, Restricted Project
epriestley added a subtask for T9123: Build Phabricator in Harbormaster (v2): T9365: Harbormaster results are hard to aggregate .
Sep 8 2015, 11:21 PM · Prioritized, Harbormaster
epriestley added a parent task for T9365: Harbormaster results are hard to aggregate : T9123: Build Phabricator in Harbormaster (v2).
Sep 8 2015, 11:21 PM · Harbormaster, Restricted Project, Restricted Project
epriestley added a comment to T9365: Harbormaster results are hard to aggregate .

This is UI oddness, you're doing everything right.

Sep 8 2015, 11:09 PM · Harbormaster, Restricted Project, Restricted Project
epriestley closed T9307: Users like to poke around on a trial instance, a subtask of T9303: Improve Phacility Onboarding/NUX, as Resolved.
Sep 8 2015, 9:33 PM · Phacility
epriestley closed T9307: Users like to poke around on a trial instance as Resolved.

The core of this should work now. These things aren't happening yet:

Sep 8 2015, 9:33 PM · Phacility
epriestley closed T9324: Create an "Upload Files" interaction for Phacility instances, a subtask of T9303: Improve Phacility Onboarding/NUX, as Resolved.
Sep 8 2015, 9:28 PM · Phacility
epriestley closed T9324: Create an "Upload Files" interaction for Phacility instances as Resolved by committing Restricted Diffusion Commit.
Sep 8 2015, 9:28 PM · Phacility
epriestley added a comment to T9252: Unprototype Drydock (v1).

Whoops, fixed. Thanks.

Sep 8 2015, 8:54 PM · Prioritized, Drydock
epriestley renamed T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch from support fancy typeahead functions in audit search to Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Sep 8 2015, 8:53 PM · Restricted Project, Typeahead, Audit
epriestley added a member for Blessed Committers: avivey.
Sep 8 2015, 8:49 PM
epriestley updated subscribers of T9252: Unprototype Drydock (v1).

Just jotting these down here to make sure they don't get lost:

Sep 8 2015, 8:41 PM · Prioritized, Drydock