Page MenuHomePhabricator

Display unit test results on home view
Closed, InvalidPublic

Description

It would be nice if we could see unit test results on the home view, e.g. with a color coding alongside the CR color coding. This would discourage people from landing in the situation where a diff has passed CR but hasn't passed tests.

Event Timeline

jmharvey raised the priority of this task from to Needs Triage.
jmharvey updated the task description. (Show Details)
jmharvey added a project: Restricted Project.
jmharvey added subscribers: jhurwitz, angie, jmharvey.

It sounds like the problem you want to solve is that people sometimes land code before tests have finished running, correct?

I just want to clarify the root problem, as opposed to the one specific solution you're suggesting, as per https://secure.phabricator.com/book/phabcontrib/article/feature_requests/#describe-problems.

I think there are probably other solutions to this problem -- such as properly integrating our unit test suite with arc unit, because then you (I believe) get a warning on the command-line if you try to land when tests are failing/not yet reported.

This would discourage people from landing in the situation where a diff has passed CR but hasn't passed tests.

You should already get an explicit prompt from arc land in this case, requiring you to confirm that you want to land code with failing or still-running tests. Are you not seeing this?

(I believe) get a warning on the command-line if you try to land when tests are failing/not yet reported.

Ah, yeah. This might be an integration thing, then.

epriestley claimed this task.

Presuming this is a problem with extensions since there's a warning in the upstream.

angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Sep 10 2015, 4:52 PM