Page MenuHomePhabricator
Create Task
Maniphest T6961

Rendering of workboard columns on card objects could be marginally more efficient
Closed, ResolvedPublic
Actions

Description

Currently, we have to do a query to check if a project has an initialized workboard. Denormalizing this into a flag on the projects would let us save:

  • A column query in PhabricatorProjectViewController.
  • A column query in PhabricatorProjectController (see D11371).
  • We could maybe-sometimes save a query in PhabricatorProjectUIEventListener.

Revisions and Commits

rP Phabricator
D15093rP9f56a014e2a8 Migrate existing projects to retain "Workboard" as default item
D15091rPb64d67f47afc Frame workboard empty/create states inside profile menu

Related Objects

Event Timeline

epriestley created this task.Jan 13 2015, 5:43 PM
epriestley raised the priority of this task from to Low.
epriestley updated the task description. (Show Details)
epriestley added projects: Performance, Projects.
epriestley added subscribers: epriestley, chad.
epriestley moved this task from Backlog to Projects v3 on the Projects board.Sep 9 2015, 11:20 PM
epriestley added a revision: D14825: Prepare Projects schema for subprojects.Dec 19 2015, 4:29 PM
epriestley removed a revision: D14825: Prepare Projects schema for subprojects.
epriestley added a revision: D15091: Frame workboard empty/create states inside profile menu.Jan 22 2016, 3:18 PM
epriestley added a revision: D15093: Migrate existing projects to retain "Workboard" as default item.Jan 22 2016, 3:59 PM
epriestley lowered the priority of this task from Low to Wishlist.Jan 22 2016, 4:04 PM

After D15093:

  • This is denormalized (hasWorkboard on PhabricatorProject).
  • The ViewController query was obsoleted by explicit defaults (see D15089).
  • The ProjectController query was switched to read the field by D15093.

This still leaves a questionable query in PhabricatorProjectUIEventListener, but that one isn't straightforward to clean up. I'm just going to leave this open until that stuff eventually gets touched by event removal or board generalization or something else which is a closer fit.

epriestley moved this task from Projects v3 to Far Future on the Projects board.Jan 22 2016, 4:04 PM
epriestley renamed this task from Denormalize workboard initialization status onto project to Rendering of workboard columns on card objects could be marginally more efficient.Jan 22 2016, 4:14 PM
epriestley closed this task as Resolved by committing rPb64d67f47afc: Frame workboard empty/create states inside profile menu.Jan 22 2016, 4:15 PM
epriestley added a commit: rPb64d67f47afc: Frame workboard empty/create states inside profile menu.
epriestley added a commit: rP9f56a014e2a8: Migrate existing projects to retain "Workboard" as default item.Jan 22 2016, 5:44 PM
Phabricator · Built by Phacility