Page MenuHomePhabricator

Rendering of workboard columns on card objects could be marginally more efficient
Closed, ResolvedPublic

Description

Currently, we have to do a query to check if a project has an initialized workboard. Denormalizing this into a flag on the projects would let us save:

  • A column query in PhabricatorProjectViewController.
  • A column query in PhabricatorProjectController (see D11371).
  • We could maybe-sometimes save a query in PhabricatorProjectUIEventListener.

Event Timeline

epriestley raised the priority of this task from to Low.
epriestley updated the task description. (Show Details)
epriestley added projects: Performance, Projects.
epriestley added subscribers: epriestley, chad.
epriestley lowered the priority of this task from Low to Wishlist.Jan 22 2016, 4:04 PM

After D15093:

  • This is denormalized (hasWorkboard on PhabricatorProject).
  • The ViewController query was obsoleted by explicit defaults (see D15089).
  • The ProjectController query was switched to read the field by D15093.

This still leaves a questionable query in PhabricatorProjectUIEventListener, but that one isn't straightforward to clean up. I'm just going to leave this open until that stuff eventually gets touched by event removal or board generalization or something else which is a closer fit.

epriestley renamed this task from Denormalize workboard initialization status onto project to Rendering of workboard columns on card objects could be marginally more efficient.Jan 22 2016, 4:14 PM