Page MenuHomePhabricator

Half-done comments on posted on arc diff
Closed, InvalidPublic

Description

Running “arc diff” will automatically post all of my “done”’s to the diff. However it won't post any of my inline replies. This is probably not the best solution. I think that I probably would never want arc diff to post my inline comments or dones. I rarely have things in a finished state and will often leave half-done comments on the diff that I need to come back to and finish later.

Event Timeline

angie created this task.Jun 18 2015, 8:26 PM
angie raised the priority of this task from to Needs Triage.
angie updated the task description. (Show Details)
angie added a project: Restricted Project.
angie added subscribers: jhurwitz, angie.

Can you walk me through this? Why are you updating a revision after marking a bunch of things "Done", but not wanting the "Done" to publish?

The assumption here is that this generally corresponds to addressing minor feedback (e.g., style/formatting changes in the absence of a linter which does this for you), which is the major use case we've seen motivating the "Done" checkbox. With this kind of feedback, it makes sense that we'd auto-publish "done": we're showing which minor changes you believe you've made in the update.

eadler added a subscriber: eadler.Jul 6 2015, 3:02 AM
angie added a subscriber: aj.Jul 6 2015, 5:58 PM

can you add some insight here?

epriestley assigned this task to angie.Sep 9 2015, 11:59 PM

We don't understand this use case, so we aren't sure how to proceed here.

angie added a comment.Sep 10 2015, 4:58 PM

@aj: can you comment here?

angie closed this task as Invalid.Oct 14 2015, 6:37 PM

@aj if you want to make a new task, please open with more details

angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 14 2015, 6:38 PM