Repro:
- From any task edit page, Create New Project
- Fill out form, save
- Observe no icon in tokenizer where project added
The selected icon should show.
Description
Description
Related Objects
Related Objects
- Mentioned In
- D10679: Projects - merge create + edit interface code paths
- Mentioned Here
- T9132: Build an ApplicationEditor abstraction
Event Timeline
Comment Actions
So PhabricatorProjectEditDetailsController needs to return the icon and it seems that, at least at the moment, behavior-project-create would need to call setRenderTokenCallback before addToken so it can show the icon... And then set it back? Hmm.
Comment Actions
Spoke to @epriestley on IRC about this:
<epriestley> I don't think there's any very clean way to fix it right now. <epriestley> Ideally, the Controller would proably use PhabricatorProjectDatasource to hit the same rendering pathway that normal tokens do. <epriestley> But there's no convenient or standard way to tell a Datasource to render one specific known token right now, and the available APIs aren't very conducive to that, so things might need to be broken up a bit. <epriestley> And once you get the standard-format token data back, I think it will take some work to pipe it through the same pathway that normal data would go through. <Krenair> I've noticed the same issue when you go to edit a custom policy which has a "members of projects" rule <Krenair> Not sure if a new task should be created or this edited or something
Comment Actions
I'm removing this "Create Project" workflow entirely in connection with T9132, obsoleting this task.
It's possible we may restore some more general version of it in the future (e.g., all project selectors have an option to create new objects, likely a "+" button in the control) but I don't currently have any specific plans to do that.