Page MenuHomePhabricator
Feed Advanced Search

May 12 2015

epriestley added a revision to T7707: Implement a read-through cache layer: Unknown Object (Differential Revision).
May 12 2015, 10:56 PM · Performance
epriestley added a revision to T7707: Implement a read-through cache layer: Restricted Differential Revision.
May 12 2015, 7:29 PM · Performance
epriestley added a revision to T7707: Implement a read-through cache layer: Unknown Object (Differential Revision).
May 12 2015, 6:52 PM · Performance
epriestley added a revision to T7707: Implement a read-through cache layer: Unknown Object (Differential Revision).
May 12 2015, 6:21 PM · Performance
epriestley added a revision to T7707: Implement a read-through cache layer: Unknown Object (Differential Revision).
May 12 2015, 5:55 PM · Performance
epriestley added a revision to T4406: Allow for 100x100 images in profile and projects: Unknown Object (Differential Revision).
May 12 2015, 5:55 PM · Projects, Design, People
epriestley merged task T8167: How to configure search using elasticsearch ? into T5282: Provide documentation on setting up ElasticSearch.
May 12 2015, 5:43 PM · Search
epriestley updated subscribers of T5282: Provide documentation on setting up ElasticSearch.
May 12 2015, 5:43 PM · Elasticsearch, Documentation
epriestley added a comment to T8169: Intermittent issues with Aphlict / Notifications.

I don't currently anticipate ever pursuing T6889.

May 12 2015, 5:16 PM · Aphlict
epriestley added a revision to T4724: Some images appear with the wrong aspect ratio: Unknown Object (Differential Revision).
May 12 2015, 3:32 PM · Remarkup
epriestley added a revision to T7707: Implement a read-through cache layer: Unknown Object (Differential Revision).
May 12 2015, 3:32 PM · Performance
epriestley added a revision to T5258: Memes use older image transform code without modern error handling: Unknown Object (Differential Revision).
May 12 2015, 3:20 PM · Restricted Project, Files, Macros
epriestley added a revision to T7707: Implement a read-through cache layer: Unknown Object (Differential Revision).
May 12 2015, 3:20 PM · Performance
epriestley added a revision to T7707: Implement a read-through cache layer: Unknown Object (Differential Revision).
May 12 2015, 2:18 PM · Performance
epriestley added a revision to T7707: Implement a read-through cache layer: Unknown Object (Differential Revision).
May 12 2015, 1:30 PM · Performance
epriestley added a subtask for T7707: Implement a read-through cache layer: T4724: Some images appear with the wrong aspect ratio.
May 12 2015, 1:19 PM · Performance
epriestley added a parent task for T4724: Some images appear with the wrong aspect ratio: T7707: Implement a read-through cache layer.
May 12 2015, 1:19 PM · Remarkup
epriestley added a comment to T7707: Implement a read-through cache layer.

Also:

May 12 2015, 1:19 PM · Performance
epriestley added subtasks for T7707: Implement a read-through cache layer: T7879: Profile pictures should have policy settings forced to public/most-open, T5258: Memes use older image transform code without modern error handling, Restricted Maniphest Task, T4406: Allow for 100x100 images in profile and projects.
May 12 2015, 12:39 PM · Performance
epriestley added a parent task for T5258: Memes use older image transform code without modern error handling: T7707: Implement a read-through cache layer.
May 12 2015, 12:39 PM · Restricted Project, Files, Macros
epriestley added a parent task for T7879: Profile pictures should have policy settings forced to public/most-open: T7707: Implement a read-through cache layer.
May 12 2015, 12:39 PM · Files
epriestley added a parent task for T4406: Allow for 100x100 images in profile and projects: T7707: Implement a read-through cache layer.
May 12 2015, 12:39 PM · Projects, Design, People
epriestley added a comment to T7707: Implement a read-through cache layer.

I'm going to tackle profile pictures first. I think it makes sense to denormalize them onto PhabricatorUser, not do them as a separate cache hit, because we almost always need them and they're very easy to dirty. We have some related technical debt which I'm going to try to clear first:

May 12 2015, 12:38 PM · Performance
epriestley closed T7708: Improve performance of chat column, a subtask of T7574: Conpherence v2 Infrastructure, as Resolved.
May 12 2015, 12:31 PM · Conpherence
epriestley closed T7708: Improve performance of chat column as Resolved.

I think we're in not-bad shape here now and nothing left is Conpherence-speific or concerning to me from a "we're going to burn everything down" point of view (the multiple extra round trips were the big thing I was a bit worried about). I'm just going to close this in favor of T7707.

May 12 2015, 12:31 PM · Conpherence
epriestley closed T7708: Improve performance of chat column, a subtask of T7572: Ship Durable Chat Column, as Resolved.
May 12 2015, 12:31 PM · Conpherence
epriestley added a comment to T8164: Notifications of project membership cannot be Ignored.

Yeah, the second issue should be fixed in HEAD, see T8112.

May 12 2015, 12:04 PM · Notifications
epriestley added a comment to T8165: Investigate high CPU usage.

In theory, the new "Multimeter" tool may be helpful in understanding this, although we probably need to at least let you put an explicit date window on queries.

May 12 2015, 12:02 PM · Performance
epriestley closed T8166: Updating a Phabricator installation to a known point as Wontfix.

We don't plan start tagging or otherwise versioning Phabricator in the near future. Some tangential discussion in T4200.

May 12 2015, 12:02 PM

May 11 2015

epriestley reopened T6299: Remarkup links to objects in Phame break if a CNAME is set as "Open".

Haha, sorry, figured I was doing slightly better than that. This should be easy to fix up.

May 11 2015, 9:00 PM · Haskell.org, Remarkup, Phame
epriestley added a comment to T8151: Decide the fate of JX.Scrollbar.

What physical device are you on? I can't immediately reproduce that on any iPhone/iPad...

May 11 2015, 8:33 PM · Conpherence, PHUI
epriestley added a comment to T8151: Decide the fate of JX.Scrollbar.

Approach (5) is now in HEAD and on this server. Let me know if anyone notices major scrolling problems that I missed.

May 11 2015, 7:09 PM · Conpherence, PHUI
epriestley updated subscribers of T8162: Option to disable "Generate Keypair".

A related request is to enable it, but require passphrases.

May 11 2015, 6:21 PM · Restricted Project, Passphrase, Auth
epriestley closed T6299: Remarkup links to objects in Phame break if a CNAME is set as Resolved by committing Restricted Diffusion Commit.
May 11 2015, 6:11 PM · Haskell.org, Remarkup, Phame
cburroughs awarded T8151: Decide the fate of JX.Scrollbar a Love token.
May 11 2015, 5:45 PM · Conpherence, PHUI
epriestley added a comment to T8151: Decide the fate of JX.Scrollbar.

Yeah, option (5) (or option (6)) would obsolete T7323 in all cases.

May 11 2015, 5:38 PM · Conpherence, PHUI
epriestley updated subscribers of T5200: Email all admins when a new account is approved.
May 11 2015, 5:23 PM · People
epriestley merged task T8161: When a user is approved have it mail all admins into T5200: Email all admins when a new account is approved.
May 11 2015, 5:23 PM · People
epriestley added a parent task for T4369: Phabricator HTTP repository hosting has fairly severe scalability limits: T8093: Evaluate virtualizing Git refs by proxying the protocol.
May 11 2015, 4:33 PM · Diffusion (v3), Restricted Project
epriestley added a subtask for T8093: Evaluate virtualizing Git refs by proxying the protocol: T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.
May 11 2015, 4:33 PM · Restricted Project, Harbormaster
epriestley added a comment to T8093: Evaluate virtualizing Git refs by proxying the protocol.

After tinkering a bit, I think this is viable. The Git wire protocol is relatively straightforward to proxy and rewrite at the ref level. However, we'll need to proxy both SSH and HTTP traffic, so we need to fix T4369 at a minimum before we can pursue this.

May 11 2015, 4:33 PM · Restricted Project, Harbormaster
epriestley added a comment to T8145: Support global/broadcast notifications.

Does anyone have a use case for this which isn't maintenance notifications?

May 11 2015, 2:54 PM · Notifications
epriestley added a comment to T7787: Support "!priority high" and other email commands from "arc todo".

Like T7715 (a similar task which discusses adding more capabilities to arc tasks and arc list), I don't want to move forward here by adding flags for everything. This isn't powerful and, as an example, can't accommodate custom fields without some level of generalization.

May 11 2015, 2:29 PM · Arcanist
epriestley renamed T7787: Support "!priority high" and other email commands from "arc todo" from Could the command line interface for creating tasks be more powerful/complete? to Support "!priority high" and other email commands from "arc todo".
May 11 2015, 2:19 PM · Arcanist
epriestley added a comment to T6299: Remarkup links to objects in Phame break if a CNAME is set.

D12793 might be missing some edge cases with unusual objects but should fix at least 95% of this. Let me know if you run into more cases after D12793 lands.

May 11 2015, 2:17 PM · Haskell.org, Remarkup, Phame
epriestley added a revision to T6299: Remarkup links to objects in Phame break if a CNAME is set: Unknown Object (Differential Revision).
May 11 2015, 2:15 PM · Haskell.org, Remarkup, Phame
epriestley created T8160: Phame blogs don't work with Quicksand.
May 11 2015, 2:04 PM · Phame, Quicksand
epriestley added a comment to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.

I don't want to add flags one by one for this. This approach is time-consuming and not very powerful. To provide one specific example, supporting custom fields via hard-coded flags in the arc client is not practical without some level of generalization.

May 11 2015, 1:56 PM · Restricted Project, FreeBSD, Arcanist
epriestley renamed T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch from Add --project filter to "arc tasks" workflow to Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
May 11 2015, 1:24 PM · Restricted Project, FreeBSD, Arcanist
epriestley updated subscribers of T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
May 11 2015, 1:24 PM · Restricted Project, FreeBSD, Arcanist
epriestley merged task T8148: Add support for more flags/options in arc into T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
May 11 2015, 1:24 PM · Arcanist
epriestley added a comment to T8148: Add support for more flags/options in arc.

I'm going to reframe T7715 to cover both arc list and arc tasks, and T7787 already covers adjusting priorities, etc.

May 11 2015, 1:24 PM · Arcanist
epriestley added a comment to T8154: Conpherence threads don't specify the day they are created.

The short timestamps are mostly for consistency with the chat column, where we have less space:

May 11 2015, 12:52 PM · Conpherence
epriestley added a comment to T8157: General search no longer respects custom priorities.

You can select the search scope you prefer from the dropdown to the left of the input, including a custom query. For example, here's how I have mine set up so that it always searches for open tasks:

May 11 2015, 12:35 PM · Search
epriestley updated subscribers of T5138: Show unit and lint status messages at each diff.
May 11 2015, 12:31 PM · Differential
epriestley merged task T8159: Unit test and linter results are not accessible anymore if revision has been landed into T5138: Show unit and lint status messages at each diff.
May 11 2015, 12:31 PM · Differential
epriestley updated subscribers of T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
May 11 2015, 12:30 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley merged task T8158: How to query diff and task information for commits into T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
May 11 2015, 12:30 PM · Conduit
epriestley added a comment to T8158: How to query diff and task information for commits.

This is generally not possible until after T5873.

May 11 2015, 12:29 PM · Conduit

May 10 2015

epriestley added a comment to T8151: Decide the fate of JX.Scrollbar.

D12789 implements (5). It accepts this visual compromise in OSX trackpad mode:

May 10 2015, 5:16 PM · Conpherence, PHUI
epriestley added a revision to T8151: Decide the fate of JX.Scrollbar: Unknown Object (Differential Revision).
May 10 2015, 5:13 PM · Conpherence, PHUI
epriestley moved T7494: Scrolling is... super bad in Chrome? from Backlog to Scrollbar on the PHUI board.
May 10 2015, 4:39 PM · PHUI
epriestley moved T8122: Unable to scroll on mobile if horizontal scroll is available from Backlog to Scrollbar on the PHUI board.
May 10 2015, 4:39 PM · Google Chrome, PHUI, Mobile
epriestley moved T8151: Decide the fate of JX.Scrollbar from Backlog to Scrollbar on the PHUI board.
May 10 2015, 4:39 PM · Conpherence, PHUI
epriestley renamed T8151: Decide the fate of JX.Scrollbar from Mitigate JX.Scrollbar problems to Decide the fate of JX.Scrollbar.
May 10 2015, 4:39 PM · Conpherence, PHUI
epriestley created T8151: Decide the fate of JX.Scrollbar.
May 10 2015, 4:37 PM · Conpherence, PHUI
epriestley created T8150: Phriction document actions should be a real dropdown.
May 10 2015, 3:25 PM · Phriction
epriestley edited the content of Changelog.
May 10 2015, 3:22 PM
epriestley created 2015 Week 19 (Early May).
May 10 2015, 3:22 PM
epriestley merged task T5228: Perhaps remove the commit hook mode from linters into T7674: Remove support for arc commit hooks.
May 10 2015, 3:11 PM · Arcanist
epriestley updated subscribers of T7674: Remove support for arc commit hooks.
May 10 2015, 3:11 PM · Lint, Arcanist
epriestley added a comment to T5228: Perhaps remove the commit hook mode from linters.

woah clipboards woah crazy new technology T7674

May 10 2015, 3:11 PM · Arcanist
epriestley added a comment to T5228: Perhaps remove the commit hook mode from linters.

We removed this in T5228.

May 10 2015, 3:11 PM · Arcanist

May 9 2015

epriestley added a comment to T8146: Enable custom formatting of Maniphest tasks based on status .

No. T4863 covers both the list view and card view.

May 9 2015, 8:50 PM · Maniphest
epriestley closed T8140: Handle not loaded exception after setting project picture as Resolved by committing Restricted Diffusion Commit.
May 9 2015, 8:31 PM · Projects
epriestley merged task T8146: Enable custom formatting of Maniphest tasks based on status into T4863: Allow Workboard Cards to be customized for display.
May 9 2015, 8:25 PM · Maniphest
epriestley updated subscribers of T4863: Allow Workboard Cards to be customized for display.
May 9 2015, 8:25 PM · Projects, Wikimedia, Workboards
epriestley added a comment to T8140: Handle not loaded exception after setting project picture.

Thanks!

May 9 2015, 7:41 PM · Projects
epriestley closed T8139: Human readable results are not shown as Resolved by committing Restricted Diffusion Commit.
May 9 2015, 5:05 PM · Mobile, Conduit
epriestley added a revision to T8139: Human readable results are not shown: Unknown Object (Differential Revision).
May 9 2015, 3:53 PM · Mobile, Conduit
epriestley added a comment to T8140: Handle not loaded exception after setting project picture.

It's possible that rP528f1a9 fixed this, if you were newer than rP7556a70 but didn't have that fix yet. The window between them was about 5 hours on May 7th.

May 9 2015, 3:41 PM · Projects
epriestley added a comment to T8140: Handle not loaded exception after setting project picture.

I can't reproduce this locally -- can you reproduce it here? I made you a project if you want to try:

May 9 2015, 3:40 PM · Projects
epriestley created hachque Test Project.
May 9 2015, 3:39 PM
epriestley added a comment to T8143: Allow creation of Conduit API Tokens for bots.

The settings page when editing bot users should allow the creation of Conduit API tokens

May 9 2015, 2:49 PM · Conduit
epriestley added a comment to T8139: Human readable results are not shown.

These work fine on desktop, just collapsing on mobile for some reason.

May 9 2015, 1:44 AM · Mobile, Conduit

May 8 2015

epriestley added a comment to T8136: Extra transactions for "converting from all day event".

Specifically, repro steps are:

May 8 2015, 11:21 PM · Calendar
epriestley updated subscribers of T8136: Extra transactions for "converting from all day event".
May 8 2015, 11:16 PM · Calendar
epriestley created T8137: Use event names on Calendar month view.
May 8 2015, 11:16 PM · Calendar
epriestley created T8136: Extra transactions for "converting from all day event".
May 8 2015, 11:15 PM · Calendar
epriestley added a comment to T8129: PHD init / lsb standard control mechanism.

Do other non-linux POSIX systems expect different, incompatible behaviors?

May 8 2015, 10:25 PM · Daemons
epriestley added a revision to T3165: Provide Search in Conpherence: Unknown Object (Differential Revision).
May 8 2015, 8:38 PM · Conpherence (v4)
epriestley closed T6073: Bot object name handler should probably only match whole words as Resolved by committing Restricted Diffusion Commit.
May 8 2015, 7:20 PM · Phabot
epriestley closed T7775: PhabricatorBot calls deprecated Conduit method "diffusion.getcommits" as Resolved by committing Restricted Diffusion Commit.
May 8 2015, 7:20 PM · Phabot, Conduit
epriestley closed T8112: Visiting project pages doesn't clear notifications about them as Resolved by committing Restricted Diffusion Commit.
May 8 2015, 7:20 PM · Projects
gabe awarded T7447: Bring inline comments forward across revision updates a Like token.
May 8 2015, 7:13 PM · Prioritized, Differential
epriestley closed T8132: Webhook Support as Resolved.

Yep, @avivey's got it.

May 8 2015, 6:59 PM · Maniphest, Diffusion
epriestley moved T6875: Merge Chatlog into Conpherence, or remove it from v3 to Future Bot/API Update on the Conpherence board.
May 8 2015, 4:42 PM · Chatlog, Conpherence
epriestley added a comment to T8002: Diffusion "Locate File" typeahead silently failing.

We can potentially detect this by looking for --enable-sigchild in phpinfo() or running an empirical test, but I'd want to wait until at least one other person runs into it.

May 8 2015, 4:32 PM · Diffusion
epriestley edited P1778 ./configure (PHP).
May 8 2015, 3:09 PM
epriestley added a revision to T4377: Long-running bots which don't make Conduit calls for 24 hours fail all future calls: Unknown Object (Differential Revision).
May 8 2015, 2:58 PM · Conpherence, Phabot