Page MenuHomePhabricator
Create Task
Maniphest T6073

Bot object name handler should probably only match whole words
Closed, ResolvedPublic
Actions

Description

Someone posted a mac address and got a lot of spam

<christopher> foo bar:D2
<phabot> D2: Code Review is a pretty okay idea - http://phabricator.local/D2 
<christopher> asdfda sadfdaD3
<christopher> foo bar-D3
<phabot> D3: Cool Changes - http://phabricator.local/D3

On the other hand I see things like (D3) fairly often. Noting a minor issue, not super important.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

cburroughs created this task.Sep 10 2014, 9:27 PM
cburroughs raised the priority of this task from to Needs Triage.
cburroughs updated the task description. (Show Details)
cburroughs added a project: Phabot.
cburroughs added a subscriber: cburroughs.
epriestley added a subscriber: epriestley.Sep 10 2014, 9:29 PM

We no longer match X-Dnnn at HEAD, but the (Dnnn) is a valid use case. We can blacklist :, I guess. You can also use remarkup.ignored-object-names to ignore objects in the form Dn.

epriestley added a comment.Sep 10 2014, 9:29 PM

(Most of this doesn't apply to the IRC bot, which uses different rules.)

epriestley triaged this task as Wishlist priority.Sep 10 2014, 9:42 PM
epriestley renamed this task from object name handler should probably only match whole words to Bot object name handler should probably only match whole words.Sep 10 2014, 9:50 PM
eadler added a subscriber: eadler.Apr 27 2015, 10:57 PM
epriestley added a revision: Restricted Differential Revision.May 8 2015, 2:58 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.May 8 2015, 7:20 PM
epriestley added a commit: Restricted Diffusion Commit.
Phabricator · Built by Phacility