Page MenuHomePhabricator

disabling fancy scrollbars workaround still breaks keyboard scrolling
Closed, ResolvedPublic

Description

My understanding is that something along these lines was likely to be the default behavior if confluence is disabled or maybe a per user get off my lawn button. Anyway:

On debian with the Firefox (well ice-whatever) ESR release.

<epriestley> https://secure.phabricator.com/diffusion/P/browse/master/webroot/rsrc/externals/javelin/lib/Scrollbar.js;7acaf25bcc14d9cb74ab33f10c2e38868db80ddb$29
<epriestley> Patch is to add this on that line:
<epriestley> return;
diff --git a/webroot/rsrc/externals/javelin/lib/Scrollbar.js b/webroot/rsrc/externals/javelin/lib/Scrollbar.js
index 2242e04..215d357 100644
--- a/webroot/rsrc/externals/javelin/lib/Scrollbar.js
+++ b/webroot/rsrc/externals/javelin/lib/Scrollbar.js
@@ -26,7 +26,7 @@ JX.install('Scrollbar', {
 
   construct: function(frame) {
     this._frame = frame;
-
+    return;
     // Before doing anything, check if the scrollbar control has a measurable
     // width. If it doesn't, we're already in an environment with an aesthetic
     // scrollbar (like Safari on OSX with no mouse connected, or an iPhone)

Cut the release yesterday at 894025778c2f2ca97dd26d312a3e1518fb92ad76.

Event Timeline

cburroughs raised the priority of this task from to Needs Triage.
cburroughs updated the task description. (Show Details)
cburroughs added a subscriber: cburroughs.

Press down arrow or page down, nothing happens

I can't reproduce this with Firefox, Chrome or Safari on OSX. We have code which fixes this for most browsers, but your Lunix version must have slightly different behavior.

Oh, right, the workaround is killing the fix.

I'll restructure this so we have a better workaround; we'll need that when we eventually have an optional disable anyway.

chad moved this task from Backlog to Scrollbar on the PHUI board.
chad triaged this task as Low priority.Feb 20 2015, 2:09 AM

we'll need that when we eventually have an optional disable anyway.

Scrollbar discussion is spread across a number of diffs/tickets/conpherence-v2-planning places. Is there a ticket specifically for the disable option? (I searched and could not find one)

epriestley claimed this task.

Obsoleted in HEAD.